[Bug 525389] Review Request: madwimax - Driver for mobile WiMAX devices based on Samsung CMC-730 chip
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525389 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||0.1.1-2.fc11 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525389] Review Request: madwimax - Driver for mobile WiMAX devices based on Samsung CMC-730 chip
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525389 --- Comment #11 from Fedora Update System upda...@fedoraproject.org 2009-10-13 21:46:05 EDT --- madwimax-0.1.1-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525389] Review Request: madwimax - Driver for mobile WiMAX devices based on Samsung CMC-730 chip
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525389 --- Comment #10 from Fedora Update System upda...@fedoraproject.org 2009-10-08 18:58:51 EDT --- madwimax-0.1.1-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/madwimax-0.1.1-2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525389] Review Request: madwimax - Driver for mobile WiMAX devices based on Samsung CMC-730 chip
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525389 --- Comment #9 from Fedora Update System upda...@fedoraproject.org 2009-10-08 18:57:48 EDT --- madwimax-0.1.1-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/madwimax-0.1.1-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525389] Review Request: madwimax - Driver for mobile WiMAX devices based on Samsung CMC-730 chip
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525389 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added CC||tcall...@redhat.com Blocks|182235(FE-Legal)| --- Comment #4 from Tom spot Callaway tcall...@redhat.com 2009-10-06 10:44:00 EDT --- Lifting FE-Legal, this seems to be acceptable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525389] Review Request: madwimax - Driver for mobile WiMAX devices based on Samsung CMC-730 chip
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525389 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Peter Lemenkov lemen...@gmail.com 2009-10-06 10:48:42 EDT --- Thanks, Tom. This package is APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525389] Review Request: madwimax - Driver for mobile WiMAX devices based on Samsung CMC-730 chip
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525389 Alexey Torkhov atork...@gmail.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Alexey Torkhov atork...@gmail.com 2009-10-06 10:50:39 EDT --- Thanks. New Package CVS Request === Package Name: madwimax Short Description: Driver for mobile WiMAX devices based on Samsung CMC-730 chip Owners: atorkhov Branches: F-11 F-12 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525389] Review Request: madwimax - Driver for mobile WiMAX devices based on Samsung CMC-730 chip
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525389 --- Comment #7 from Alexey Torkhov atork...@gmail.com 2009-10-06 10:52:36 EDT --- Please, shorten these lines. Yes, and will do this before importing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525389] Review Request: madwimax - Driver for mobile WiMAX devices based on Samsung CMC-730 chip
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525389 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #8 from Kevin Fenzi ke...@tummy.com 2009-10-06 13:29:18 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525389] Review Request: madwimax - Driver for mobile WiMAX devices based on Samsung CMC-730 chip
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525389 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Blocks||496433(RussianFedoraRemix) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525389] Review Request: madwimax - Driver for mobile WiMAX devices based on Samsung CMC-730 chip
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525389 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Blocks||182235(FE-Legal) --- Comment #2 from Peter Lemenkov lemen...@gmail.com 2009-09-25 03:30:01 EDT --- Ok, continuing with review. Since all data was collected by the way, similar to one, used by folks from nouveau project (exploring data dumps, w/o reverse engineering binary driver blobs from manufacturer), I don't think that there are legal issues. However, just to be sure, I'm raising FE-LEGAL flag here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525389] Review Request: madwimax - Driver for mobile WiMAX devices based on Samsung CMC-730 chip
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=525389
--- Comment #3 from Peter Lemenkov lemen...@gmail.com 2009-09-25 03:44:55
EDT ---
Assuming, that FE-LEGAL probably will be unblocked, here is my
REVIEW:
* rpmlint is not silent.
[pe...@sulaco ~]$ rpmlint
~/fuse/sshfs/work/Desktop/madwimax-0.1.1-1.fc11.ppc.rpm
madwimax.ppc: E: summary-too-long User-space driver for mobile WiMAX (802.16e)
devices based on Samsung CMC-730 chip
madwimax.ppc: E: description-line-too-long madWiMAX is a reverse-engineered
Linux driver for mobile WiMAX (802.16e) devices based on Samsung CMC-730 chip.
These devices are currently supported:
madwimax.ppc: W: non-conffile-in-etc /etc/udev/rules.d/z60_madwimax.rules
1 packages and 0 specfiles checked; 2 errors, 1 warnings.
[pe...@sulaco ~]$
Please, shorten these lines.
+ The package is named according to the Package Naming Guidelines .
+ The spec file name matches the base package %{name}, in the format
%{name}.spec .
+ The package meets the Packaging Guidelines .
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines .
+ The License field in the package spec file must match the actual license.
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matches the upstream source, as
provided in the spec URL.
[pe...@sulaco SOURCES]$ sha256sum madwimax-0.1.1.tar.gz*
17ac297934654663586df837dcff2bd6d3bbabddd76efdffa26713b07e08ad5f
madwimax-0.1.1.tar.gz
17ac297934654663586df837dcff2bd6d3bbabddd76efdffa26713b07e08ad5f
madwimax-0.1.1.tar.gz.1
[pe...@sulaco SOURCES]$
+ The package successfully compiles and builds into binary rpms on at least one
primary architecture. See koji logs above.
+ All build dependencies are listed in BuildRequires.
+ The packages does NOT contain copies of system libraries.
+ The package owns all directories that it creates.
+ the package does not list a file more than once in the spec file's %files
listings.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code or permissible content.
+ Everything, the package includes as %doc, does not affect the runtime of the
application.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT). [26]
+ All filenames in rpm packages are valid UTF-8.
Ok, let's wait for the reaction from the Legal Team.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 525389] Review Request: madwimax - Driver for mobile WiMAX devices based on Samsung CMC-730 chip
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=525389 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||lemen...@gmail.com AssignedTo|nob...@fedoraproject.org|lemen...@gmail.com Flag||fedora-review? --- Comment #1 from Peter Lemenkov lemen...@gmail.com 2009-09-24 06:22:02 EDT --- I'll review it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
