[Bug 530772] Review Request: pxe-kexec - Linux boots Linux via network
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530772 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #14 from Fedora Update System 2010-01-02 16:29:02 EDT --- pxe-kexec-0.2.3-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pxe-kexec'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-0087 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530772] Review Request: pxe-kexec - Linux boots Linux via network
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530772 --- Comment #15 from Fedora Update System 2010-01-02 16:31:15 EDT --- pxe-kexec-0.2.3-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update pxe-kexec'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-0101 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530772] Review Request: pxe-kexec - Linux boots Linux via network
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530772 --- Comment #13 from Fedora Update System 2010-01-02 00:25:06 EDT --- pxe-kexec-0.2.3-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/pxe-kexec-0.2.3-2.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530772] Review Request: pxe-kexec - Linux boots Linux via network
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530772 --- Comment #12 from Fedora Update System 2010-01-02 00:24:18 EDT --- pxe-kexec-0.2.3-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/pxe-kexec-0.2.3-2.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530772] Review Request: pxe-kexec - Linux boots Linux via network
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530772 --- Comment #11 from Jussi Lehtola 2010-01-01 18:03:51 EDT --- ping? ship the updates. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530772] Review Request: pxe-kexec - Linux boots Linux via network
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530772 Kevin Fenzi changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #10 from Kevin Fenzi 2009-12-06 18:22:18 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530772] Review Request: pxe-kexec - Linux boots Linux via network
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530772 Scott Collier changed: What|Removed |Added Flag||fedora-cvs? --- Comment #9 from Scott Collier 2009-12-03 21:17:58 EDT --- New Package CVS Request === Package Name: pxe-kexec Short Description: Linux boots Linux via network Owners: boodle Branches: F-11 F-12 EL-4 EL-5 InitialCC: boodle -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530772] Review Request: pxe-kexec - Linux boots Linux via network
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530772 --- Comment #8 from Scott Collier 2009-12-03 21:08:42 EDT --- (In reply to comment #7) > pxe-kexec.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 26) > 3 packages and 0 specfiles checked; 0 errors, 1 warnings. > > Fix this. You don't actually need any indentation on the make line, since the > whole command fits nicely on one line. Fixed. > > > - The changelog is messed up. Fix it. > > - If you updated the version from Ed's 0.1.7 to 0.2.3, you should have reset > the release tag to 1. So the following should be release 2. > Fixed. > > Review: > > MUST: The package does not yet exist in Fedora. The Review Request is not a > duplicate. OK > > MUST: The spec file for the package is legible and macros are used > consistently. NEEDSWORK > - Macro consistency problem. Fixed. > > > SHOULD: The package builds in mock. OK > > > Fix the spec file before import to CVS. The package has been > > APPROVED Thanks for the review Jussi. Here's the new spec and srpm: Spec URL: http://boodle.fedorapeople.org/RPMS/pxe-kexec.spec SRPM URL: http://boodle.fedorapeople.org/RPMS/pxe-kexec-0.2.3-2.fc12.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530772] Review Request: pxe-kexec - Linux boots Linux via network
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530772
Jussi Lehtola changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Comment #7 from Jussi Lehtola 2009-12-03 07:45:54
EDT ---
pxe-kexec.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 26)
3 packages and 0 specfiles checked; 0 errors, 1 warnings.
Fix this. You don't actually need any indentation on the make line, since the
whole command fits nicely on one line.
- The changelog is messed up. Fix it.
- If you updated the version from Ed's 0.1.7 to 0.2.3, you should have reset
the release tag to 1. So the following should be release 2.
Review:
MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. NEEDSWORK
- Macro consistency problem.
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. N/A
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK
Fix the spec file before import to CVS. The package has been
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530772] Review Request: pxe-kexec - Linux boots Linux via network
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=530772
--- Comment #6 from Jussi Lehtola 2009-12-03 00:22:14
EDT ---
Taking over review.
First note: use %{optflags} instead of $RPM_OPT_FLAGS since you're using
%{buildroot} in favor of $RPM_BUILD_ROOT.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530772] Review Request: pxe-kexec - Linux boots Linux via network
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530772 Jussi Lehtola changed: What|Removed |Added Status|NEW |ASSIGNED CC||jussi.leht...@iki.fi AssignedTo|nob...@fedoraproject.org|jussi.leht...@iki.fi Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530772] Review Request: pxe-kexec - Linux boots Linux via network
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530772 Matt Domsch changed: What|Removed |Added CC||matt_dom...@dell.com Blocks|177841(FE-NEEDSPONSOR) | --- Comment #5 from Matt Domsch 2009-11-13 15:25:50 EDT --- I'm Scott's sponsor. This package still needs a reviewer. Thanks, Matt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530772] Review Request: pxe-kexec - Linux boots Linux via network
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530772 --- Comment #4 from Scott Collier 2009-11-08 13:05:31 EDT --- (In reply to comment #3) > Hi Scott, > > I'm not a sponsor… > > Have you read > http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored ? > > You should show, that you understood the Guidelines and do some other reviews > and so on, so that you future sponsor will see, what reviews you have done. > > You can read more about this on the link above. Thanks for the advice Thomas. I will certainly review some packages, here's my first review: https://bugzilla.redhat.com/show_bug.cgi?id=532402#c1 I'll do some more and hopefully get a sponsor. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530772] Review Request: pxe-kexec - Linux boots Linux via network
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530772 --- Comment #3 from Thomas Spura 2009-11-08 09:57:57 EDT --- Hi Scott, I'm not a sponsor… Have you read http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored ? You should show, that you understood the Guidelines and do some other reviews and so on, so that you future sponsor will see, what reviews you have done. You can read more about this on the link above. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530772] Review Request: pxe-kexec - Linux boots Linux via network
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530772 --- Comment #2 from Scott Collier 2009-11-07 21:44:13 EDT --- Koji builds are successful: http://koji.fedoraproject.org/koji/taskinfo?taskID=1794541 http://koji.fedoraproject.org/koji/taskinfo?taskID=1794546 http://koji.fedoraproject.org/koji/taskinfo?taskID=1794551 rpmlint is clean. May I please get a sponsor? I think the package is ready to go. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530772] Review Request: pxe-kexec - Linux boots Linux via network
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530772 Thomas Spura changed: What|Removed |Added CC||toms...@fedoraproject.org Blocks||177841(FE-NEEDSPONSOR) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 530772] Review Request: pxe-kexec - Linux boots Linux via network
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=530772 Jussi Lehtola changed: What|Removed |Added CC||eswi...@aristanetworks.com --- Comment #1 from Jussi Lehtola 2009-10-24 18:38:01 EDT --- *** Bug 508352 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
