[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531255 Fedora Update System changed: What|Removed |Added Fixed In Version|1.3.3.2-2.20090920cvs.el4 |1.3.3.2-2.20090920cvs.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531255 --- Comment #17 from Fedora Update System 2009-12-17 18:57:26 EDT --- CGSI-gSOAP-1.3.3.2-2.20090920cvs.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531255 Fedora Update System changed: What|Removed |Added Fixed In Version|1.3.3.2-2.20090920cvs.fc11 |1.3.3.2-2.20090920cvs.el4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531255 --- Comment #16 from Fedora Update System 2009-12-17 18:52:00 EDT --- CGSI-gSOAP-1.3.3.2-2.20090920cvs.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531255 --- Comment #14 from Fedora Update System 2009-12-03 01:33:03 EDT --- CGSI-gSOAP-1.3.3.2-2.20090920cvs.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/CGSI-gSOAP-1.3.3.2-2.20090920cvs.el5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531255 --- Comment #15 from Fedora Update System 2009-12-03 01:33:10 EDT --- CGSI-gSOAP-1.3.3.2-2.20090920cvs.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/CGSI-gSOAP-1.3.3.2-2.20090920cvs.el4 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531255 --- Comment #13 from Mattias Ellert 2009-12-02 07:57:51 EDT --- When I did the Fedora builds gsoap was not yet in EPEL. Gsoap has now been built for EPEL, and I have requested a buildroot override in order to build CGSI-gSOAP before gsoap gets into EPEL stable. The buildroot override was added on Sunday - so it is now possible to build the packages, I just had a lot of things to do since then. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531255 --- Comment #12 from Steve Traylen 2009-12-02 07:37:19 EDT --- Is there a reason for the lack of .el4 or 5 build? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531255 Fedora Update System changed: What|Removed |Added Fixed In Version|1.3.3.2-2.20090920cvs.fc12 |1.3.3.2-2.20090920cvs.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531255 --- Comment #11 from Fedora Update System 2009-11-16 02:38:26 EDT --- CGSI-gSOAP-1.3.3.2-2.20090920cvs.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531255 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||1.3.3.2-2.20090920cvs.fc12 Resolution||ERRATA -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531255 --- Comment #10 from Fedora Update System 2009-11-16 02:28:54 EDT --- CGSI-gSOAP-1.3.3.2-2.20090920cvs.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531255 --- Comment #9 from Fedora Update System 2009-11-14 05:50:25 EDT --- CGSI-gSOAP-1.3.3.2-2.20090920cvs.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/CGSI-gSOAP-1.3.3.2-2.20090920cvs.fc11 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531255 --- Comment #8 from Fedora Update System 2009-11-14 05:50:19 EDT --- CGSI-gSOAP-1.3.3.2-2.20090920cvs.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/CGSI-gSOAP-1.3.3.2-2.20090920cvs.fc12 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531255 Jason Tibbitts changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Jason Tibbitts 2009-11-13 14:35:26 EDT --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531255 Mattias Ellert changed: What|Removed |Added Flag||fedora-cvs? --- Comment #6 from Mattias Ellert 2009-11-13 03:35:36 EDT --- Many thanks for the review. New Package CVS Request === Package Name: CGSI-gSOAP Short Description: GSI plugin for gSOAP Owners: ellert Branches: F-11 F-12 EL-4 EL-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531255 Steve Traylen changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #5 from Steve Traylen 2009-11-12 15:22:02 EDT --- Review of CGSI-gSOAP.spec Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1804012 + rpmlint clean $ rpmlint SPECS/CGSI-gSOAP.spec SRPMS/CGSI-gSOAP-1.3.3.2-2.20090920cvs.fc12.src.rpm RPMS/x86_64/CGSI-gSOAP-* 4 packages and 1 specfiles checked; 0 errors, 0 warnings. + Package name good. + Spec file name good. + Meets the pkg guidelines. + Spec Licensed with ASL 2.0 + Code is also ASL 2.0 + A LICENSE file is present. + English spec + Legible spec. + Source matches upstream. diff -r --brief CGSI-gSOAP-1.3.3.2 /tmp/CGSI-gSOAP-1.3.3.2 + Builds as per koji above. + Builds on all arches. + BR sensible. + No locales present. + ldconfig called correctly. + No system libs. + Not relocatable. + Owns all directories it creates or pulls them in. + No file duplicates. + All %defattr + %clean is cleaned. + Consitant use of macros. + Contain code. + No large docs. + %doc not needed for runtime. + headers in devel. + No pkg-config files. + .so in devel. + "-devel" requires explicitly "" + no .la files. + No gui + Does not own forign package files. + %install does clean. + utf8. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531255 --- Comment #4 from Mattias Ellert 2009-11-12 02:34:29 EDT --- Of course. Fixed. http://www.grid.tsl.uu.se/review/CGSI-gSOAP.spec http://www.grid.tsl.uu.se/review/CGSI-gSOAP-1.3.3.2-2.20090920cvs.fc11.src.rpm Mattias -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=531255
--- Comment #3 from Steve Traylen 2009-11-12 01:28:55
EDT ---
Provides: CGSI_gSOAP-devel = %{version}-%{release}
Obsoletes: CGSI_gSOAP-devel < 1.3.2.2-3
to go as well.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531255 --- Comment #2 from Mattias Ellert 2009-11-11 22:51:42 EDT --- New version available: Spec URL: http://www.grid.tsl.uu.se/review/CGSI-gSOAP.spec SRPM URL: http://www.grid.tsl.uu.se/review/CGSI-gSOAP-1.3.3.2-2.20090920cvs.fc11.src.rpm The release tag now contains the cvs date. The Provides/Obsoletes for the old package name that was never in Fedora is removed. Since all files inside the doc directory are also doc I see no problem with marking the directory doc too. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=531255
--- Comment #1 from Steve Traylen 2009-11-09 15:18:00
EDT ---
1)
What's the reason for the
Provides: CGSI_gSOAP = %{version}-%{release}
Obsoletes: CGSI_gSOAP < 1.3.2.2-3
where was CGSI_gSOAP released?
2)
I read in another review that
%{_docdir}/%{name}-devel-%{version}
should not be marked as a %doc but only the items inside it though
to be honest it makes more sense to me if it is a %doc to be left
out upon installing with no %docs.
3)
Given the cvs tag is a date should the release number not reflect this?
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages
Other than that looking good.
Steve
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531255 Steve Traylen changed: What|Removed |Added Status|NEW |ASSIGNED CC||steve.tray...@cern.ch AssignedTo|nob...@fedoraproject.org|steve.tray...@cern.ch Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531255 Mattias Ellert changed: What|Removed |Added Blocks||531258 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 531255] Review Request: CGSI-gSOAP - GSI plugin for gSOAP
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=531255 Mattias Ellert changed: What|Removed |Added Blocks||531256 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
