[Bug 538332] Review Request: covered - Verilog code coverage analyzer

2009-11-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538332


Chitlesh GOORAH  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 538332] Review Request: covered - Verilog code coverage analyzer

2009-11-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538332


Dennis Gilmore  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #3 from Dennis Gilmore   2009-11-20 16:54:23 EDT 
---
CVS done

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 538332] Review Request: covered - Verilog code coverage analyzer

2009-11-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538332


Chitlesh GOORAH  changed:

   What|Removed |Added

   Flag||fedora-cvs?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 538332] Review Request: covered - Verilog code coverage analyzer

2009-11-20 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538332





--- Comment #2 from Chitlesh GOORAH   2009-11-20 07:34:40 
EDT ---
New Package CVS Request
===
Package Name: covered
Short Description: Verilog code coverage analyzer
Owners: chitlesh
Branches: F-11 F-12 EL-5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 538332] Review Request: covered - Verilog code coverage analyzer

2009-11-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538332


Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
 AssignedTo|nob...@fedoraproject.org|panem...@gmail.com
   Flag||fedora-review+




--- Comment #1 from Parag AN(पराग)   2009-11-20 02:15:58 
EDT ---

Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1818896
+ rpmlint output for SRPM and for RPM.
covered.i686: E: explicit-lib-dependency tklib
covered.i686: W: hidden-file-or-dir /usr/share/covered/.coveredrc
==> can be ignored
+ source files match upstream url (sha1sum)
334783f26365d9c12c11773b48da790c45b51eb4  covered-0.7.7.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ gtk-update-icon-cache scriptlets present.
+ no duplicates in %files.
+ Desktop file installed correctly.
+ file permissions are appropriate.
+ Package covered-0.7.7-1.fc13.i686 =>
Provides: covered.cver.so covered.vpi
Requires: libX11.so.6 libXft.so.2 libXrender.so.1 libc.so.6
libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3)
libc.so.6(GLIBC_2.11) libc.so.6(GLIBC_2.2) libc.so.6(GLIBC_2.3)
libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libc.so.6(GLIBC_2.7) libdl.so.2
libfontconfig.so.1 libfreetype.so.6 libm.so.6 libm.so.6(GLIBC_2.1) libtcl8.5.so
libtk8.5.so libz.so.1 rtld(GNU_HASH)
+ GUI application

Suggestions:
1) you can use Source URL as simple as
http://downloads.sourceforge.net/covered/covered-0.7.7.tar.gz
Reference:-http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net
2) License should be GPLv2+

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review