[Bug 544869] Review Request: udunits2 - A library for manipulating units of physical quantities

2010-01-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=544869


Orion Poplawski  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Comment #5 from Orion Poplawski   2010-01-06 18:12:31 
EDT ---
Checked in and built.  Thanks all...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 544869] Review Request: udunits2 - A library for manipulating units of physical quantities

2010-01-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=544869


Kevin Fenzi  changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #4 from Kevin Fenzi   2010-01-06 16:38:17 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 544869] Review Request: udunits2 - A library for manipulating units of physical quantities

2010-01-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=544869





--- Comment #3 from Tom "spot" Callaway   2010-01-06 
13:00:50 EDT ---
Sorry for not getting to this sooner.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 544869] Review Request: udunits2 - A library for manipulating units of physical quantities

2010-01-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=544869


Orion Poplawski  changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #2 from Orion Poplawski   2010-01-06 12:55:20 
EDT ---
New Package CVS Request
===
Package Name: udunits2
Short Description: A library for manipulating units of physical quantities
Owners: spot orion
Branches: F-12 F-11 EL-5 EL-4
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 544869] Review Request: udunits2 - A library for manipulating units of physical quantities

2009-12-31 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=544869


Orion Poplawski  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||or...@cora.nwra.com
 AssignedTo|nob...@fedoraproject.org|or...@cora.nwra.com
   Flag||fedora-review+




--- Comment #1 from Orion Poplawski   2009-12-31 12:14:47 
EDT ---
*  rpmlint

udunits2.i686: W: shared-lib-calls-exit /usr/lib/libudunits2.so.0.0.0
e...@glibc_2.0

A number to UCAR libraries do this - often only when a certain flag is set. 
Probably worth pinging upstream about though.  Not blocking the review though.

* naming - okay
* NamingGuidelines
* licensing - MIT
* osi approved? yes
* included? yes
* correct mentioned in specfile? yes

specfile

* American English - yes
* legible - yes
* BuildRequires - good
* Locales - NA
* shared libraries: ldconfig - yes
*  %clean section with rm -rf ${RPM_BUILD_ROOT} - yes
* macros - consistent
* sources - checksums match upstream
* relocatable? Prefix: /usr? - NA
* files and directories  - good
* owns all created directories - yes
* all files listed in %files - yes
* permissions? - good
* deffattr? - yes
* no .la files - yes
 * no conflicts with other packets - checked okay with udunits
* -devel - yes
* headers - yes
* static libraries - NA
* .so without suffix when .so.suffix existent - nope
* .pc files - NA
* permissable content - yes
* doc - yes
* large doc in -doc package - NA
* must not affect runtime - good

* mock build - yes
* sane scriptlets - yes
* subpackages with fully versioned dependency - yes

Looks good.  Approved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review