Re: Filtering lib provides in XS packages?

2009-03-02 Thread Paul Howarth
On Sun, 1 Mar 2009 14:08:51 -0800
Chris Weyl  wrote:

> On Sun, Mar 1, 2009 at 11:16 AM, Chris Weyl 
> wrote:
> > So:
> >
> > bug 487958 - [rpm] rtld(GNU_HASH) dropped
> > bug 487960 - [rpmdevtools] RFE: filter Perl private libs for
> > arch-specific packages
> 
> Well, the spec template addition looks to be a no-go...  Apparently
> solving an actual problem is too ugly to be included :-)  I suspect
> that doesn't matter too much anyways, as most people seem to use
> either cpanspec or CPANPLUS::Dist::RPM to build out their initial spec
> files.
> 
> I also just filed two more:
> 
> bug 487972 - [rpm] RFE: filter private Perl lib provides
> bug 487974 - [rpmlint] RFE: error on shlib provides from under
> %perl_*arch
> 
> I have very low hopes for 487972; AFAIK no request for rpm to filter
> certain provides from any specific directory has ever been granted.

This version seems to work a little better:

# don't "provide" private Perl libs
%global _use_internal_dependency_generator 0
%global __deploop() while read FILE; do /usr/lib/rpm/rpmdeps -%{1} ${FILE}; 
done | /bin/sort -u
%global __find_provides /bin/sh -c "%{__grep} -v '%{perl_vendorarch}/.*\\.so$' 
| %{__deploop P}"
%global __find_requires /bin/sh -c "%{__deploop R}"

Paul.

--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
Fedora-perl-devel-list mailing list
Fedora-perl-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-perl-devel-list


rpms/perl-Workflow/devel .cvsignore, 1.2, 1.3 perl-Workflow.spec, 1.4, 1.5 sources, 1.2, 1.3

2009-03-02 Thread Chris Weyl
Author: cweyl

Update of /cvs/extras/rpms/perl-Workflow/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv30829

Modified Files:
.cvsignore perl-Workflow.spec sources 
Log Message:
* Mon Mar 02 2009 Chris Weyl  1.32-1
- update to 1.32
- update br's to latest required



Index: .cvsignore
===
RCS file: /cvs/extras/rpms/perl-Workflow/devel/.cvsignore,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- .cvsignore  25 Apr 2007 18:45:37 -  1.2
+++ .cvsignore  3 Mar 2009 04:15:02 -   1.3
@@ -1 +1,8 @@
-Workflow-0.26.tar.gz
+Workflow-1.32.tar.gz
+Workflow-*
+*.rpm
+*.gz
+*.tar
+noarch
+clog
+.build*


Index: perl-Workflow.spec
===
RCS file: /cvs/extras/rpms/perl-Workflow/devel/perl-Workflow.spec,v
retrieving revision 1.4
retrieving revision 1.5
diff -u -r1.4 -r1.5
--- perl-Workflow.spec  27 Feb 2009 04:21:59 -  1.4
+++ perl-Workflow.spec  3 Mar 2009 04:15:03 -   1.5
@@ -1,6 +1,6 @@
 Name:   perl-Workflow
-Version:0.26
-Release:5%{?dist}
+Version:1.32
+Release:1%{?dist}
 Summary:Simple, flexible system to implement workflows
 License:GPL+ or Artistic
 Group:  Development/Libraries
@@ -15,19 +15,32 @@
 %define __perl_provides %{SOURCE98}
 %define __perl_requires %{SOURCE99}
 
-BuildRequires:  perl, perl(Module::Build)
+BuildRequires:  perl 
+BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(Module::Build)
+BuildRequires:  perl(Carp)
 BuildRequires:  perl(Class::Accessor) >= 0.18
 BuildRequires:  perl(Class::Factory) >= 1
 BuildRequires:  perl(Class::Observable) >= 1.04
 BuildRequires:  perl(DateTime) >= 0.15
 BuildRequires:  perl(DateTime::Format::Strptime) >= 1
+BuildRequires:  perl(Data::Dumper)
 BuildRequires:  perl(DBD::Mock) >= 0.1
+BuildRequires:  perl(DBI)
 BuildRequires:  perl(Exception::Class) >= 1.1
+BuildRequires:  perl(File::Slurp)
+BuildRequires:  perl(List::MoreUtils)
 BuildRequires:  perl(Log::Dispatch) >= 2
 BuildRequires:  perl(Log::Log4perl) >= 0.34
 BuildRequires:  perl(Test::Exception)
 BuildRequires:  perl(XML::Simple) >= 2
 
+# tests
+BuildRequires:  perl(Test::More)
+BuildRequires:  perl(DateTime)
+BuildRequires:  perl(DateTime::Format::Strptime)
+BuildRequires:  perl(DBD::SQLite)
+
 # optional test #1
 BuildRequires:  perl(Data::UUID)
 # optional test #2 -- not in Fedora yet
@@ -85,6 +98,10 @@
 %{_mandir}/man3/*
 
 %changelog
+* Mon Mar 02 2009 Chris Weyl  1.32-1
+- update to 1.32
+- update br's to latest required
+
 * Thu Feb 26 2009 Fedora Release Engineering  
- 0.26-5
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_11_Mass_Rebuild
 


Index: sources
===
RCS file: /cvs/extras/rpms/perl-Workflow/devel/sources,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- sources 25 Apr 2007 18:45:37 -  1.2
+++ sources 3 Mar 2009 04:15:03 -   1.3
@@ -1 +1 @@
-e9c25c357b0e2a62fa91493b818a538f  Workflow-0.26.tar.gz
+fd82389980de5640b9b100c17a930f90  Workflow-1.32.tar.gz

--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
Fedora-perl-devel-list mailing list
Fedora-perl-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-perl-devel-list


rpms/perl-GStreamer/devel .cvsignore, 1.2, 1.3 perl-GStreamer.spec, 1.7, 1.8 sources, 1.2, 1.3

2009-03-02 Thread Chris Weyl
Author: cweyl

Update of /cvs/extras/rpms/perl-GStreamer/devel
In directory cvs1.fedora.phx.redhat.com:/tmp/cvs-serv2518

Modified Files:
.cvsignore perl-GStreamer.spec sources 
Log Message:
* Mon Mar 02 2009 Chris Weyl  0.15-1
- update to 1.15
- trim doc
- update BR's



Index: .cvsignore
===
RCS file: /cvs/extras/rpms/perl-GStreamer/devel/.cvsignore,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- .cvsignore  2 Sep 2006 08:49:26 -   1.2
+++ .cvsignore  3 Mar 2009 04:39:00 -   1.3
@@ -1 +1,9 @@
-GStreamer-0.09.tar.gz
+GStreamer-0.15.tar.gz
+GStreamer-*
+*.rpm
+*.gz
+*.tar
+clog
+.build*
+x86_64
+i386


Index: perl-GStreamer.spec
===
RCS file: /cvs/extras/rpms/perl-GStreamer/devel/perl-GStreamer.spec,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -r1.7 -r1.8
--- perl-GStreamer.spec 26 Feb 2009 16:52:03 -  1.7
+++ perl-GStreamer.spec 3 Mar 2009 04:39:00 -   1.8
@@ -1,23 +1,25 @@
 Name:   perl-GStreamer
-Version:0.09
-Release:7%{?dist}
+Version:0.15
+Release:1%{?dist}
 Summary:Perl bindings to the GStreamer framework
 License:LGPLv2+
 Group:  Development/Libraries
 URL:http://search.cpan.org/dist/GStreamer/
 Source0:
http://www.cpan.org/authors/id/T/TS/TSCH/GStreamer-%{version}.tar.gz
-
 # see http://bugzilla.gnome.org/show_bug.cgi?id=348454
 Patch0: test.patch
-
 BuildRoot:  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+Requires:   perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo 
$version))
 
-BuildRequires:  perl(ExtUtils::Depends) >= 0.205
-BuildRequires:  perl(ExtUtils::PkgConfig) >= 1.07
-BuildRequires:  perl(Glib) >= 1.120
+# non-perl
 BuildRequires:  gstreamer-devel
 
-Requires:   perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo 
$version))
+BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(ExtUtils::Depends) >= 0.205
+BuildRequires:  perl(ExtUtils::PkgConfig) >= 1.07
+BuildRequires:  perl(Glib) >= 1.180
+# test
+BuildRequires:  perl(Test::More)
 
 %description
 GStreamer makes everybody dance like crazy.  It provides the means to play,
@@ -28,7 +30,7 @@
 
 %prep
 %setup -q -n GStreamer-%{version}
-%patch0 -p0
+#patch0 -p0
 
 %build
 %{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="%{optflags}"
@@ -60,17 +62,22 @@
 
 %files
 %defattr(-,root,root,-)
-%doc ChangeLog doctypes gst.typemap LICENSE maps NEWS README TODO examples/
+%doc ChangeLog doctypes LICENSE MAINTAINERS NEWS README TODO examples/
 %{perl_vendorarch}/auto/*
 %{perl_vendorarch}/GStreamer*
 %{_mandir}/man3/*
 
 %changelog
+* Mon Mar 02 2009 Chris Weyl  0.15-1
+- update to 1.15
+- trim doc
+- update BR's
+
 * Thu Feb 26 2009 Fedora Release Engineering  
- 0.09-7
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_11_Mass_Rebuild
 
 * Thu Mar 06 2008 Tom "spot" Callaway  - 0.09-6
-Rebuild for new perl
+- Rebuild for new perl
 
 * Mon Feb 18 2008 Fedora Release Engineering  - 
0.09-5
 - Autorebuild for GCC 4.3


Index: sources
===
RCS file: /cvs/extras/rpms/perl-GStreamer/devel/sources,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- sources 2 Sep 2006 08:49:26 -   1.2
+++ sources 3 Mar 2009 04:39:00 -   1.3
@@ -1 +1 @@
-4f6f27edded250b00055d076eb738ff5  GStreamer-0.09.tar.gz
+a01261f5a1012f4d6763e3721f1c9de7  GStreamer-0.15.tar.gz

--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
Fedora-perl-devel-list mailing list
Fedora-perl-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-perl-devel-list


[Bug 485621] Review Request: perl-Gtk2-MozEmbed - Interface to the Mozilla embedding widget

2009-03-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485621


Chris Weyl  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||cw...@alumni.drew.edu
 AssignedTo|nob...@fedoraproject.org|cw...@alumni.drew.edu
  Alias||perl-Gtk2-MozEmbed
   Flag||fedora-review?




--- Comment #1 from Chris Weyl   2009-03-03 00:32:10 EDT 
---
rpmlint's warnings are expected for Perl packages; and while
MozEmbed.so()(64bit) will need to be filtered, we're still figuring out the
best way to do that over on fedora-perl-devel-list, so that's not a blocker
right now.

1) MozEmbed.xs and other source files say LGPLv2+.

2) %check should be included, even if "make test" needs to be wrapped in some
construct to prevent it from running in mock, e.g.:

   %{?_with_display_tests: make test}

This will allow rebuilding locally using "rpmbuild --with display-tests" or
defining "%_with_display_tests 1" in ~/.rpmmacros.

3) '%{__rm}' should be replaced with just 'rm', or make and chmod also need to
be their macro representations.  (Though I always prefer the %{_fixperms} chmod
incantation :))

4) %{perl_vendorarch}/Gtk2 and %{perl_vendorarch}/auto/Gtk2 need to be included
as dirs in %files.  One easy way to do so is:

%{perl_vendorarch}/*
%exclude %dir %{perl_vendorarch}/auto/

koji @ http://koji.fedoraproject.org/koji/taskinfo?taskID=1215907

Source tarball matches upstream:

23ffb8e4134ee8a8897149bf9db43d400cdbbe17  Gtk2-MozEmbed-0.08.tar.gz
23ffb8e4134ee8a8897149bf9db43d400cdbbe17  Gtk2-MozEmbed-0.08.tar.gz.srpm

Provides, requires and rpmlint looks sane:

=> perl-Gtk2-MozEmbed-0.08-1.fc10.x86_64.rpm <=
> rpmlint
perl-Gtk2-MozEmbed.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/Gtk2/MozEmbed/Install/gtkmozembed2perl.h
perl-Gtk2-MozEmbed.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/perl5/vendor_perl/5.10.0/x86_64-linux-thread-multi/Gtk2/MozEmbed/Install/gtkmozembed2perl-autogen.h
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
> provides for perl-Gtk2-MozEmbed-0.08-1.fc10.x86_64.rpm
MozEmbed.so()(64bit)  
perl(Gtk2::MozEmbed) = 0.08
perl(Gtk2::MozEmbed::Install::Files)  
perl-Gtk2-MozEmbed = 0.08-1.fc10
perl-Gtk2-MozEmbed(x86-64) = 0.08-1.fc10
> requires for perl-Gtk2-MozEmbed-0.08-1.fc10.x86_64.rpm
gecko-libs = 1.9.0.6
libatk-1.0.so.0()(64bit)  
libc.so.6()(64bit)  
libc.so.6(GLIBC_2.2.5)(64bit)  
libcairo.so.2()(64bit)  
libdl.so.2()(64bit)  
libgdk-x11-2.0.so.0()(64bit)  
libgdk_pixbuf-2.0.so.0()(64bit)  
libglib-2.0.so.0()(64bit)  
libgmodule-2.0.so.0()(64bit)  
libgobject-2.0.so.0()(64bit)  
libgthread-2.0.so.0()(64bit)  
libgtk-x11-2.0.so.0()(64bit)  
libnspr4.so()(64bit)  
libpango-1.0.so.0()(64bit)  
libpangocairo-1.0.so.0()(64bit)  
libplc4.so()(64bit)  
libplds4.so()(64bit)  
libpthread.so.0()(64bit)  
libpthread.so.0(GLIBC_2.2.5)(64bit)  
librt.so.1()(64bit)  
libxpcom.so()(64bit)  
libxul.so()(64bit)  
perl >= 0:5.008
perl(:MODULE_COMPAT_5.10.0)  
perl(DynaLoader)  
perl(Glib) >= 1.180
perl(Gtk2)  
perl(Gtk2) >= 1.081
perl(strict)  
perl(warnings)  
rtld(GNU_HASH)  

=> perl-Gtk2-MozEmbed-debuginfo-0.08-1.fc10.x86_64.rpm <=
> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> provides for perl-Gtk2-MozEmbed-debuginfo-0.08-1.fc10.x86_64.rpm
perl-Gtk2-MozEmbed-debuginfo = 0.08-1.fc10
perl-Gtk2-MozEmbed-debuginfo(x86-64) = 0.08-1.fc10
> requires for perl-Gtk2-MozEmbed-debuginfo-0.08-1.fc10.x86_64.rpm

Address #1-4 and I think we're in business :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
Fedora-perl-devel-list mailing list
Fedora-perl-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-perl-devel-list


[Bug 485621] Review Request: perl-Gtk2-MozEmbed - Interface to the Mozilla embedding widget

2009-03-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485621





--- Comment #2 from Remi Collet   2009-03-03 02:35:10 
EDT ---
1, 2 and 3 fixed

About 4, I don't think this folders need to be owned be the package.
Both are already owned by perl-Gtk2 which is Required .

Both are also owned by perl-Gtk2-TrayIcon which is probably a mistake (or an
exception for the Guidelines exists for perl ?)

Guidelines : Packages must not own files already owned by other packages.

http://remi.fedorapeople.org/perl-Gtk2-MozEmbed.spec
http://remi.fedorapeople.org/perl-Gtk2-MozEmbed-0.08-2.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

--
Fedora Extras Perl SIG
http://www.fedoraproject.org/wiki/Extras/SIGs/Perl
Fedora-perl-devel-list mailing list
Fedora-perl-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/fedora-perl-devel-list