[FFmpeg-cvslog] lavf/webm_chunk: Respect buffer size
ffmpeg | branch: release/4.1 | Andreas Rheinhardt
| Sat Apr 20 00:03:14 2019 +0200|
[85578838cbc0d86baac9713b2cc47054e55d1a8e] | committer: Michael Niedermayer
lavf/webm_chunk: Respect buffer size
The last argument of av_strlcpy is supposed to contain the size of the
destination buffer, but it was filled with the size of the source
string, effectively negating its very purpose.
Signed-off-by: Andreas Rheinhardt
Signed-off-by: Michael Niedermayer
(cherry picked from commit 73ef1f47f5928264a968c8fbbcfb0bf0643f)
Signed-off-by: Michael Niedermayer
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=85578838cbc0d86baac9713b2cc47054e55d1a8e
---
libavformat/webm_chunk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/webm_chunk.c b/libavformat/webm_chunk.c
index 7ceb276fc4..f60696e3ad 100644
--- a/libavformat/webm_chunk.c
+++ b/libavformat/webm_chunk.c
@@ -96,7 +96,7 @@ static int get_chunk_filename(AVFormatContext *s, int
is_header, char *filename)
av_log(oc, AV_LOG_ERROR, "No header filename provided\n");
return AVERROR(EINVAL);
}
-av_strlcpy(filename, wc->header_filename, strlen(wc->header_filename)
+ 1);
+av_strlcpy(filename, wc->header_filename, MAX_FILENAME_SIZE);
} else {
if (av_get_frame_filename(filename, MAX_FILENAME_SIZE,
s->url, wc->chunk_index - 1) < 0) {
___
ffmpeg-cvslog mailing list
ffmpeg-cvslog@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-cvslog
To unsubscribe, visit link above, or email
ffmpeg-cvslog-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-cvslog] lavf/webm_chunk: Respect buffer size
ffmpeg | branch: release/3.2 | Andreas Rheinhardt
| Sat Apr 20 00:03:14 2019 +0200|
[9fad760f56483f0b5503457c780d9f80a84784c6] | committer: Michael Niedermayer
lavf/webm_chunk: Respect buffer size
The last argument of av_strlcpy is supposed to contain the size of the
destination buffer, but it was filled with the size of the source
string, effectively negating its very purpose.
Signed-off-by: Andreas Rheinhardt
Signed-off-by: Michael Niedermayer
(cherry picked from commit 73ef1f47f5928264a968c8fbbcfb0bf0643f)
Signed-off-by: Michael Niedermayer
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=9fad760f56483f0b5503457c780d9f80a84784c6
---
libavformat/webm_chunk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/webm_chunk.c b/libavformat/webm_chunk.c
index f8dbaa3339..3f91162da7 100644
--- a/libavformat/webm_chunk.c
+++ b/libavformat/webm_chunk.c
@@ -96,7 +96,7 @@ static int get_chunk_filename(AVFormatContext *s, int
is_header, char *filename)
av_log(oc, AV_LOG_ERROR, "No header filename provided\n");
return AVERROR(EINVAL);
}
-av_strlcpy(filename, wc->header_filename, strlen(wc->header_filename)
+ 1);
+av_strlcpy(filename, wc->header_filename, MAX_FILENAME_SIZE);
} else {
if (av_get_frame_filename(filename, MAX_FILENAME_SIZE,
s->filename, wc->chunk_index - 1) < 0) {
___
ffmpeg-cvslog mailing list
ffmpeg-cvslog@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-cvslog
To unsubscribe, visit link above, or email
ffmpeg-cvslog-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-cvslog] lavf/webm_chunk: Respect buffer size
ffmpeg | branch: master | Andreas Rheinhardt |
Sat Apr 20 00:03:14 2019 +0200| [73ef1f47f5928264a968c8fbbcfb0bf0643f] |
committer: Michael Niedermayer
lavf/webm_chunk: Respect buffer size
The last argument of av_strlcpy is supposed to contain the size of the
destination buffer, but it was filled with the size of the source
string, effectively negating its very purpose.
Signed-off-by: Andreas Rheinhardt
Signed-off-by: Michael Niedermayer
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=73ef1f47f5928264a968c8fbbcfb0bf0643f
---
libavformat/webm_chunk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/webm_chunk.c b/libavformat/webm_chunk.c
index ec1ec4bf91..2c99753b5b 100644
--- a/libavformat/webm_chunk.c
+++ b/libavformat/webm_chunk.c
@@ -96,7 +96,7 @@ static int get_chunk_filename(AVFormatContext *s, int
is_header, char *filename)
av_log(oc, AV_LOG_ERROR, "No header filename provided\n");
return AVERROR(EINVAL);
}
-av_strlcpy(filename, wc->header_filename, strlen(wc->header_filename)
+ 1);
+av_strlcpy(filename, wc->header_filename, MAX_FILENAME_SIZE);
} else {
if (av_get_frame_filename(filename, MAX_FILENAME_SIZE,
s->url, wc->chunk_index - 1) < 0) {
___
ffmpeg-cvslog mailing list
ffmpeg-cvslog@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-cvslog
To unsubscribe, visit link above, or email
ffmpeg-cvslog-requ...@ffmpeg.org with subject "unsubscribe".
