Re: [FFmpeg-devel] [PATCH 1/3] avcodec/agm: add support for higher compression

2019-04-20 Thread Paul B Mahol
On 4/21/19, Michael Niedermayer  wrote:
> On Wed, Apr 10, 2019 at 01:45:51PM +0200, Paul B Mahol wrote:
>> Signed-off-by: Paul B Mahol 
>> ---
>>  libavcodec/agm.c   | 404 +++--
>>  libavformat/riff.c |   4 +
>>  2 files changed, 392 insertions(+), 16 deletions(-)
> [...]
>> @@ -509,6 +861,7 @@ static int decode_frame(AVCodecContext *avctx, void
>> *data,
>>  GetByteContext *gbyte = &s->gbyte;
>>  AVFrame *frame = data;
>>  int w, h, width, height, header;
>> +unsigned compressed_size;
>>  int ret;
>>
>>  if (!avpkt->size)
>> @@ -524,13 +877,19 @@ static int decode_frame(AVCodecContext *avctx, void
>> *data,
>>  if (avpkt->size < s->bitstream_size + 8)
>>  return AVERROR_INVALIDDATA;
>>
>> -s->key_frame = s->fflags & 0x1;
>> +s->key_frame = avpkt->flags & AV_PKT_FLAG_KEY;
>>  frame->key_frame = s->key_frame;
>>  frame->pict_type = s->key_frame ? AV_PICTURE_TYPE_I :
>> AV_PICTURE_TYPE_P;
>>
>>  if (header) {
>> -av_log(avctx, AV_LOG_ERROR, "header: %X\n", header);
>> -return AVERROR_PATCHWELCOME;
>> +if (avctx->codec_tag == MKTAG('A', 'G', 'M', '0') ||
>> +avctx->codec_tag == MKTAG('A', 'G', 'M', '1'))
>> +return AVERROR_PATCHWELCOME;
>> +else
>
>> +ret = decode_huffman2(avctx, header, (avpkt->size -
>> s->bitstream_size) - 8);
>
> where can i find samples for this ?
> i need to fix some bugs in this as it produces crashes but i have
> no samples to test to ensure a fix doesnt break anything

Just post patches, I will take care of rest.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v3] avcodec: add AV_CODEC_FLAG_DROPCHANGED to flags

2019-04-20 Thread Gyan



On 21-04-2019 12:14 AM, Marton Balint wrote:



On Sat, 20 Apr 2019, Gyan wrote:




On 19-04-2019 08:41 PM, Gyan wrote:



On 16-04-2019 01:12 PM, Gyan wrote:
Patch revised as per 
http://www.ffmpeg.org/pipermail/ffmpeg-devel/2019-April/242591.html


If no more changes, plan to push tomorrow morning.


Pushed as 3153a6502a28b20a0da822daf32bcd8f7c90d721


Please clarify that you return error and not simply drop in codecs.texi.


Added.

Regards,
Gyan
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/agm: add support for higher compression

2019-04-20 Thread Michael Niedermayer
On Wed, Apr 10, 2019 at 01:45:51PM +0200, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol 
> ---
>  libavcodec/agm.c   | 404 +++--
>  libavformat/riff.c |   4 +
>  2 files changed, 392 insertions(+), 16 deletions(-)
[...]
> @@ -509,6 +861,7 @@ static int decode_frame(AVCodecContext *avctx, void *data,
>  GetByteContext *gbyte = &s->gbyte;
>  AVFrame *frame = data;
>  int w, h, width, height, header;
> +unsigned compressed_size;
>  int ret;
>  
>  if (!avpkt->size)
> @@ -524,13 +877,19 @@ static int decode_frame(AVCodecContext *avctx, void 
> *data,
>  if (avpkt->size < s->bitstream_size + 8)
>  return AVERROR_INVALIDDATA;
>  
> -s->key_frame = s->fflags & 0x1;
> +s->key_frame = avpkt->flags & AV_PKT_FLAG_KEY;
>  frame->key_frame = s->key_frame;
>  frame->pict_type = s->key_frame ? AV_PICTURE_TYPE_I : AV_PICTURE_TYPE_P;
>  
>  if (header) {
> -av_log(avctx, AV_LOG_ERROR, "header: %X\n", header);
> -return AVERROR_PATCHWELCOME;
> +if (avctx->codec_tag == MKTAG('A', 'G', 'M', '0') ||
> +avctx->codec_tag == MKTAG('A', 'G', 'M', '1'))
> +return AVERROR_PATCHWELCOME;
> +else

> +ret = decode_huffman2(avctx, header, (avpkt->size - 
> s->bitstream_size) - 8);

where can i find samples for this ?
i need to fix some bugs in this as it produces crashes but i have
no samples to test to ensure a fix doesnt break anything

Thanks

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Whats the most studid thing your enemy could do ? Blow himself up
Whats the most studid thing you could do ? Give up your rights and
freedom because your enemy blew himself up.



signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v2 2/2] aarch64/mdct15: implement an fft15 NEON implementation

2019-04-20 Thread Lynne
NEON:
4823 UNITS in fft15,   65536 runs,  0 skips

C:
7889 UNITS in fft15,   65535 runs,  1 skips

Total speedup: around 3% on a Raspberry Pi 3.
>From 5e25b89454a674d93b4565df02fb9ba834795835 Mon Sep 17 00:00:00 2001
From: Lynne 
Date: Sat, 20 Apr 2019 02:05:23 +0100
Subject: [PATCH v2 2/2] aarch64/mdct15: implement an fft15 NEON implementation

NEON:
4823 UNITS in fft15,   65536 runs,  0 skips

C:
7889 UNITS in fft15,   65535 runs,  1 skips

Total speedup: around 3% on a Raspberry Pi 3.
---
 libavcodec/aarch64/Makefile  |   2 +
 libavcodec/aarch64/mdct15_init.c |  82 ++
 libavcodec/aarch64/mdct15_neon.S | 137 +++
 libavcodec/mdct15.c  |   3 +
 libavcodec/mdct15.h  |   1 +
 5 files changed, 225 insertions(+)
 create mode 100644 libavcodec/aarch64/mdct15_init.c
 create mode 100644 libavcodec/aarch64/mdct15_neon.S

diff --git a/libavcodec/aarch64/Makefile b/libavcodec/aarch64/Makefile
index 00f93bf59f..8093fc17cb 100644
--- a/libavcodec/aarch64/Makefile
+++ b/libavcodec/aarch64/Makefile
@@ -6,6 +6,7 @@ OBJS-$(CONFIG_H264DSP)  += aarch64/h264dsp_init_aarch64.o
 OBJS-$(CONFIG_H264PRED) += aarch64/h264pred_init.o
 OBJS-$(CONFIG_H264QPEL) += aarch64/h264qpel_init_aarch64.o
 OBJS-$(CONFIG_HPELDSP)  += aarch64/hpeldsp_init_aarch64.o
+OBJS-$(CONFIG_MDCT15)   += aarch64/mdct15_init.o
 OBJS-$(CONFIG_MPEGAUDIODSP) += aarch64/mpegaudiodsp_init.o
 OBJS-$(CONFIG_NEON_CLOBBER_TEST)+= aarch64/neontest.o
 OBJS-$(CONFIG_VIDEODSP) += aarch64/videodsp_init.o
@@ -43,6 +44,7 @@ NEON-OBJS-$(CONFIG_H264QPEL)+= aarch64/h264qpel_neon.o \
 NEON-OBJS-$(CONFIG_HPELDSP) += aarch64/hpeldsp_neon.o
 NEON-OBJS-$(CONFIG_IDCTDSP) += aarch64/idctdsp_init_aarch64.o  \
aarch64/simple_idct_neon.o
+NEON-OBJS-$(CONFIG_MDCT15)  += aarch64/mdct15_neon.o
 NEON-OBJS-$(CONFIG_MDCT)+= aarch64/mdct_neon.o
 NEON-OBJS-$(CONFIG_MPEGAUDIODSP)+= aarch64/mpegaudiodsp_neon.o
 NEON-OBJS-$(CONFIG_VP8DSP)  += aarch64/vp8dsp_neon.o
diff --git a/libavcodec/aarch64/mdct15_init.c b/libavcodec/aarch64/mdct15_init.c
new file mode 100644
index 00..9474c3e7d8
--- /dev/null
+++ b/libavcodec/aarch64/mdct15_init.c
@@ -0,0 +1,82 @@
+/*
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * FFmpeg is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with FFmpeg; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#include "config.h"
+
+#include "libavutil/aarch64/cpu.h"
+#include "libavcodec/mdct15.h"
+
+void ff_fft15_neon(FFTComplex *out, FFTComplex *in, FFTComplex *exptab, ptrdiff_t stride);
+
+static void perm_twiddles(MDCT15Context *s)
+{
+int k;
+FFTComplex *out = s->exptab;
+FFTComplex tmp[30];
+FFTComplex exptab_5pt[] = {
+{  s->exptab[19].re,  s->exptab[19].im },
+{ -s->exptab[20].re,  s->exptab[20].im },
+{  s->exptab[20].im,  s->exptab[20].im },
+{ -s->exptab[20].im, -s->exptab[20].im },
+};
+
+/* Reorder */
+for (k = 0; k < 5; k++) {
+tmp[6*k + 0] = s->exptab[k +  0];
+tmp[6*k + 2] = s->exptab[k +  5];
+tmp[6*k + 4] = s->exptab[k + 10];
+
+tmp[6*k + 1] = s->exptab[2 * (k + 0)];
+tmp[6*k + 3] = s->exptab[2 * (k + 5)];
+tmp[6*k + 5] = s->exptab[2 *  k + 5 ];
+}
+
+/* 5-point FFT twiddles */
+memcpy(out, exptab_5pt, 4*sizeof(FFTComplex));
+out += 4;
+
+/* 15-point FFT twiddles */
+for (k = 0; k < 3; k++) {
+FFTComplex exptab[] = {
+{  tmp[2*k + 0].re, tmp[2*k + 0].im },
+{  tmp[2*k + 1].re, tmp[2*k + 1].im },
+
+{  tmp[6*1 + 2*k + 0].re, tmp[6*1 + 2*k + 0].im },
+{  tmp[6*2 + 2*k + 0].re, tmp[6*2 + 2*k + 0].im },
+{  tmp[6*1 + 2*k + 1].re, tmp[6*1 + 2*k + 1].im },
+{  tmp[6*2 + 2*k + 1].re, tmp[6*2 + 2*k + 1].im },
+
+{  tmp[6*3 + 2*k + 0].re, tmp[6*3 + 2*k + 0].im },
+{  tmp[6*4 + 2*k + 0].re, tmp[6*4 + 2*k + 0].im },
+{  tmp[6*3 + 2*k + 1].re, tmp[6*3 + 2*k + 1].im },
+{  tmp[6*4 + 2*k + 1].re, tmp[6*4 + 2*k + 1].im },
+};
+memcpy(out, exptab, 10*sizeof(FFTComp

[FFmpeg-devel] [PATCH v2 1/2] aarch64/asm-offsets: remove old CELT offsets

2019-04-20 Thread Lynne
They're not used and they're incorrect.
v1 had a typo in the subject.
>From 08599b941535bd9da20da2ca1ab903ead8f4bbb7 Mon Sep 17 00:00:00 2001
From: Lynne 
Date: Sat, 20 Apr 2019 02:04:51 +0100
Subject: [PATCH v2 1/2] aarch64/asm-offsets: remove old CELT offsets

They're not used and they're incorrect.
---
 libavcodec/aarch64/asm-offsets.h | 8 
 1 file changed, 8 deletions(-)

diff --git a/libavcodec/aarch64/asm-offsets.h b/libavcodec/aarch64/asm-offsets.h
index e05c5ad2e4..fc38eed298 100644
--- a/libavcodec/aarch64/asm-offsets.h
+++ b/libavcodec/aarch64/asm-offsets.h
@@ -19,14 +19,6 @@
 #ifndef AVCODEC_AARCH64_ASM_OFFSETS_H
 #define AVCODEC_AARCH64_ASM_OFFSETS_H
 
-/* CeltIMDCTContext */
-#define CELT_EXPTAB 0x20
-#define CELT_FFT_N  0x00
-#define CELT_LEN2   0x04
-#define CELT_LEN4   (CELT_LEN2 + 0x4)   // loaded as pair
-#define CELT_TMP0x10
-#define CELT_TWIDDLE(CELT_TMP + 0x8)// loaded as pair
-
 /* FFTContext */
 #define IMDCT_HALF  0x48
 
-- 
2.20.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v3] avcodec: add AV_CODEC_FLAG_DROPCHANGED to flags

2019-04-20 Thread Marton Balint



On Sat, 20 Apr 2019, Gyan wrote:




On 19-04-2019 08:41 PM, Gyan wrote:



On 16-04-2019 01:12 PM, Gyan wrote:
Patch revised as per 
http://www.ffmpeg.org/pipermail/ffmpeg-devel/2019-April/242591.html


If no more changes, plan to push tomorrow morning.


Pushed as 3153a6502a28b20a0da822daf32bcd8f7c90d721


Please clarify that you return error and not simply drop in codecs.texi.

Thanks,
Marton
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Add a blank like at the end to avoid rollup reading from outside

2019-04-20 Thread Paul B Mahol
On 4/20/19, Michael Niedermayer  wrote:
> Fixes: index 20 out of bounds for type 'const char *[4][128]'
> Fixes:
> 14367/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CCAPTION_fuzzer-5718819672162304
>
> 14367/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CCAPTION_fuzzer-5718819672162304
> Signed-off-by: Michael Niedermayer 
> ---
>  libavcodec/ccaption_dec.c | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c
> index 09ceb1b3bf..bf3563a0bc 100644
> --- a/libavcodec/ccaption_dec.c
> +++ b/libavcodec/ccaption_dec.c
> @@ -212,10 +212,10 @@ static const unsigned char pac2_attribs[32][3] = //
> Color, font, ident
>
>  struct Screen {
>  /* +1 is used to compensate null character of string */
> -uint8_t characters[SCREEN_ROWS][SCREEN_COLUMNS+1];
> -uint8_t charsets[SCREEN_ROWS][SCREEN_COLUMNS+1];
> -uint8_t colors[SCREEN_ROWS][SCREEN_COLUMNS+1];
> -uint8_t fonts[SCREEN_ROWS][SCREEN_COLUMNS+1];
> +uint8_t characters[SCREEN_ROWS+1][SCREEN_COLUMNS+1];
> +uint8_t charsets[SCREEN_ROWS+1][SCREEN_COLUMNS+1];
> +uint8_t colors[SCREEN_ROWS+1][SCREEN_COLUMNS+1];
> +uint8_t fonts[SCREEN_ROWS+1][SCREEN_COLUMNS+1];
>  /*
>   * Bitmask of used rows; if a bit is not set, the
>   * corresponding row is not used.
> --
> 2.21.0
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Probably OK
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avcodec/ccaption_dec: Add a blank like at the end to avoid rollup reading from outside

2019-04-20 Thread Michael Niedermayer
Fixes: index 20 out of bounds for type 'const char *[4][128]'
Fixes: 
14367/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CCAPTION_fuzzer-5718819672162304

14367/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CCAPTION_fuzzer-5718819672162304
Signed-off-by: Michael Niedermayer 
---
 libavcodec/ccaption_dec.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c
index 09ceb1b3bf..bf3563a0bc 100644
--- a/libavcodec/ccaption_dec.c
+++ b/libavcodec/ccaption_dec.c
@@ -212,10 +212,10 @@ static const unsigned char pac2_attribs[32][3] = // 
Color, font, ident
 
 struct Screen {
 /* +1 is used to compensate null character of string */
-uint8_t characters[SCREEN_ROWS][SCREEN_COLUMNS+1];
-uint8_t charsets[SCREEN_ROWS][SCREEN_COLUMNS+1];
-uint8_t colors[SCREEN_ROWS][SCREEN_COLUMNS+1];
-uint8_t fonts[SCREEN_ROWS][SCREEN_COLUMNS+1];
+uint8_t characters[SCREEN_ROWS+1][SCREEN_COLUMNS+1];
+uint8_t charsets[SCREEN_ROWS+1][SCREEN_COLUMNS+1];
+uint8_t colors[SCREEN_ROWS+1][SCREEN_COLUMNS+1];
+uint8_t fonts[SCREEN_ROWS+1][SCREEN_COLUMNS+1];
 /*
  * Bitmask of used rows; if a bit is not set, the
  * corresponding row is not used.
-- 
2.21.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v3] lavfi: add colorkey_opencl filter

2019-04-20 Thread Mark Thompson
On 17/04/2019 03:08, Jarek Samic wrote:
> This is a direct port of the CPU filter.
> 
> Signed-off-by: Jarek Samic 
> ---
> More fixes based on the comments from the second version of the patch (moving 
> sampler declaration into the program scope, `f`-suffixing constants, 
> attaching the `*` sigil to the variable name rather than the data type).
> 
>  configure|   1 +
>  doc/filters.texi |  33 +
>  libavfilter/Makefile |   2 +
>  libavfilter/allfilters.c |   1 +
>  libavfilter/opencl/colorkey.cl   |  49 +++
>  libavfilter/opencl_source.h  |   1 +
>  libavfilter/vf_colorkey_opencl.c | 244 +++
>  7 files changed, 331 insertions(+)
>  create mode 100644 libavfilter/opencl/colorkey.cl
>  create mode 100644 libavfilter/vf_colorkey_opencl.c

LGTM, and applied.

Thanks!

- Mark
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH V2 2/2] lavfi/opencl: add nlmeans_opencl filter

2019-04-20 Thread Mark Thompson
On 17/04/2019 03:43, Song, Ruiling wrote:
>> -Original Message-
>> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of
>> Mark Thompson
>> Sent: Wednesday, April 17, 2019 5:28 AM
>> To: ffmpeg-devel@ffmpeg.org
>> Subject: Re: [FFmpeg-devel] [PATCH V2 2/2] lavfi/opencl: add nlmeans_opencl
>> filter
>>
>> On 12/04/2019 16:09, Ruiling Song wrote:
>>> Signed-off-by: Ruiling Song 
>>
>> I can't work out where the problem is, but there is something really weirdly
>> nondeterministic going on here.
>>
>> E.g.
>>
>> $ ./ffmpeg_g -y -init_hw_device opencl:0.0 -i 
>> ~/video/test/jellyfish-120-mbps-
>> 4k-uhd-hevc-10bit.mkv -an -filter_hw_device opencl0 -vf
>> format=yuv420p,hwupload,nlmeans_opencl,hwdownload,format=yuv420p -
>> frames:v 10 -f framemd5 -
>> ...
>> 0,  0,  0,1, 12441600, 
>> 8b8805818076b23ae6f80ec2b5a349d4
>> 0,  1,  1,1, 12441600, 
>> 7a7fdaa083dc337cfb6af31b643f30a3
>> 0,  2,  2,1, 12441600, 
>> b10ef2a1e5125cc67e262e086f8040b5
>> 0,  3,  3,1, 12441600, 
>> c06b53ad90e0357e537df41b63d5b1dc
>> 0,  4,  4,1, 12441600, 
>> 5aa2da07703859a3dee080847dd17d46
>> 0,  5,  5,1, 12441600, 
>> 733364c6be6af825057e905a6092937d
>> 0,  6,  6,1, 12441600, 
>> 47edae2dec956a582b04babb745d26b0
>> 0,  7,  7,1, 12441600, 
>> 4e45fe8268df4298d06a17ab8e46c3e9
>> 0,  8,  8,1, 12441600, 
>> 960d722a3f8787c9191299a114c04174
>> 0,  9,  9,1, 12441600, 
>> e759c07ee4834a9cf94bfcb4128e7612
>> $ ./ffmpeg_g -y -init_hw_device opencl:0.0 -i 
>> ~/video/test/jellyfish-120-mbps-
>> 4k-uhd-hevc-10bit.mkv -an -filter_hw_device opencl0 -vf
>> format=yuv420p,hwupload,nlmeans_opencl,hwdownload,format=yuv420p -
>> frames:v 10 -f framemd5 -
>> 0,  0,  0,1, 12441600, 
>> 8b8805818076b23ae6f80ec2b5a349d4
>> [Parsed_nlmeans_opencl_2 @ 0x5557ae580d00] integral image overflow
>> 2157538
>> 0,  1,  1,1, 12441600, 
>> bce72e10a9f1118940c5a8392ad78ec3
>> 0,  2,  2,1, 12441600, 
>> b10ef2a1e5125cc67e262e086f8040b5
>> 0,  3,  3,1, 12441600, 
>> c06b53ad90e0357e537df41b63d5b1dc
>> 0,  4,  4,1, 12441600, 
>> 5aa2da07703859a3dee080847dd17d46
>> 0,  5,  5,1, 12441600, 
>> 733364c6be6af825057e905a6092937d
>> 0,  6,  6,1, 12441600, 
>> 47edae2dec956a582b04babb745d26b0
>> 0,  7,  7,1, 12441600, 
>> 4e45fe8268df4298d06a17ab8e46c3e9
>> 0,  8,  8,1, 12441600, 
>> 960d722a3f8787c9191299a114c04174
>> 0,  9,  9,1, 12441600, 
>> e759c07ee4834a9cf94bfcb4128e7612
>> $ ./ffmpeg_g -y -init_hw_device opencl:0.0 -i 
>> ~/video/test/jellyfish-120-mbps-
>> 4k-uhd-hevc-10bit.mkv -an -filter_hw_device opencl0 -vf
>> format=yuv420p,hwupload,nlmeans_opencl,hwdownload,format=yuv420p -
>> frames:v 10 -f framemd5 -
>> 0,  0,  0,1, 12441600, 
>> 8b8805818076b23ae6f80ec2b5a349d4
>> 0,  1,  1,1, 12441600, 
>> 7a7fdaa083dc337cfb6af31b643f30a3
>> [Parsed_nlmeans_opencl_2 @ 0x557c51fbfe80] integral image overflow
>> 2098545
>> 0,  2,  2,1, 12441600, 
>> 68b390535adc5cfa0f8a7942c42a47ca
>> 0,  3,  3,1, 12441600, 
>> c06b53ad90e0357e537df41b63d5b1dc
>> 0,  4,  4,1, 12441600, 
>> 5aa2da07703859a3dee080847dd17d46
>> 0,  5,  5,1, 12441600, 
>> 733364c6be6af825057e905a6092937d
>> 0,  6,  6,1, 12441600, 
>> 47edae2dec956a582b04babb745d26b0
>> 0,  7,  7,1, 12441600, 
>> 4e45fe8268df4298d06a17ab8e46c3e9
>> 0,  8,  8,1, 12441600, 
>> 960d722a3f8787c9191299a114c04174
>> 0,  9,  9,1, 12441600, 
>> e759c07ee4834a9cf94bfcb4128e7612
>>
>> Frame 1 gave an overflow on the second run, and gets a different answer, then
>> frame 2 in the same way on the third run?  I can't characterise when this
>> happens, it seems to be pretty random with low probability.
> 
> I tried to reproduce on my SKL and KBL, with Beignet and Neo. And didn't 
> reproduce the issue.
> As I am encountering some network issue, I didn't get the video sample you 
> provide (I am using https://4ksamples.com/ses-astra-uhd-test-2-2160p-uhdtv/ 
> ), I can try later to download the same video as you.
> May be an OpenCL driver issue? I am not sure yet. So could you provide what 
> hardware and opencl driver version you are using? So I can do some debugging 
> if possible.

CFL-8700 with git Beignet.

It also sometimes happens with your sample (took >10 tries to get this):

$ ./ffmpeg_g -y -init_hw_device opencl:0.0 -i 
SES.Astra.UHD.Test.2.2160p.UHDTV.HEVC.x265-LiebeIst.mkv -an -filter_hw_device 
opencl

Re: [FFmpeg-devel] [PATCH] web/security: Add CVE-2019-11338, CVE-2019-11339

2019-04-20 Thread Michael Niedermayer
On Fri, Apr 19, 2019 at 01:24:54PM +0200, Michael Niedermayer wrote:
> ---
>  src/security | 12 
>  1 file changed, 12 insertions(+)

will apply

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is what and why we do it that matters, not just one of them.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_lut3d: add cineSpace 1D lut parsing

2019-04-20 Thread Clément Bœsch
On Fri, Apr 19, 2019 at 07:53:36PM +0200, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol 
> ---
>  doc/filters.texi   |  2 ++
>  libavfilter/vf_lut3d.c | 77 ++
>  2 files changed, 79 insertions(+)
> 

LGTM

-- 
Clément B.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_lut3d: add cineSpace 3D lut support

2019-04-20 Thread Clément Bœsch
On Fri, Apr 19, 2019 at 07:53:37PM +0200, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol 
> ---
>  doc/filters.texi   |  2 +
>  libavfilter/vf_lut3d.c | 91 ++
>  2 files changed, 93 insertions(+)
> 

LGTM

-- 
Clément B.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avformat/mpegenc - reject unsupported audio streams

2019-04-20 Thread Gyan


Old patch that was never applied. Rebased.

Gyan
From 80c0524adf53c95801afcf9b92b0baa519bf983e Mon Sep 17 00:00:00 2001
From: Gyan Doshi 
Date: Tue, 20 Feb 2018 20:42:21 +0530
Subject: [PATCH] avformat/mpegenc - reject unsupported audio streams

Only MP1, MP2, MP3, 16-bit PCM_DVD, PCM S16BE,
AC3 and DTS audio codecs are supported by the muxer.
---
 libavformat/mpegenc.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/libavformat/mpegenc.c b/libavformat/mpegenc.c
index 1389288b7f..ed54a4f79b 100644
--- a/libavformat/mpegenc.c
+++ b/libavformat/mpegenc.c
@@ -407,6 +407,11 @@ static av_cold int mpeg_mux_init(AVFormatContext *ctx)
 stream->lpcm_header[2] = 0x80;
 stream->id = lpcm_id++;
 stream->lpcm_align = st->codecpar->channels * 
st->codecpar->bits_per_coded_sample / 8;
+} else if (st->codecpar->codec_id != AV_CODEC_ID_MP1 &&
+   st->codecpar->codec_id != AV_CODEC_ID_MP2 &&
+   st->codecpar->codec_id != AV_CODEC_ID_MP3) {
+   av_log(ctx, AV_LOG_ERROR, "Unsupported audio codec. 
Must be one of mp1, mp2, mp3, 16-bit pcm_dvd, pcm_s16be, ac3 or dts.\n");
+   goto fail;
 } else {
 stream->id = mpa_id++;
 }
-- 
2.21.0___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".