Re: [FFmpeg-devel] Why does ffmpeg h264 decoder stop decoding when certain type of packets are coming in the input stream?
Below code change fixes Bug #7340 Not sure if that would impact something else. Request your kind opinion on this. diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index 7b4c5c7..4656d22 100644 --- a/libavcodec/h264dec.c +++ b/libavcodec/h264dec.c @@ -473,7 +473,7 @@ static void idr(H264Context *h) ff_h264_remove_all_refs(h); h->poc.prev_frame_num= h->poc.prev_frame_num_offset = 0; -h->poc.prev_poc_msb = 1<<16; +//h->poc.prev_poc_msb = 1<<16; h->poc.prev_poc_lsb = 0; for (i = 0; i < MAX_DELAYED_PIC_COUNT; i++) h->last_pocs[i] = INT_MIN; On Tue, Jul 31, 2018 at 7:18 PM Carl Eugen Hoyos wrote: > 2018-07-28 14:57 GMT+02:00, Naveed Basha : > > Yes, please find the test stream here. I was using ffmpeg v3.4.2. > > > > https://drive.google.com/open?id=1rHCfG4csA3rB4LSgErEBn1F3WfI5nUVr > > This is now ticket #7340, thank you for the sample. > > Carl Eugen > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > -- Cheers, Naveed ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Why does ffmpeg h264 decoder stop decoding when certain type of packets are coming in the input stream?
Thank you Carl. Is this a known issue? Is there any known good version which does not have have this issue? On Wed, Aug 1, 2018 at 4:48 AM Carl Eugen Hoyos wrote: > 2018-07-28 14:57 GMT+02:00, Naveed Basha : > > Yes, please find the test stream here. I was using ffmpeg v3.4.2. > > > > https://drive.google.com/open?id=1rHCfG4csA3rB4LSgErEBn1F3WfI5nUVr > > This is now ticket #7340, thank you for the sample. > > Carl Eugen > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > -- Cheers, Naveed ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Why does ffmpeg h264 decoder stop decoding when certain type of packets are coming in the input stream?
Hi, I was debugging the issue to find out that when there are certain IDR (PPS) AVPackets in the stream the h264 decoder stops decoding AVPackets after that. I am unclear as to if there is something wrong with ffmpeg h264 decoder and needs a fix or if it is a normal behavior and application programmer has to adopt some logic? Could someone please help me with this? On Sat, Jul 28, 2018 at 6:27 PM Naveed Basha wrote: > Yes, please find the test stream here. I was using ffmpeg v3.4.2. > > https://drive.google.com/open?id=1rHCfG4csA3rB4LSgErEBn1F3WfI5nUVr > > On Sat, Jul 28, 2018 at 6:36 AM Michael Niedermayer > wrote: > >> On Fri, Jul 27, 2018 at 05:27:44PM +0530, Naveed Basha wrote: >> > Hi All, >> > >> > I used av_read_frame to get the AVPacket from encoded h264 file. But >> when >> > this packet (00 00 01 05 94 5a 33 e7 4d 6b d7 ad 13 86 ff 47 83 93 31 >> f1 e3 >> > 0a) is in the input stream (h264 video) ffmpeg decoder stops decoding >> > frames for any subsequent AVPackets. But if I skip this packet to >> provide >> > to the decoder the next AVPackets decode just fine. >> > >> > Could you please help me to find what is wrong with this packet? Or >> what is >> > wrong with the ffmpeg decoder? >> > Thanks, >> > Naveed >> >> do you have some testcase for reproducing this ? >> >> thx >> >> [...] >> -- >> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB >> >> Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope >> ___ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> > > > -- > Cheers, > Naveed > -- Cheers, Naveed ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Why does ffmpeg h264 decoder stop decoding when certain type of packets are coming in the input stream?
Yes, please find the test stream here. I was using ffmpeg v3.4.2. https://drive.google.com/open?id=1rHCfG4csA3rB4LSgErEBn1F3WfI5nUVr On Sat, Jul 28, 2018 at 6:36 AM Michael Niedermayer wrote: > On Fri, Jul 27, 2018 at 05:27:44PM +0530, Naveed Basha wrote: > > Hi All, > > > > I used av_read_frame to get the AVPacket from encoded h264 file. But when > > this packet (00 00 01 05 94 5a 33 e7 4d 6b d7 ad 13 86 ff 47 83 93 31 f1 > e3 > > 0a) is in the input stream (h264 video) ffmpeg decoder stops decoding > > frames for any subsequent AVPackets. But if I skip this packet to provide > > to the decoder the next AVPackets decode just fine. > > > > Could you please help me to find what is wrong with this packet? Or what > is > > wrong with the ffmpeg decoder? > > Thanks, > > Naveed > > do you have some testcase for reproducing this ? > > thx > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > -- Cheers, Naveed ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] Why does ffmpeg h264 decoder stop decoding when certain type of packets are coming in the input stream?
Yes I have it. On Sat, 28 Jul 2018 at 6:36 AM, Michael Niedermayer wrote: > On Fri, Jul 27, 2018 at 05:27:44PM +0530, Naveed Basha wrote: > > Hi All, > > > > I used av_read_frame to get the AVPacket from encoded h264 file. But when > > this packet (00 00 01 05 94 5a 33 e7 4d 6b d7 ad 13 86 ff 47 83 93 31 f1 > e3 > > 0a) is in the input stream (h264 video) ffmpeg decoder stops decoding > > frames for any subsequent AVPackets. But if I skip this packet to provide > > to the decoder the next AVPackets decode just fine. > > > > Could you please help me to find what is wrong with this packet? Or what > is > > wrong with the ffmpeg decoder? > > Thanks, > > Naveed > > do you have some testcase for reproducing this ? > > thx > > [...] > -- > Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB > > Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > -- Cheers, Naveed ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] Why does ffmpeg h264 decoder stop decoding when certain type of packets are coming in the input stream?
Hi All, I used av_read_frame to get the AVPacket from encoded h264 file. But when this packet (00 00 01 05 94 5a 33 e7 4d 6b d7 ad 13 86 ff 47 83 93 31 f1 e3 0a) is in the input stream (h264 video) ffmpeg decoder stops decoding frames for any subsequent AVPackets. But if I skip this packet to provide to the decoder the next AVPackets decode just fine. Could you please help me to find what is wrong with this packet? Or what is wrong with the ffmpeg decoder? Thanks, Naveed ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel