Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf: Replace the ASF demuxer

2015-06-29 Thread Hendrik Leppkes
On Tue, Jun 30, 2015 at 1:29 AM, compn  wrote:
> On Sun, 28 Jun 2015 13:41:48 +0200 (CEST)
> g...@videolan.org (Alexandra Hájková) wrote:
>
>> ffmpeg | branch: master | Alexandra Hájková
>>  | Mon Jun 15 14:54:45 2015 +0200|
>> [b08569a23948db107e5e6175cd4c695427d5339d] | committer: Anton Khirnov
>>
>> lavf: Replace the ASF demuxer
>>
>> The old one is the result of the reverse engineering and guesswork.
>> The new one has been written following the now-available
>> specification.
>
> the new one is still based on the old one.
> this commit message is deceptive.
>
>> diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c
>> index 34e9036..8f46098 100644
>> --- a/libavformat/asfdec.c
>> +++ b/libavformat/asfdec.c
>> @@ -1,6 +1,6 @@
>>  /*
>> - * ASF compatible demuxer
>> - * Copyright (c) 2000, 2001 Fabrice Bellard
>> + * Microsoft Advanced Streaming Format demuxer
>> + * Copyright (c) 2014 Alexandra Hájková
>
> another developer who does not respect copyright.
>
>>  /* MSDN claims that this should be "compatible with the ID3 frame,
>> APIC",
>>   * but in reality this is only loosely similar */
>
> this function appears in both demuxers.
>

The demuxer has been re-written, the only things that got re-used are
some very basic utility functions.

- Hendrik
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf: Replace the ASF demuxer

2015-06-29 Thread compn
On Sun, 28 Jun 2015 13:41:48 +0200 (CEST)
g...@videolan.org (Alexandra Hájková) wrote:

> ffmpeg | branch: master | Alexandra Hájková
>  | Mon Jun 15 14:54:45 2015 +0200|
> [b08569a23948db107e5e6175cd4c695427d5339d] | committer: Anton Khirnov
> 
> lavf: Replace the ASF demuxer
> 
> The old one is the result of the reverse engineering and guesswork.
> The new one has been written following the now-available
> specification.

the new one is still based on the old one.
this commit message is deceptive.

> diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c
> index 34e9036..8f46098 100644
> --- a/libavformat/asfdec.c
> +++ b/libavformat/asfdec.c
> @@ -1,6 +1,6 @@
>  /*
> - * ASF compatible demuxer
> - * Copyright (c) 2000, 2001 Fabrice Bellard
> + * Microsoft Advanced Streaming Format demuxer
> + * Copyright (c) 2014 Alexandra Hájková

another developer who does not respect copyright.

>  /* MSDN claims that this should be "compatible with the ID3 frame,
> APIC",
>   * but in reality this is only loosely similar */

this function appears in both demuxers.

-compn
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel