Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: support AV_CODEC_CAP_ENCODER_RECON_FRAME

2022-08-02 Thread James Almer

On 8/2/2022 8:58 AM, Anton Khirnov wrote:

Quoting James Almer (2022-08-02 13:35:19)

Signed-off-by: James Almer 
---
  libavcodec/Makefile|  4 +-
  libavcodec/libaom.c| 49 +
  libavcodec/libaom.h| 33 ++
  libavcodec/libaomdec.c | 27 +---
  libavcodec/libaomenc.c | 97 ++
  5 files changed, 183 insertions(+), 27 deletions(-)
  create mode 100644 libavcodec/libaom.c
  create mode 100644 libavcodec/libaom.h


Not knowing anything about aomenc, this looks reasonable assuming it's
tested and works.

I have a WIP test tool in branch 'recon' in my tree in case you have
trouble testing this.


Tested with that tool and confirmed working, so applied.

Thanks.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".


Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: support AV_CODEC_CAP_ENCODER_RECON_FRAME

2022-08-02 Thread Anton Khirnov
Quoting James Almer (2022-08-02 13:35:19)
> Signed-off-by: James Almer 
> ---
>  libavcodec/Makefile|  4 +-
>  libavcodec/libaom.c| 49 +
>  libavcodec/libaom.h| 33 ++
>  libavcodec/libaomdec.c | 27 +---
>  libavcodec/libaomenc.c | 97 ++
>  5 files changed, 183 insertions(+), 27 deletions(-)
>  create mode 100644 libavcodec/libaom.c
>  create mode 100644 libavcodec/libaom.h

Not knowing anything about aomenc, this looks reasonable assuming it's
tested and works.

I have a WIP test tool in branch 'recon' in my tree in case you have
trouble testing this.

-- 
Anton Khirnov
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".


[FFmpeg-devel] [PATCH] avcodec/libaomenc: support AV_CODEC_CAP_ENCODER_RECON_FRAME

2022-08-02 Thread James Almer
Signed-off-by: James Almer 
---
 libavcodec/Makefile|  4 +-
 libavcodec/libaom.c| 49 +
 libavcodec/libaom.h| 33 ++
 libavcodec/libaomdec.c | 27 +---
 libavcodec/libaomenc.c | 97 ++
 5 files changed, 183 insertions(+), 27 deletions(-)
 create mode 100644 libavcodec/libaom.c
 create mode 100644 libavcodec/libaom.h

diff --git a/libavcodec/Makefile b/libavcodec/Makefile
index aff7752856..ca5a38bee1 100644
--- a/libavcodec/Makefile
+++ b/libavcodec/Makefile
@@ -1055,8 +1055,8 @@ OBJS-$(CONFIG_ALAC_AT_ENCODER)+= 
audiotoolboxenc.o
 OBJS-$(CONFIG_ILBC_AT_ENCODER)+= audiotoolboxenc.o
 OBJS-$(CONFIG_PCM_ALAW_AT_ENCODER)+= audiotoolboxenc.o
 OBJS-$(CONFIG_PCM_MULAW_AT_ENCODER)   += audiotoolboxenc.o
-OBJS-$(CONFIG_LIBAOM_AV1_DECODER) += libaomdec.o
-OBJS-$(CONFIG_LIBAOM_AV1_ENCODER) += libaomenc.o
+OBJS-$(CONFIG_LIBAOM_AV1_DECODER) += libaomdec.o libaom.o
+OBJS-$(CONFIG_LIBAOM_AV1_ENCODER) += libaomenc.o libaom.o
 OBJS-$(CONFIG_LIBARIBB24_DECODER) += libaribb24.o ass.o
 OBJS-$(CONFIG_LIBCELT_DECODER)+= libcelt_dec.o
 OBJS-$(CONFIG_LIBCODEC2_DECODER)  += libcodec2.o
diff --git a/libavcodec/libaom.c b/libavcodec/libaom.c
new file mode 100644
index 00..0befaaa530
--- /dev/null
+++ b/libavcodec/libaom.c
@@ -0,0 +1,49 @@
+/*
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * FFmpeg is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with FFmpeg; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+/**
+ * @file
+ * AOM common functions
+ */
+
+#include "libavutil/pixdesc.h"
+#include "libaom.h"
+
+void ff_aom_image_copy_16_to_8(AVFrame *pic, struct aom_image *img)
+{
+const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(pic->format);
+int i;
+
+for (i = 0; i < desc->nb_components; i++) {
+int w = img->d_w;
+int h = img->d_h;
+int x, y;
+
+if (i) {
+w = (w + img->x_chroma_shift) >> img->x_chroma_shift;
+h = (h + img->y_chroma_shift) >> img->y_chroma_shift;
+}
+
+for (y = 0; y < h; y++) {
+uint16_t *src = (uint16_t *)(img->planes[i] + y * img->stride[i]);
+uint8_t *dst = pic->data[i] + y * pic->linesize[i];
+for (x = 0; x < w; x++)
+*dst++ = *src++;
+}
+}
+}
diff --git a/libavcodec/libaom.h b/libavcodec/libaom.h
new file mode 100644
index 00..bb495af982
--- /dev/null
+++ b/libavcodec/libaom.h
@@ -0,0 +1,33 @@
+/*
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * FFmpeg is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with FFmpeg; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+/**
+ * @file
+ * AOM common functions
+ */
+
+#ifndef AVCODEC_LIBAOM_H
+#define AVCODEC_LIBAOM_H
+
+#include 
+
+#include "libavutil/frame.h"
+
+void ff_aom_image_copy_16_to_8(AVFrame *pic, struct aom_image *img);
+
+#endif /* AVCODEC_LIBAOM_H */
diff --git a/libavcodec/libaomdec.c b/libavcodec/libaomdec.c
index 3243610304..cb672b0e65 100644
--- a/libavcodec/libaomdec.c
+++ b/libavcodec/libaomdec.c
@@ -33,6 +33,7 @@
 #include "avcodec.h"
 #include "codec_internal.h"
 #include "internal.h"
+#include "libaom.h"
 #include "profiles.h"
 
 typedef struct AV1DecodeContext {
@@ -60,30 +61,6 @@ static av_cold int aom_init(AVCodecContext *avctx,
 return 0;
 }
 
-static void image_copy_16_to_8(AVFrame *pic, struct aom_image *img)
-{
-const AVPixFmtDescriptor *desc = av_pix_fmt_desc_get(pic->format);
-int i;
-
-for (i = 0; i < desc->nb_components; i++) {
-int w = img->d_w;
-int h = img->d_h;
-int x, y;
-
-if (i) {
-w = (w + img->x_chroma_shift) >>