Re: [FFmpeg-devel] [PATCH] avcodec/libsvtav1: pass pict_type to library

[James Almer]

On 4/25/2022 7:37 PM, Christopher Degawa wrote:

match the behavior of SvtAv1EncApp to ensure pic_type is always set
before passing it to the library.

The other options for pic_type aren't currently used inside the library,
so they aren't introduced in this patch.

Signed-off-by: Christopher Degawa 
---
  libavcodec/libsvtav1.c | 5 +
  1 file changed, 5 insertions(+)

diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
index 2e3d96ce37..eafb762a7d 100644
--- a/libavcodec/libsvtav1.c
+++ b/libavcodec/libsvtav1.c
@@ -404,6 +404,11 @@ static int eb_send_frame(AVCodecContext *avctx, const 
AVFrame *frame)
  headerPtr->p_app_private = NULL;
  headerPtr->pts   = frame->pts;
  
+switch (frame->pict_type) {

+case AV_PICTURE_TYPE_I: headerPtr->pic_type = EB_AV1_KEY_PICTURE; break;
+default: headerPtr->pic_type = EB_AV1_INVALID_PICTURE; break; // Actually 
means auto, or default.
+}


Please align these vertically if you're not using separate lines.


+
  svt_av1_enc_send_picture(svt_enc->svt_handle, headerPtr);
  
  return 0;

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avcodec/libsvtav1: pass pict_type to library

[Christopher Degawa]

match the behavior of SvtAv1EncApp to ensure pic_type is always set
before passing it to the library.

The other options for pic_type aren't currently used inside the library,
so they aren't introduced in this patch.

Signed-off-by: Christopher Degawa 
---
 libavcodec/libsvtav1.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
index 2e3d96ce37..eafb762a7d 100644
--- a/libavcodec/libsvtav1.c
+++ b/libavcodec/libsvtav1.c
@@ -404,6 +404,11 @@ static int eb_send_frame(AVCodecContext *avctx, const 
AVFrame *frame)
 headerPtr->p_app_private = NULL;
 headerPtr->pts   = frame->pts;
 
+switch (frame->pict_type) {
+case AV_PICTURE_TYPE_I: headerPtr->pic_type = EB_AV1_KEY_PICTURE; break;
+default: headerPtr->pic_type = EB_AV1_INVALID_PICTURE; break; // Actually 
means auto, or default.
+}
+
 svt_av1_enc_send_picture(svt_enc->svt_handle, headerPtr);
 
 return 0;
-- 
2.35.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".