Re: [FFmpeg-devel] [PATCH] avcodec/mv30: fix warning: suggest braces around initialization of subobject [-Wmissing-braces]
Michael Niedermayer (12020-05-30):
> if these warnings are not fixed, then ideally they should be suppressed
> by some other means like compiler flags
> so they do not distract from real issues
That would be best. IIRC, the discussion arose when we considered adding
the braces but it actually depended on the system-dependant definition
of the structure. This warning is just bogus, ={0} is always valid.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] avcodec/mv30: fix warning: suggest braces around initialization of subobject [-Wmissing-braces]
On Sat, May 30, 2020 at 01:34:03PM +0200, Nicolas George wrote:
> lance.lmw...@gmail.com (12020-05-30):
> > > -int pfill[3][1] = { 0 };
> > > +int pfill[3][1] = { {0} };
>
> > will apply it tomorow if no objection.
>
> This warning is bogus, the code is valid
agree
> and a common pattern in FFmpeg.
> IIRC, we decided to keep it that way when it happens.
i do remember adding {} to these kind of cases so as to
eliminate the related warnings when i see one in code iam
working on at least
the reason why i tend to do that is so there are fewer meaningless
warnings, that way warnings pointing to real issues are easier to spot
if these warnings are not fixed, then ideally they should be suppressed
by some other means like compiler flags
so they do not distract from real issues
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Never trust a computer, one day, it may think you are the virus. -- Compn
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] avcodec/mv30: fix warning: suggest braces around initialization of subobject [-Wmissing-braces]
On Sat, May 30, 2020 at 01:34:03PM +0200, Nicolas George wrote:
> lance.lmw...@gmail.com (12020-05-30):
> > > -int pfill[3][1] = { 0 };
> > > +int pfill[3][1] = { {0} };
>
> > will apply it tomorow if no objection.
>
> This warning is bogus, the code is valid and a common pattern in FFmpeg.
> IIRC, we decided to keep it that way when it happens.
Thanks for the explanation. It's difficult to know it's been discussed before.
>
> Regards,
>
> --
> Nicolas George
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
--
Thanks,
Limin Wang
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] avcodec/mv30: fix warning: suggest braces around initialization of subobject [-Wmissing-braces]
lance.lmw...@gmail.com (12020-05-30):
> > -int pfill[3][1] = { 0 };
> > +int pfill[3][1] = { {0} };
> will apply it tomorow if no objection.
This warning is bogus, the code is valid and a common pattern in FFmpeg.
IIRC, we decided to keep it that way when it happens.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] avcodec/mv30: fix warning: suggest braces around initialization of subobject [-Wmissing-braces]
On Tue, May 12, 2020 at 11:09:19PM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> libavcodec/mv30.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/mv30.c b/libavcodec/mv30.c
> index fed9bcd..7e67133 100644
> --- a/libavcodec/mv30.c
> +++ b/libavcodec/mv30.c
> @@ -421,7 +421,7 @@ static int decode_intra(AVCodecContext *avctx,
> GetBitContext *gb, AVFrame *frame
>
> for (int y = 0; y < avctx->height; y += 16) {
> GetByteContext gbyte;
> -int pfill[3][1] = { 0 };
> +int pfill[3][1] = { {0} };
> int nb_codes = get_bits(gb, 16);
>
> av_fast_padded_malloc(>coeffs, >coeffs_size, nb_codes *
> sizeof(*s->coeffs));
> @@ -504,7 +504,7 @@ static int decode_inter(AVCodecContext *avctx,
> GetBitContext *gb,
>
> for (int y = 0; y < avctx->height; y += 16) {
> GetByteContext gbyte;
> -int pfill[3][1] = { 0 };
> +int pfill[3][1] = { {0} };
> int nb_codes = get_bits(gb, 16);
>
> skip_bits(gb, 8);
> --
> 1.8.3.1
>
will apply it tomorow if no objection.
--
Thanks,
Limin Wang
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] avcodec/mv30: fix warning: suggest braces around initialization of subobject [-Wmissing-braces]
On Tue, May 12, 2020 at 11:09:19PM +0800, lance.lmw...@gmail.com wrote:
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> libavcodec/mv30.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/mv30.c b/libavcodec/mv30.c
> index fed9bcd..7e67133 100644
> --- a/libavcodec/mv30.c
> +++ b/libavcodec/mv30.c
> @@ -421,7 +421,7 @@ static int decode_intra(AVCodecContext *avctx,
> GetBitContext *gb, AVFrame *frame
>
> for (int y = 0; y < avctx->height; y += 16) {
> GetByteContext gbyte;
> -int pfill[3][1] = { 0 };
> +int pfill[3][1] = { {0} };
> int nb_codes = get_bits(gb, 16);
>
> av_fast_padded_malloc(>coeffs, >coeffs_size, nb_codes *
> sizeof(*s->coeffs));
> @@ -504,7 +504,7 @@ static int decode_inter(AVCodecContext *avctx,
> GetBitContext *gb,
>
> for (int y = 0; y < avctx->height; y += 16) {
> GetByteContext gbyte;
> -int pfill[3][1] = { 0 };
> +int pfill[3][1] = { {0} };
> int nb_codes = get_bits(gb, 16);
>
> skip_bits(gb, 8);
> --
> 1.8.3.1
>
will apply.
--
Thanks,
Limin Wang
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH] avcodec/mv30: fix warning: suggest braces around initialization of subobject [-Wmissing-braces]
From: Limin Wang
Signed-off-by: Limin Wang
---
libavcodec/mv30.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/mv30.c b/libavcodec/mv30.c
index fed9bcd..7e67133 100644
--- a/libavcodec/mv30.c
+++ b/libavcodec/mv30.c
@@ -421,7 +421,7 @@ static int decode_intra(AVCodecContext *avctx,
GetBitContext *gb, AVFrame *frame
for (int y = 0; y < avctx->height; y += 16) {
GetByteContext gbyte;
-int pfill[3][1] = { 0 };
+int pfill[3][1] = { {0} };
int nb_codes = get_bits(gb, 16);
av_fast_padded_malloc(>coeffs, >coeffs_size, nb_codes *
sizeof(*s->coeffs));
@@ -504,7 +504,7 @@ static int decode_inter(AVCodecContext *avctx,
GetBitContext *gb,
for (int y = 0; y < avctx->height; y += 16) {
GetByteContext gbyte;
-int pfill[3][1] = { 0 };
+int pfill[3][1] = { {0} };
int nb_codes = get_bits(gb, 16);
skip_bits(gb, 8);
--
1.8.3.1
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
