Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: make some function static

[James Almer]

On 11/9/2017 2:07 AM, Aaron Levinson wrote:
> On 11/8/2017 7:20 PM, James Almer wrote:
>> Should fix ticket #6822
>>
>> Signed-off-by: James Almer 
>> ---
>>   libavdevice/decklink_dec.cpp | 8 
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp
>> index 191547ff10..e90b42811a 100644
>> --- a/libavdevice/decklink_dec.cpp
>> +++ b/libavdevice/decklink_dec.cpp
>> @@ -262,8 +262,8 @@ static uint8_t*
>> teletext_data_unit_from_ancillary_packet(uint16_t *py, uint16_t
>>   return tgt;
>>   }
>>   -uint8_t *vanc_to_cc(AVFormatContext *avctx, uint16_t *buf, size_t
>> words,
>> -    unsigned _count)
>> +static uint8_t *vanc_to_cc(AVFormatContext *avctx, uint16_t *buf,
>> size_t words,
>> +   unsigned _count)
>>   {
>>   size_t i, len = (buf[5] & 0xff) + 6 + 1;
>>   uint8_t cdp_sum, rate;
>> @@ -352,8 +352,8 @@ uint8_t *vanc_to_cc(AVFormatContext *avctx,
>> uint16_t *buf, size_t words,
>>   return cc;
>>   }
>>   -uint8_t *get_metadata(AVFormatContext *avctx, uint16_t *buf, size_t
>> width,
>> -  uint8_t *tgt, size_t tgt_size, AVPacket *pkt)
>> +static uint8_t *get_metadata(AVFormatContext *avctx, uint16_t *buf,
>> size_t width,
>> + uint8_t *tgt, size_t tgt_size, AVPacket
>> *pkt)
>>   {
>>   decklink_cctx *cctx = (struct decklink_cctx *) avctx->priv_data;
>>   uint16_t *max_buf = buf + width;
>>
> 
> LGTM

Pushed, thanks.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: make some function static

[Aaron Levinson]

On 11/8/2017 7:20 PM, James Almer wrote:

Should fix ticket #6822

Signed-off-by: James Almer 
---
  libavdevice/decklink_dec.cpp | 8 
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp
index 191547ff10..e90b42811a 100644
--- a/libavdevice/decklink_dec.cpp
+++ b/libavdevice/decklink_dec.cpp
@@ -262,8 +262,8 @@ static uint8_t* 
teletext_data_unit_from_ancillary_packet(uint16_t *py, uint16_t
  return tgt;
  }
  
-uint8_t *vanc_to_cc(AVFormatContext *avctx, uint16_t *buf, size_t words,

-unsigned _count)
+static uint8_t *vanc_to_cc(AVFormatContext *avctx, uint16_t *buf, size_t words,
+   unsigned _count)
  {
  size_t i, len = (buf[5] & 0xff) + 6 + 1;
  uint8_t cdp_sum, rate;
@@ -352,8 +352,8 @@ uint8_t *vanc_to_cc(AVFormatContext *avctx, uint16_t *buf, 
size_t words,
  return cc;
  }
  
-uint8_t *get_metadata(AVFormatContext *avctx, uint16_t *buf, size_t width,

-  uint8_t *tgt, size_t tgt_size, AVPacket *pkt)
+static uint8_t *get_metadata(AVFormatContext *avctx, uint16_t *buf, size_t 
width,
+ uint8_t *tgt, size_t tgt_size, AVPacket *pkt)
  {
  decklink_cctx *cctx = (struct decklink_cctx *) avctx->priv_data;
  uint16_t *max_buf = buf + width;



LGTM
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avdevice/decklink_dec: make some function static

[James Almer]

Should fix ticket #6822

Signed-off-by: James Almer 
---
 libavdevice/decklink_dec.cpp | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp
index 191547ff10..e90b42811a 100644
--- a/libavdevice/decklink_dec.cpp
+++ b/libavdevice/decklink_dec.cpp
@@ -262,8 +262,8 @@ static uint8_t* 
teletext_data_unit_from_ancillary_packet(uint16_t *py, uint16_t
 return tgt;
 }
 
-uint8_t *vanc_to_cc(AVFormatContext *avctx, uint16_t *buf, size_t words,
-unsigned _count)
+static uint8_t *vanc_to_cc(AVFormatContext *avctx, uint16_t *buf, size_t words,
+   unsigned _count)
 {
 size_t i, len = (buf[5] & 0xff) + 6 + 1;
 uint8_t cdp_sum, rate;
@@ -352,8 +352,8 @@ uint8_t *vanc_to_cc(AVFormatContext *avctx, uint16_t *buf, 
size_t words,
 return cc;
 }
 
-uint8_t *get_metadata(AVFormatContext *avctx, uint16_t *buf, size_t width,
-  uint8_t *tgt, size_t tgt_size, AVPacket *pkt)
+static uint8_t *get_metadata(AVFormatContext *avctx, uint16_t *buf, size_t 
width,
+ uint8_t *tgt, size_t tgt_size, AVPacket *pkt)
 {
 decklink_cctx *cctx = (struct decklink_cctx *) avctx->priv_data;
 uint16_t *max_buf = buf + width;
-- 
2.14.2

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel