[FFmpeg-devel] [PATCH] avfilter/avf_showwaves: fix off by one error in loop condition
It caused segfaults. Signed-off-by: Marton Balint c...@passwd.hu --- libavfilter/avf_showwaves.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/avf_showwaves.c b/libavfilter/avf_showwaves.c index 4cd225a..fa34a52 100644 --- a/libavfilter/avf_showwaves.c +++ b/libavfilter/avf_showwaves.c @@ -157,7 +157,7 @@ inline static int push_frame(AVFilterLink *outlink) showwaves-req_fullfilled = 1; showwaves-outpicref = NULL; showwaves-buf_idx = 0; -for (i = 0; i = nb_channels; i++) +for (i = 0; i nb_channels; i++) showwaves-buf_idy[i] = 0; return ret; } -- 2.1.2 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avfilter/avf_showwaves: fix off by one error in loop condition
On 11/9/14, Marton Balint c...@passwd.hu wrote: It caused segfaults. Signed-off-by: Marton Balint c...@passwd.hu --- libavfilter/avf_showwaves.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/avf_showwaves.c b/libavfilter/avf_showwaves.c index 4cd225a..fa34a52 100644 --- a/libavfilter/avf_showwaves.c +++ b/libavfilter/avf_showwaves.c @@ -157,7 +157,7 @@ inline static int push_frame(AVFilterLink *outlink) showwaves-req_fullfilled = 1; showwaves-outpicref = NULL; showwaves-buf_idx = 0; -for (i = 0; i = nb_channels; i++) +for (i = 0; i nb_channels; i++) showwaves-buf_idy[i] = 0; return ret; } -- 2.1.2 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel ok ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avfilter/avf_showwaves: fix off by one error in loop condition
On Sun, Nov 09, 2014 at 01:37:03PM +, Paul B Mahol wrote: On 11/9/14, Marton Balint c...@passwd.hu wrote: It caused segfaults. Signed-off-by: Marton Balint c...@passwd.hu --- libavfilter/avf_showwaves.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/avf_showwaves.c b/libavfilter/avf_showwaves.c index 4cd225a..fa34a52 100644 --- a/libavfilter/avf_showwaves.c +++ b/libavfilter/avf_showwaves.c @@ -157,7 +157,7 @@ inline static int push_frame(AVFilterLink *outlink) showwaves-req_fullfilled = 1; showwaves-outpicref = NULL; showwaves-buf_idx = 0; -for (i = 0; i = nb_channels; i++) +for (i = 0; i nb_channels; i++) showwaves-buf_idy[i] = 0; return ret; } -- 2.1.2 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel ok applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is dangerous to be right in matters on which the established authorities are wrong. -- Voltaire signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
