Re: [FFmpeg-devel] [PATCH] avfilter/vf_framerate: fix cpy_line_width calculation on >8 bits format

2018-01-26 Thread Marton Balint 



On Sat, 27 Jan 2018, Michael Niedermayer wrote:


On Sat, Jan 20, 2018 at 03:04:58PM +0700, Muhammad Faiz wrote:

Fix tsan warnings on fate-filter-framerate-12bit-down and
fate-filter-framerate-12bit-up.

Signed-off-by: Muhammad Faiz 
---
 libavfilter/vf_framerate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


should be ok if you checked the output



My pending framerate patches will fix this anyway.

Regards,
Marton
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_framerate: fix cpy_line_width calculation on >8 bits format

2018-01-26 Thread Michael Niedermayer 
On Sat, Jan 20, 2018 at 03:04:58PM +0700, Muhammad Faiz wrote:
> Fix tsan warnings on fate-filter-framerate-12bit-down and
> fate-filter-framerate-12bit-up.
> 
> Signed-off-by: Muhammad Faiz 
> ---
>  libavfilter/vf_framerate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

should be ok if you checked the output

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/vf_framerate: fix cpy_line_width calculation on >8 bits format

2018-01-25 Thread Muhammad Faiz 
On Sat, Jan 20, 2018 at 3:04 PM, Muhammad Faiz  wrote:
> Fix tsan warnings on fate-filter-framerate-12bit-down and
> fate-filter-framerate-12bit-up.
>
> Signed-off-by: Muhammad Faiz 
> ---
>  libavfilter/vf_framerate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavfilter/vf_framerate.c b/libavfilter/vf_framerate.c
> index a5ae6ddb71..578acaae52 100644
> --- a/libavfilter/vf_framerate.c
> +++ b/libavfilter/vf_framerate.c
> @@ -240,7 +240,7 @@ static int filter_slice16(AVFilterContext *ctx, void 
> *arg, int job, int nb_jobs)
>  int plane, line, pixel;
>
>  for (plane = 0; plane < 4 && td->copy_src1->data[plane] && 
> td->copy_src2->data[plane]; plane++) {
> -int cpy_line_width = s->line_size[plane];
> +int cpy_line_width = s->line_size[plane] / 2;
>  const uint16_t *cpy_src1_data = (const uint16_t 
> *)td->copy_src1->data[plane];
>  int cpy_src1_line_size = td->copy_src1->linesize[plane] / 2;
>  const uint16_t *cpy_src2_data = (const uint16_t 
> *)td->copy_src2->data[plane];
> --
> 2.13.2
>

Ping.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avfilter/vf_framerate: fix cpy_line_width calculation on >8 bits format

2018-01-20 Thread Muhammad Faiz 
Fix tsan warnings on fate-filter-framerate-12bit-down and
fate-filter-framerate-12bit-up.

Signed-off-by: Muhammad Faiz 
---
 libavfilter/vf_framerate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavfilter/vf_framerate.c b/libavfilter/vf_framerate.c
index a5ae6ddb71..578acaae52 100644
--- a/libavfilter/vf_framerate.c
+++ b/libavfilter/vf_framerate.c
@@ -240,7 +240,7 @@ static int filter_slice16(AVFilterContext *ctx, void *arg, 
int job, int nb_jobs)
 int plane, line, pixel;
 
 for (plane = 0; plane < 4 && td->copy_src1->data[plane] && 
td->copy_src2->data[plane]; plane++) {
-int cpy_line_width = s->line_size[plane];
+int cpy_line_width = s->line_size[plane] / 2;
 const uint16_t *cpy_src1_data = (const uint16_t 
*)td->copy_src1->data[plane];
 int cpy_src1_line_size = td->copy_src1->linesize[plane] / 2;
 const uint16_t *cpy_src2_data = (const uint16_t 
*)td->copy_src2->data[plane];
-- 
2.13.2

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel