Re: [FFmpeg-devel] [PATCH] avfilter: remove unused private field of AVFilterLink

2019-10-28 Thread Zhao Zhili 


> On Oct 28, 2019, at 9:15 PM, Moritz Barsnick  wrote:
> 
> On Mon, Oct 28, 2019 at 14:09:53 +0100, Moritz Barsnick wrote:
>>> -unsigned flags;
>> 
>> Since this is a public header, this is part of the API and cannot be
>> removed without a deprecation period.
> 
> Sorry, I missed that it says "Applications must not normally access the
> link structure directly."

Actually, I take the following comments as reference, it dating back to 2012

/*
 * All fields below this line are not part of the public API. They
 * may not be used outside of libavfilter and can be changed and
 * removed at will.
 * New public fields should be added right above.
 *
 */

> 
> Forget my comment, and sorry for the noise.
> 
> Moritz
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".



___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter: remove unused private field of AVFilterLink

2019-10-28 Thread Moritz Barsnick 
On Mon, Oct 28, 2019 at 14:09:53 +0100, Moritz Barsnick wrote:
> > -unsigned flags;
>
> Since this is a public header, this is part of the API and cannot be
> removed without a deprecation period.

Sorry, I missed that it says "Applications must not normally access the
link structure directly."

Forget my comment, and sorry for the noise.

Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter: remove unused private field of AVFilterLink

2019-10-28 Thread Moritz Barsnick 
On Fri, Oct 18, 2019 at 14:36:31 +0800, quinkbl...@foxmail.com wrote:
> diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h
> index 3eaa8a4089..3c87f4864a 100644
> --- a/libavfilter/avfilter.h
> +++ b/libavfilter/avfilter.h
> @@ -572,11 +572,6 @@ struct AVFilterLink {
>   */
>  int channels;
>
> -/**
> - * Link processing flags.
> - */
> -unsigned flags;
> -

Since this is a public header, this is part of the API and cannot be
removed without a deprecation period.

Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avfilter: remove unused private field of AVFilterLink

2019-10-18 Thread quinkblack 
From: Zhao Zhili 

---
 libavfilter/avfilter.h | 5 -
 1 file changed, 5 deletions(-)

diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h
index 3eaa8a4089..3c87f4864a 100644
--- a/libavfilter/avfilter.h
+++ b/libavfilter/avfilter.h
@@ -572,11 +572,6 @@ struct AVFilterLink {
  */
 int channels;
 
-/**
- * Link processing flags.
- */
-unsigned flags;
-
 /**
  * Number of past frames sent through the link.
  */
-- 
2.22.0



___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".