Re: [FFmpeg-devel] [PATCH] avformat/aiffdec: give message if compressed codec tag is unsupported

2015-10-25 Thread Carl Eugen Hoyos 
Paul B Mahol  gmail.com> writes:

> +if (codec->codec_id == AV_CODEC_ID_NONE)
> +avpriv_request_sample(s, "unknown or 
> unsupported codec tag: 0x%X", codec->codec_tag);

You could use av_get_codec_tag_string() to make 
this more readable.
Looks good either way, Carl Eugen

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avformat/aiffdec: give message if compressed codec tag is unsupported

2015-10-25 Thread Paul B Mahol 
Signed-off-by: Paul B Mahol 
---
 libavformat/aiffdec.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavformat/aiffdec.c b/libavformat/aiffdec.c
index f26951d..7de103b 100644
--- a/libavformat/aiffdec.c
+++ b/libavformat/aiffdec.c
@@ -128,6 +128,8 @@ static int get_aiff_header(AVFormatContext *s, int size,
 } else if (version == AIFF_C_VERSION1) {
 codec->codec_tag = avio_rl32(pb);
 codec->codec_id  = ff_codec_get_id(ff_codec_aiff_tags, 
codec->codec_tag);
+if (codec->codec_id == AV_CODEC_ID_NONE)
+avpriv_request_sample(s, "unknown or unsupported codec tag: 0x%X", 
codec->codec_tag);
 size -= 4;
 }
 
-- 
1.9.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel