Re: [FFmpeg-devel] [PATCH] avformat/vivo: Don't log null value

[Michael Niedermayer]

On Sun, Nov 25, 2018 at 09:52:04AM +0100, Paul B Mahol wrote:
> On 11/25/18, Mark Harris  wrote:
> > ---
> >  libavformat/vivo.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/vivo.c b/libavformat/vivo.c
> > index c9e9c37f37..9b9189f307 100644
> > --- a/libavformat/vivo.c
> > +++ b/libavformat/vivo.c
> > @@ -166,7 +166,7 @@ static int vivo_read_header(AVFormatContext *s)
> >  value = strchr(key, ':');
> >  if (!value) {
> >  av_log(s, AV_LOG_WARNING, "missing colon in key:value pair
> > '%s'\n",
> > -   value);
> > +   key);
> >  continue;
> >  }
> >
> > --
> > 2.19.2
> >
> > ___
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> 
> lgtm

will apply

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

"You are 36 times more likely to die in a bathtub than at the hands of a
terrorist. Also, you are 2.5 times more likely to become a president and
2 times more likely to become an astronaut, than to die in a terrorist
attack." -- Thoughty2



signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/vivo: Don't log null value

[Paul B Mahol]

On 11/25/18, Mark Harris  wrote:
> ---
>  libavformat/vivo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/vivo.c b/libavformat/vivo.c
> index c9e9c37f37..9b9189f307 100644
> --- a/libavformat/vivo.c
> +++ b/libavformat/vivo.c
> @@ -166,7 +166,7 @@ static int vivo_read_header(AVFormatContext *s)
>  value = strchr(key, ':');
>  if (!value) {
>  av_log(s, AV_LOG_WARNING, "missing colon in key:value pair
> '%s'\n",
> -   value);
> +   key);
>  continue;
>  }
>
> --
> 2.19.2
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>

lgtm
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avformat/vivo: Don't log null value

[Mark Harris]

---
 libavformat/vivo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/vivo.c b/libavformat/vivo.c
index c9e9c37f37..9b9189f307 100644
--- a/libavformat/vivo.c
+++ b/libavformat/vivo.c
@@ -166,7 +166,7 @@ static int vivo_read_header(AVFormatContext *s)
 value = strchr(key, ':');
 if (!value) {
 av_log(s, AV_LOG_WARNING, "missing colon in key:value pair 
'%s'\n",
-   value);
+   key);
 continue;
 }
 
-- 
2.19.2

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel