Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

[Michael Niedermayer]

On Wed, Oct 28, 2015 at 11:04:24PM -0400, Ganesh Ajjanagadde wrote:
> On Thu, Oct 15, 2015 at 10:24 PM, Ganesh Ajjanagadde  wrote:
> > On Thu, Oct 15, 2015 at 10:22 PM, Ganesh Ajjanagadde  
> > wrote:
> >> On Thu, Oct 15, 2015 at 10:16 PM, James Almer  wrote:
> >>> On 10/15/2015 10:23 PM, Ganesh Ajjanagadde wrote:
>  On Thu, Oct 15, 2015 at 8:06 PM, James Almer  wrote:
> > On 10/15/2015 8:52 PM, Ganesh Ajjanagadde wrote:
> >> This triggers a few warnings that will need to be fixed - not that bad,
> >> the current code is mostly fine.
> >>
> >
> > I think i asked you before, but in any case i'll do it again. Please,
> > send patchsets contained in a single thread. You're making things
> > hard to track and organize on people's inboxes.
> > See https://kernel.org/pub/software/scm/git/docs/git-send-email.html
> > --thread, --chain-reply-to and --in-reply-to options.
> 
>  Would greatly appreciate a command/command sequence: I am on master
>  (which is ahead of origin/master) and contains only the avutil warning
>  stuff (many commits). How do I get a proper chain of emails that you
>  would like?
> 
> >
> > Thanks.
> >>>
> >>> When you send several mails with a single git send-email command, it
> >>> should by default send every email after the first as a reply to the
> >>> first, effectively making a single "thread".
> >>
> >> Sorry, but gmail smtp/send-email does not let me do this - I have
> >> tried multiple patches in a single git send-email, and it closes the
> >> connection.
> >
> > The engineers at Google must have fixed something - I tried it just
> > now in the manner you described for the avdevice patches.
> 
> ping

what patch is this ping about ?
i assume its not for the paragraph directly above

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

[Ganesh Ajjanagadde]

On Thu, Oct 15, 2015 at 7:52 PM, Ganesh Ajjanagadde
 wrote:
> This triggers a few warnings that will need to be fixed - not that bad,
> the current code is mostly fine.
>
> Signed-off-by: Ganesh Ajjanagadde 
> ---
>  libavutil/parseutils.h | 5 +
>  1 file changed, 5 insertions(+)
>
> diff --git a/libavutil/parseutils.h b/libavutil/parseutils.h
> index e66d24b..46de518 100644
> --- a/libavutil/parseutils.h
> +++ b/libavutil/parseutils.h
> @@ -46,6 +46,7 @@
>   * @param[in] log_ctx parent logging context
>   * @return >= 0 on success, a negative error code otherwise
>   */
> +av_warn_unused_result
>  int av_parse_ratio(AVRational *q, const char *str, int max,
> int log_offset, void *log_ctx);
>
> @@ -63,6 +64,7 @@ int av_parse_ratio(AVRational *q, const char *str, int max,
>   * width x height or a valid video size abbreviation.
>   * @return >= 0 on success, a negative error code otherwise
>   */
> +av_warn_unused_result
>  int av_parse_video_size(int *width_ptr, int *height_ptr, const char *str);
>
>  /**
> @@ -74,6 +76,7 @@ int av_parse_video_size(int *width_ptr, int *height_ptr, 
> const char *str);
>   * rate_num / rate_den, a float number or a valid video rate abbreviation
>   * @return >= 0 on success, a negative error code otherwise
>   */
> +av_warn_unused_result
>  int av_parse_video_rate(AVRational *rate, const char *str);
>
>  /**
> @@ -95,6 +98,7 @@ int av_parse_video_rate(AVRational *rate, const char *str);
>   * @return >= 0 in case of success, a negative value in case of
>   * failure (for example if color_string cannot be parsed).
>   */
> +av_warn_unused_result
>  int av_parse_color(uint8_t *rgba_color, const char *color_string, int slen,
> void *log_ctx);
>
> @@ -143,6 +147,7 @@ const char *av_get_known_color_name(int color_idx, const 
> uint8_t **rgb);
>   * @return >= 0 in case of success, a negative value corresponding to an
>   * AVERROR code otherwise
>   */
> +av_warn_unused_result
>  int av_parse_time(int64_t *timeval, const char *timestr, int duration);
>
>  /**
> --
> 2.6.1
>

Pinged the wrong mail, here is the patch. Sorry.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

[Ganesh Ajjanagadde]

On Thu, Oct 15, 2015 at 10:24 PM, Ganesh Ajjanagadde  wrote:
> On Thu, Oct 15, 2015 at 10:22 PM, Ganesh Ajjanagadde  wrote:
>> On Thu, Oct 15, 2015 at 10:16 PM, James Almer  wrote:
>>> On 10/15/2015 10:23 PM, Ganesh Ajjanagadde wrote:
 On Thu, Oct 15, 2015 at 8:06 PM, James Almer  wrote:
> On 10/15/2015 8:52 PM, Ganesh Ajjanagadde wrote:
>> This triggers a few warnings that will need to be fixed - not that bad,
>> the current code is mostly fine.
>>
>
> I think i asked you before, but in any case i'll do it again. Please,
> send patchsets contained in a single thread. You're making things
> hard to track and organize on people's inboxes.
> See https://kernel.org/pub/software/scm/git/docs/git-send-email.html
> --thread, --chain-reply-to and --in-reply-to options.

 Would greatly appreciate a command/command sequence: I am on master
 (which is ahead of origin/master) and contains only the avutil warning
 stuff (many commits). How do I get a proper chain of emails that you
 would like?

>
> Thanks.
>>>
>>> When you send several mails with a single git send-email command, it
>>> should by default send every email after the first as a reply to the
>>> first, effectively making a single "thread".
>>
>> Sorry, but gmail smtp/send-email does not let me do this - I have
>> tried multiple patches in a single git send-email, and it closes the
>> connection.
>
> The engineers at Google must have fixed something - I tried it just
> now in the manner you described for the avdevice patches.

ping

>
>>
>>>
>>> When you send one email at a time, you'll have to use --in-reply-to
>>> as part of the git send-email command, using the message ID of the email
>>> you want as parent as argument.
>>> ___
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel@ffmpeg.org
>>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

[Ganesh Ajjanagadde]

On Thu, Oct 15, 2015 at 8:06 PM, James Almer  wrote:
> On 10/15/2015 8:52 PM, Ganesh Ajjanagadde wrote:
>> This triggers a few warnings that will need to be fixed - not that bad,
>> the current code is mostly fine.
>>
>
> I think i asked you before, but in any case i'll do it again. Please,
> send patchsets contained in a single thread. You're making things
> hard to track and organize on people's inboxes.
> See https://kernel.org/pub/software/scm/git/docs/git-send-email.html
> --thread, --chain-reply-to and --in-reply-to options.

I find the organization part hard to understand: the pattern
av_warn_unused_result is easily grep-able and all mail clients I know
of have some kind of label/folder option.

Nevertheless, I will try to do this for the next commits. It is
actually easier for me to simply attach all of them to a single email.
Is that also fine?

>
> Thanks.
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

[Michael Niedermayer]

On Thu, Oct 15, 2015 at 08:15:20PM -0400, Ganesh Ajjanagadde wrote:
> On Thu, Oct 15, 2015 at 8:06 PM, James Almer  wrote:
> > On 10/15/2015 8:52 PM, Ganesh Ajjanagadde wrote:
> >> This triggers a few warnings that will need to be fixed - not that bad,
> >> the current code is mostly fine.
> >>
> >
> > I think i asked you before, but in any case i'll do it again. Please,
> > send patchsets contained in a single thread. You're making things
> > hard to track and organize on people's inboxes.
> > See https://kernel.org/pub/software/scm/git/docs/git-send-email.html
> > --thread, --chain-reply-to and --in-reply-to options.
> 
> I find the organization part hard to understand: the pattern
> av_warn_unused_result is easily grep-able and all mail clients I know
> of have some kind of label/folder option.
> 
> Nevertheless, I will try to do this for the next commits. It is

> actually easier for me to simply attach all of them to a single email.
> Is that also fine?

I dont know about others but
I keep track of which patches i still want to look at by keeping the
mails marked as unread in my MUA.
If there are multiple patches in a single mail i cannot keep track of
them using that method

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

[Ganesh Ajjanagadde]

This triggers a few warnings that will need to be fixed - not that bad,
the current code is mostly fine.

Signed-off-by: Ganesh Ajjanagadde 
---
 libavutil/parseutils.h | 5 +
 1 file changed, 5 insertions(+)

diff --git a/libavutil/parseutils.h b/libavutil/parseutils.h
index e66d24b..46de518 100644
--- a/libavutil/parseutils.h
+++ b/libavutil/parseutils.h
@@ -46,6 +46,7 @@
  * @param[in] log_ctx parent logging context
  * @return >= 0 on success, a negative error code otherwise
  */
+av_warn_unused_result
 int av_parse_ratio(AVRational *q, const char *str, int max,
int log_offset, void *log_ctx);
 
@@ -63,6 +64,7 @@ int av_parse_ratio(AVRational *q, const char *str, int max,
  * width x height or a valid video size abbreviation.
  * @return >= 0 on success, a negative error code otherwise
  */
+av_warn_unused_result
 int av_parse_video_size(int *width_ptr, int *height_ptr, const char *str);
 
 /**
@@ -74,6 +76,7 @@ int av_parse_video_size(int *width_ptr, int *height_ptr, 
const char *str);
  * rate_num / rate_den, a float number or a valid video rate abbreviation
  * @return >= 0 on success, a negative error code otherwise
  */
+av_warn_unused_result
 int av_parse_video_rate(AVRational *rate, const char *str);
 
 /**
@@ -95,6 +98,7 @@ int av_parse_video_rate(AVRational *rate, const char *str);
  * @return >= 0 in case of success, a negative value in case of
  * failure (for example if color_string cannot be parsed).
  */
+av_warn_unused_result
 int av_parse_color(uint8_t *rgba_color, const char *color_string, int slen,
void *log_ctx);
 
@@ -143,6 +147,7 @@ const char *av_get_known_color_name(int color_idx, const 
uint8_t **rgb);
  * @return >= 0 in case of success, a negative value corresponding to an
  * AVERROR code otherwise
  */
+av_warn_unused_result
 int av_parse_time(int64_t *timeval, const char *timestr, int duration);
 
 /**
-- 
2.6.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

[James Almer]

On 10/15/2015 8:52 PM, Ganesh Ajjanagadde wrote:
> This triggers a few warnings that will need to be fixed - not that bad,
> the current code is mostly fine.
> 

I think i asked you before, but in any case i'll do it again. Please,
send patchsets contained in a single thread. You're making things
hard to track and organize on people's inboxes.
See https://kernel.org/pub/software/scm/git/docs/git-send-email.html
--thread, --chain-reply-to and --in-reply-to options.

Thanks.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

[Ganesh Ajjanagadde]

On Thu, Oct 15, 2015 at 8:06 PM, James Almer  wrote:
> On 10/15/2015 8:52 PM, Ganesh Ajjanagadde wrote:
>> This triggers a few warnings that will need to be fixed - not that bad,
>> the current code is mostly fine.
>>
>
> I think i asked you before, but in any case i'll do it again. Please,
> send patchsets contained in a single thread. You're making things
> hard to track and organize on people's inboxes.
> See https://kernel.org/pub/software/scm/git/docs/git-send-email.html
> --thread, --chain-reply-to and --in-reply-to options.

Would greatly appreciate a command/command sequence: I am on master
(which is ahead of origin/master) and contains only the avutil warning
stuff (many commits). How do I get a proper chain of emails that you
would like?

>
> Thanks.
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

[Ganesh Ajjanagadde]

On Thu, Oct 15, 2015 at 10:22 PM, Ganesh Ajjanagadde  wrote:
> On Thu, Oct 15, 2015 at 10:16 PM, James Almer  wrote:
>> On 10/15/2015 10:23 PM, Ganesh Ajjanagadde wrote:
>>> On Thu, Oct 15, 2015 at 8:06 PM, James Almer  wrote:
 On 10/15/2015 8:52 PM, Ganesh Ajjanagadde wrote:
> This triggers a few warnings that will need to be fixed - not that bad,
> the current code is mostly fine.
>

 I think i asked you before, but in any case i'll do it again. Please,
 send patchsets contained in a single thread. You're making things
 hard to track and organize on people's inboxes.
 See https://kernel.org/pub/software/scm/git/docs/git-send-email.html
 --thread, --chain-reply-to and --in-reply-to options.
>>>
>>> Would greatly appreciate a command/command sequence: I am on master
>>> (which is ahead of origin/master) and contains only the avutil warning
>>> stuff (many commits). How do I get a proper chain of emails that you
>>> would like?
>>>

 Thanks.
>>
>> When you send several mails with a single git send-email command, it
>> should by default send every email after the first as a reply to the
>> first, effectively making a single "thread".
>
> Sorry, but gmail smtp/send-email does not let me do this - I have
> tried multiple patches in a single git send-email, and it closes the
> connection.

The engineers at Google must have fixed something - I tried it just
now in the manner you described for the avdevice patches.

>
>>
>> When you send one email at a time, you'll have to use --in-reply-to
>> as part of the git send-email command, using the message ID of the email
>> you want as parent as argument.
>> ___
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

[Ganesh Ajjanagadde]

On Thu, Oct 15, 2015 at 10:16 PM, James Almer  wrote:
> On 10/15/2015 10:23 PM, Ganesh Ajjanagadde wrote:
>> On Thu, Oct 15, 2015 at 8:06 PM, James Almer  wrote:
>>> On 10/15/2015 8:52 PM, Ganesh Ajjanagadde wrote:
 This triggers a few warnings that will need to be fixed - not that bad,
 the current code is mostly fine.

>>>
>>> I think i asked you before, but in any case i'll do it again. Please,
>>> send patchsets contained in a single thread. You're making things
>>> hard to track and organize on people's inboxes.
>>> See https://kernel.org/pub/software/scm/git/docs/git-send-email.html
>>> --thread, --chain-reply-to and --in-reply-to options.
>>
>> Would greatly appreciate a command/command sequence: I am on master
>> (which is ahead of origin/master) and contains only the avutil warning
>> stuff (many commits). How do I get a proper chain of emails that you
>> would like?
>>
>>>
>>> Thanks.
>
> When you send several mails with a single git send-email command, it
> should by default send every email after the first as a reply to the
> first, effectively making a single "thread".

Sorry, but gmail smtp/send-email does not let me do this - I have
tried multiple patches in a single git send-email, and it closes the
connection.

>
> When you send one email at a time, you'll have to use --in-reply-to
> as part of the git send-email command, using the message ID of the email
> you want as parent as argument.
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avutil/parseutils: add av_warn_unused_result

[James Almer]

On 10/15/2015 10:23 PM, Ganesh Ajjanagadde wrote:
> On Thu, Oct 15, 2015 at 8:06 PM, James Almer  wrote:
>> On 10/15/2015 8:52 PM, Ganesh Ajjanagadde wrote:
>>> This triggers a few warnings that will need to be fixed - not that bad,
>>> the current code is mostly fine.
>>>
>>
>> I think i asked you before, but in any case i'll do it again. Please,
>> send patchsets contained in a single thread. You're making things
>> hard to track and organize on people's inboxes.
>> See https://kernel.org/pub/software/scm/git/docs/git-send-email.html
>> --thread, --chain-reply-to and --in-reply-to options.
> 
> Would greatly appreciate a command/command sequence: I am on master
> (which is ahead of origin/master) and contains only the avutil warning
> stuff (many commits). How do I get a proper chain of emails that you
> would like?
> 
>>
>> Thanks.

When you send several mails with a single git send-email command, it
should by default send every email after the first as a reply to the
first, effectively making a single "thread".

When you send one email at a time, you'll have to use --in-reply-to
as part of the git send-email command, using the message ID of the email
you want as parent as argument.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel