Re: [FFmpeg-devel] [PATCH] avutil/tx: use ENOSYS instead of ENOTSUP

2021-01-13 Thread Lynne
Jan 14, 2021, 03:04 by jamr...@gmail.com:

> It's the standard error code used across the codebase to signal unimplemented
> or unsupported features.
>
> Signed-off-by: James Almer 
> ---
>  libavutil/tx_template.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavutil/tx_template.c b/libavutil/tx_template.c
> index a91b8f900c..155e879f8e 100644
> --- a/libavutil/tx_template.c
> +++ b/libavutil/tx_template.c
> @@ -684,7 +684,7 @@ int TX_NAME(ff_tx_init_mdct_fft)(AVTXContext *s, av_tx_fn 
> *tx,
>  * direct 3, 5 and 15 transforms as they're too niche. */
>  if (len > 1 || m == 1) {
>  if (is_mdct && (l & 1)) /* Odd (i)MDCTs are not supported yet */
> -return AVERROR(ENOTSUP);
> +return AVERROR(ENOSYS);
>

LGTM, thanks. I'll make a note to use this instead.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avutil/tx: use ENOSYS instead of ENOTSUP

2021-01-13 Thread James Almer
It's the standard error code used across the codebase to signal unimplemented
or unsupported features.

Signed-off-by: James Almer 
---
 libavutil/tx_template.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavutil/tx_template.c b/libavutil/tx_template.c
index a91b8f900c..155e879f8e 100644
--- a/libavutil/tx_template.c
+++ b/libavutil/tx_template.c
@@ -684,7 +684,7 @@ int TX_NAME(ff_tx_init_mdct_fft)(AVTXContext *s, av_tx_fn 
*tx,
  * direct 3, 5 and 15 transforms as they're too niche. */
 if (len > 1 || m == 1) {
 if (is_mdct && (l & 1)) /* Odd (i)MDCTs are not supported yet */
-return AVERROR(ENOTSUP);
+return AVERROR(ENOSYS);
 s->n = l;
 s->m = 1;
 *tx = naive_fft;
-- 
2.30.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".