Re: [FFmpeg-devel] [PATCH] build: add install_name_dir option

2016-02-29 Thread Clément Bœsch
On Thu, Feb 25, 2016 at 02:56:52PM +0100, Clément Bœsch wrote:
> On Thu, Feb 25, 2016 at 02:47:45PM +0100, Hendrik Leppkes wrote:
> > On Thu, Feb 25, 2016 at 2:35 PM, Clément Bœsch  wrote:
> > > From: Clément Bœsch 
> > >
> > > This option is typically useful when cross-compiling dynamic libraries
> > > for iOS, with something such as --install_name_dir=@rpath
> > 
> > I don't know about any other things and their options for iOS
> > building, but that option name in configure looks rather out of place.
> > Can't we at least name it somewhat more fitting, maybe with dashes
> > instead of underscores?
> > 
> 
> Sure, --install-name-dir is better. I didn't find really more appropriate
> section in the helper, but feel free to suggest any other position.
> 

Applied as "--install-name-dir"

-- 
Clément B.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH] build: add install_name_dir option

2016-02-25 Thread Clément Bœsch
On Thu, Feb 25, 2016 at 02:47:45PM +0100, Hendrik Leppkes wrote:
> On Thu, Feb 25, 2016 at 2:35 PM, Clément Bœsch  wrote:
> > From: Clément Bœsch 
> >
> > This option is typically useful when cross-compiling dynamic libraries
> > for iOS, with something such as --install_name_dir=@rpath
> 
> I don't know about any other things and their options for iOS
> building, but that option name in configure looks rather out of place.
> Can't we at least name it somewhat more fitting, maybe with dashes
> instead of underscores?
> 

Sure, --install-name-dir is better. I didn't find really more appropriate
section in the helper, but feel free to suggest any other position.

-- 
Clément B.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH] build: add install_name_dir option

2016-02-25 Thread Hendrik Leppkes
On Thu, Feb 25, 2016 at 2:35 PM, Clément Bœsch  wrote:
> From: Clément Bœsch 
>
> This option is typically useful when cross-compiling dynamic libraries
> for iOS, with something such as --install_name_dir=@rpath

I don't know about any other things and their options for iOS
building, but that option name in configure looks rather out of place.
Can't we at least name it somewhat more fitting, maybe with dashes
instead of underscores?

- Hendrik
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


[FFmpeg-devel] [PATCH] build: add install_name_dir option

2016-02-25 Thread Clément Bœsch
From: Clément Bœsch 

This option is typically useful when cross-compiling dynamic libraries
for iOS, with something such as --install_name_dir=@rpath
---
 configure | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/configure b/configure
index 8436b09..64750e4 100755
--- a/configure
+++ b/configure
@@ -91,6 +91,7 @@ Standard options:
   --enable-rpath   use rpath to allow installing libraries in paths
not part of the dynamic linker search path
use rpath when linking programs [USE WITH CARE]
+  --install_name_dir=DIR   Darwin directory name for installed targets
 
 Licensing options:
   --enable-gpl allow use of GPL code, the resulting libs
@@ -2075,6 +2076,7 @@ PATHS_LIST="
 pkgconfigdir
 prefix
 shlibdir
+install_name_dir
 "
 
 CMDLINE_SET="
@@ -4516,7 +4518,8 @@ case $target_os in
 ;;
 darwin)
 enabled ppc && add_asflags -force_cpusubtype_ALL
-SHFLAGS='-dynamiclib -Wl,-single_module 
-Wl,-install_name,$(SHLIBDIR)/$(SLIBNAME_WITH_MAJOR),-current_version,$(LIBVERSION),-compatibility_version,$(LIBMAJOR)'
+install_name_dir_default='$(SHLIBDIR)'
+SHFLAGS='-dynamiclib -Wl,-single_module 
-Wl,-install_name,$(INSTALL_NAME_DIR)/$(SLIBNAME_WITH_MAJOR),-current_version,$(LIBVERSION),-compatibility_version,$(LIBMAJOR)'
 enabled x86_32 && append SHFLAGS -Wl,-read_only_relocs,suppress
 strip="${strip} -x"
 add_ldflags -Wl,-dynamic,-search_paths_first
@@ -6292,6 +6295,7 @@ DATADIR=\$(DESTDIR)$datadir
 DOCDIR=\$(DESTDIR)$docdir
 MANDIR=\$(DESTDIR)$mandir
 PKGCONFIGDIR=\$(DESTDIR)$pkgconfigdir
+INSTALL_NAME_DIR=$install_name_dir
 SRC_PATH=$source_path
 SRC_LINK=$source_link
 ifndef MAIN_MAKEFILE
-- 
2.7.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel