Re: [FFmpeg-devel] [PATCH] configure: Don't pass -mfp16-format to MSVC on ARM

2024-01-04 Thread Martin Storsjö 

On Fri, 22 Dec 2023, Martin Storsjö wrote:


The check for this option does succeed - MSVC accepts the option,
but prints a warning about it being unknown and ignored, for
each compiled object file:

   cl : Command line warning D9002 : ignoring unknown option 
'-mfp16-format=ieee'

The configure script only attempts to add this option on ARM,
therefore this warning isn't seen by the majority of people
building with MSVC.

Making this option into a no-op probably isn't entirely right,
but on the other hand, we don't want to litter the code that
checks for support for the option with compiler specific
conditions either.
---
configure | 1 +
1 file changed, 1 insertion(+)

diff --git a/configure b/configure
index 18fe8eaa5c..31d0039fed 100755
--- a/configure
+++ b/configure
@@ -4702,6 +4702,7 @@ msvc_common_flags(){
-fPIC);;
-mthumb)  ;;
-march=*) ;;
+-mfp16-format=*)  ;;
-lz)  echo zlib.lib ;;
-lx264)   echo libx264.lib ;;
-lstdc++) ;;
--
2.34.1


Will push soon

// Martin
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] configure: Don't pass -mfp16-format to MSVC on ARM

2023-12-21 Thread Martin Storsjö 
The check for this option does succeed - MSVC accepts the option,
but prints a warning about it being unknown and ignored, for
each compiled object file:

cl : Command line warning D9002 : ignoring unknown option 
'-mfp16-format=ieee'

The configure script only attempts to add this option on ARM,
therefore this warning isn't seen by the majority of people
building with MSVC.

Making this option into a no-op probably isn't entirely right,
but on the other hand, we don't want to litter the code that
checks for support for the option with compiler specific
conditions either.
---
 configure | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configure b/configure
index 18fe8eaa5c..31d0039fed 100755
--- a/configure
+++ b/configure
@@ -4702,6 +4702,7 @@ msvc_common_flags(){
 -fPIC);;
 -mthumb)  ;;
 -march=*) ;;
+-mfp16-format=*)  ;;
 -lz)  echo zlib.lib ;;
 -lx264)   echo libx264.lib ;;
 -lstdc++) ;;
-- 
2.34.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".