Re: [FFmpeg-devel] [PATCH] doc/encoders: correct the description for ts_target_bitrate

2019-12-20 Thread James Zern 
On Wed, Dec 18, 2019 at 4:17 PM Wonkap Jang
 wrote:
>
> ts_target_bitrate is in kbps, not bps. This commit clarifies the unit
> and modifies the example to match the description.
> ---
>  doc/encoders.texi | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>

applied, thanks.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/encoders: correct the description for ts_target_bitrate

2019-12-19 Thread James Zern 
Hi,

On Wed, Dec 18, 2019 at 2:00 PM Wonkap Jang
 wrote:
>
> Hi James,
>
> I have updated the libvpx.
> https://chromium-review.googlesource.com/c/webm/libvpx/+/1974899
>

Thanks for posting the patch. Remember top-posting isn't preferred on
this mailing list [1].

[1] http://ffmpeg.org/contact.html#MailingLists

> Thank you,
>
> Wonkap
>
> On Wed, Dec 18, 2019 at 1:39 PM James Zern 
> wrote:
>
> > Hi,
> >
> > On Wed, Dec 18, 2019 at 1:17 PM Wonkap Jang
> >  wrote:
> > >
> > > ts_target_bitrate is in kbps, not bps. This commit clarifies the unit
> > > and modifies the example to match the description.
> > > ---
> > >  doc/encoders.texi | 5 +++--
> > >  1 file changed, 3 insertions(+), 2 deletions(-)
> > >
> >
> > lgtm if you can verify that with the libvpx implementation and update
> > the docs [1].
> >
> > [1]
> > https://chromium.googlesource.com/webm/libvpx/+/refs/heads/master/vpx/vpx_encoder.h#646
> > ___
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/encoders: correct the description for ts_target_bitrate

2019-12-18 Thread Wonkap Jang 
Hi James,

I have updated the libvpx.
https://chromium-review.googlesource.com/c/webm/libvpx/+/1974899

Thank you,

Wonkap

On Wed, Dec 18, 2019 at 1:39 PM James Zern 
wrote:

> Hi,
>
> On Wed, Dec 18, 2019 at 1:17 PM Wonkap Jang
>  wrote:
> >
> > ts_target_bitrate is in kbps, not bps. This commit clarifies the unit
> > and modifies the example to match the description.
> > ---
> >  doc/encoders.texi | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
>
> lgtm if you can verify that with the libvpx implementation and update
> the docs [1].
>
> [1]
> https://chromium.googlesource.com/webm/libvpx/+/refs/heads/master/vpx/vpx_encoder.h#646
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/encoders: correct the description for ts_target_bitrate

2019-12-18 Thread James Zern 
Hi,

On Wed, Dec 18, 2019 at 1:17 PM Wonkap Jang
 wrote:
>
> ts_target_bitrate is in kbps, not bps. This commit clarifies the unit
> and modifies the example to match the description.
> ---
>  doc/encoders.texi | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>

lgtm if you can verify that with the libvpx implementation and update
the docs [1].

[1] 
https://chromium.googlesource.com/webm/libvpx/+/refs/heads/master/vpx/vpx_encoder.h#646
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] doc/encoders: correct the description for ts_target_bitrate

2019-12-18 Thread Wonkap Jang 
ts_target_bitrate is in kbps, not bps. This commit clarifies the unit
and modifies the example to match the description.
---
 doc/encoders.texi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/doc/encoders.texi b/doc/encoders.texi
index 4ee518a124..a207363650 100644
--- a/doc/encoders.texi
+++ b/doc/encoders.texi
@@ -1893,7 +1893,7 @@ key=value pairs. For example, to specify temporal 
scalability parameters
 with @code{ffmpeg}:
 @example
 ffmpeg -i INPUT -c:v libvpx -ts-parameters ts_number_layers=3:\
-ts_target_bitrate=25,50,100:ts_rate_decimator=4,2,1:\
+ts_target_bitrate=250,500,1000:ts_rate_decimator=4,2,1:\
 ts_periodicity=4:ts_layer_id=0,2,1,2 OUTPUT
 @end example
 Below is a brief explanation of each of the parameters, please
@@ -1903,7 +1903,8 @@ details.
 @item ts_number_layers
 Number of temporal coding layers.
 @item ts_target_bitrate
-Target bitrate for each temporal layer.
+Target bitrate for each temporal layer (in kbps).
+(bitrate should be inclusive of the lower temporal layer).
 @item ts_rate_decimator
 Frame rate decimation factor for each temporal layer.
 @item ts_periodicity
-- 
2.24.1.735.g03f4e72817-goog

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".