Re: [FFmpeg-devel] [PATCH] doc: drawtext options update

2017-02-22 Thread Lou Logan 
On Tue, 21 Feb 2017 21:24:55 -0900, Lou Logan wrote:

> This can occur if the patch itself is directly edited, but I can fix it
> and apply within 24 hours.

Pushed, thanks.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] doc: drawtext options update

2017-02-21 Thread Lou Logan 
On Tue, Feb 21, 2017, at 07:53 PM, Mulvya V wrote:
> Hi Lou,
> 
> Did you mean the trailing whitespace throughout or only at the end of the
> patch file? In any case, I trimmed those from the attached patch.

I meant the trailing whitespace throughout.

The patch appears to be corrupt: 

  Applying: doc: update drawtext options
  error: corrupt patch at line 25
  Patch failed at 0001 doc: update drawtext options

This can occur if the patch itself is directly edited, but I can fix it
and apply within 24 hours.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] doc: drawtext options update

2017-02-21 Thread Mulvya V 
Hi Lou,

Did you mean the trailing whitespace throughout or only at the end of the
patch file? In any case, I trimmed those from the attached patch.

Regards,
mulvya

On Wed, Feb 22, 2017 at 1:35 AM, Lou Logan  wrote:

> On Tue, 21 Feb 2017 12:26:55 +0530, Mulvya V wrote:
>
> > Hi,
> >
> > Revised patch to include basetime option.
> >
> > Thanks,
> > mulvya
>
> Thanks for the update, but the patch contains trailing whitespaces which
> are to be avoided and are causing the patch to fail to be applied.
>
> Also, please break long lines. 70-80 character width is fine for
> documentation.
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>


0003-doc-update-drawtext-options.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] doc: drawtext options update

2017-02-21 Thread Lou Logan 
On Tue, 21 Feb 2017 12:26:55 +0530, Mulvya V wrote:

> Hi,
> 
> Revised patch to include basetime option.
> 
> Thanks,
> mulvya

Thanks for the update, but the patch contains trailing whitespaces which
are to be avoided and are causing the patch to fail to be applied.

Also, please break long lines. 70-80 character width is fine for
documentation.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] doc: drawtext options update

2017-02-20 Thread Mulvya V 
Hi,

Revised patch to include basetime option.

Thanks,
mulvya

On Sun, Feb 19, 2017 at 10:00 PM, Mulvya V  wrote:

> Hi,
>
> Added entry for hitherto undocumented timecode wrap option. Removed
> bizarre entry for non-existent draw option.
>
> Haven't added entry for basetime option since it applies only in strftime
> expansion mode. Should it be documented?
>
> Thanks,
> mulvya
>


0002-doc-update-drawtext-options.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] doc: drawtext options update

2017-02-20 Thread Lou Logan 
Hi,

On Sun, Feb 19, 2017, at 07:30 AM, Mulvya V wrote:
> Haven't added entry for basetime option since it applies only in strftime
> expansion mode. Should it be documented?

If it still works, sure, as long as it is clear that it only applies to
the deprecated strftime mode. I think we should keep the documentation
in sync with existing options even if they are considered deprecated and
marked as such (and inform the user of what to use instead, if
possible). The documentation, in theory, can be updated when/if the
feature is finally removed.

Thanks.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel