[FFmpeg-devel] [PATCH] fix bs2b parameter description
>From f0fdf5360ecd52d5f4031af9165b94c211defa03 Mon Sep 17 00:00:00 2001 From: Yue Wang Date: Sat, 15 Jan 2022 10:14:17 +0900 Subject: [PATCH] fix bs2b parameter description. --- libavfilter/af_bs2b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_bs2b.c b/libavfilter/af_bs2b.c index 90ae846d95..de2d6dd6c7 100644 --- a/libavfilter/af_bs2b.c +++ b/libavfilter/af_bs2b.c @@ -57,7 +57,7 @@ static const AVOption bs2b_options[] = { { "jmeier", "Jan Meier circuit", 0, AV_OPT_TYPE_CONST, { .i64 = BS2B_JMEIER_CLEVEL }, 0, 0, A, "profile" }, { "fcut", "Set cut frequency (in Hz)", OFFSET(fcut), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, BS2B_MAXFCUT, A }, -{ "feed", "Set feed level (in Hz)", +{ "feed", "Set feed level (in db * 10)", OFFSET(feed), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, BS2B_MAXFEED, A }, { NULL }, }; -- 2.34.1.703.g22d0c6ccf7-goog ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] fix bs2b parameter description
Can someone review and approve this change? it's pretty trivial On Sat, Jan 15, 2022 at 11:45 PM Yue Wang wrote: > From f0fdf5360ecd52d5f4031af9165b94c211defa03 Mon Sep 17 00:00:00 2001 > From: Yue Wang > Date: Sat, 15 Jan 2022 10:14:17 +0900 > Subject: [PATCH] fix bs2b parameter description. > > --- > libavfilter/af_bs2b.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/af_bs2b.c b/libavfilter/af_bs2b.c > index 90ae846d95..de2d6dd6c7 100644 > --- a/libavfilter/af_bs2b.c > +++ b/libavfilter/af_bs2b.c > @@ -57,7 +57,7 @@ static const AVOption bs2b_options[] = { > { "jmeier", "Jan Meier circuit", 0, AV_OPT_TYPE_CONST, { .i64 = > BS2B_JMEIER_CLEVEL }, 0, 0, A, "profile" }, > { "fcut", "Set cut frequency (in Hz)", > OFFSET(fcut), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, BS2B_MAXFCUT, > A }, > -{ "feed", "Set feed level (in Hz)", > +{ "feed", "Set feed level (in db * 10)", > OFFSET(feed), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, BS2B_MAXFEED, > A }, > { NULL }, > }; > -- > 2.34.1.703.g22d0c6ccf7-goog > > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] fix bs2b parameter description
On 2022-01-25 03:25 pm, Yue Wang wrote: Can someone review and approve this change? it's pretty trivial Needs changes in doc/filters.texi too. Since this is an ext library option, a link to reference is helpful. Regards, Gyan On Sat, Jan 15, 2022 at 11:45 PM Yue Wang wrote: From f0fdf5360ecd52d5f4031af9165b94c211defa03 Mon Sep 17 00:00:00 2001 From: Yue Wang Date: Sat, 15 Jan 2022 10:14:17 +0900 Subject: [PATCH] fix bs2b parameter description. --- libavfilter/af_bs2b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_bs2b.c b/libavfilter/af_bs2b.c index 90ae846d95..de2d6dd6c7 100644 --- a/libavfilter/af_bs2b.c +++ b/libavfilter/af_bs2b.c @@ -57,7 +57,7 @@ static const AVOption bs2b_options[] = { { "jmeier", "Jan Meier circuit", 0, AV_OPT_TYPE_CONST, { .i64 = BS2B_JMEIER_CLEVEL }, 0, 0, A, "profile" }, { "fcut", "Set cut frequency (in Hz)", OFFSET(fcut), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, BS2B_MAXFCUT, A }, -{ "feed", "Set feed level (in Hz)", +{ "feed", "Set feed level (in db * 10)", OFFSET(feed), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, BS2B_MAXFEED, A }, { NULL }, }; -- 2.34.1.703.g22d0c6ccf7-goog ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH] fix bs2b parameter description
Hi Gyan The reference is bs2b's header file available here: https://sourceforge.net/p/bs2b/code/HEAD/tree/trunk/libbs2b/src/bs2b.h Between line 102-112, particularly these two APIs: /* Sets a new coefficients by new cut frecuency value (Hz). */ void bs2b_set_level_fcut( t_bs2bdp bs2bdp, int fcut ); and /* Sets a new coefficients by new crossfeeding level value (dB * 10). */ void bs2b_set_level_feed( t_bs2bdp bs2bdp, int feed ); which correspond to the following two parameters in ffmpeg: - "fcut", "Set cut frequency (in Hz)", - "feed", "Set feed level (in db * 10)", Yue ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".