Re: [FFmpeg-devel] [PATCH] lavf/ffmenc: fix memleak in ffm_write_header

2014-11-18 Thread Michael Niedermayer 
On Tue, Nov 18, 2014 at 03:16:19AM -0300, James Almer wrote:
 Regression since 745730c9c208c40f800d5d71ffa39aceab6ce044.
 The dynamic buffer was not being used or freed.
 
 Signed-off-by: James Almer jamr...@gmail.com

LGTM

thanks

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/ffmenc: fix memleak in ffm_write_header

2014-11-18 Thread James Almer 
On 18/11/14 7:26 AM, Michael Niedermayer wrote:
 On Tue, Nov 18, 2014 at 03:16:19AM -0300, James Almer wrote:
 Regression since 745730c9c208c40f800d5d71ffa39aceab6ce044.
 The dynamic buffer was not being used or freed.

 Signed-off-by: James Almer jamr...@gmail.com
 
 LGTM
 
 thanks

Pushed.

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] lavf/ffmenc: fix memleak in ffm_write_header

2014-11-17 Thread James Almer 
Regression since 745730c9c208c40f800d5d71ffa39aceab6ce044.
The dynamic buffer was not being used or freed.

Signed-off-by: James Almer jamr...@gmail.com
---
 libavformat/ffmenc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libavformat/ffmenc.c b/libavformat/ffmenc.c
index b717813..c64c26b 100644
--- a/libavformat/ffmenc.c
+++ b/libavformat/ffmenc.c
@@ -217,8 +217,6 @@ static int ffm_write_header(AVFormatContext *s)
 avio_write(pb, codec-extradata, codec-extradata_size);
 }
 write_header_chunk(s-pb, pb, MKBETAG('C', 'O', 'M', 'M'));
-if(avio_open_dyn_buf(pb)  0)
-return AVERROR(ENOMEM);
 /* specific info */
 switch(codec-codec_type) {
 case AVMEDIA_TYPE_VIDEO:
-- 
2.1.3

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel