Re: [FFmpeg-devel] [PATCH] lavfi/vf_scale_qsv: remove PI, PHI and E

2022-12-07 Thread Xiang, Haihao 
On Wo, 2022-12-07 at 10:51 +0530, Gyan Doshi wrote:
> 
> On 2022-12-07 08:13 am, Xiang, Haihao wrote:
> > From: Haihao Xiang 
> > 
> > PI, PHI and E are defined in libavutil/eval.c, and user may use these
> > constants for scale_qsv filter, so we needn't re-define these variables
> > in vf_scale_qsv.c
> 
> LGTM.

Thanks for review, applied. 

-Haihao

> 
> 
> > Signed-off-by: Haihao Xiang 
> > ---
> >   libavfilter/vf_scale_qsv.c | 9 -
> >   1 file changed, 9 deletions(-)
> > 
> > diff --git a/libavfilter/vf_scale_qsv.c b/libavfilter/vf_scale_qsv.c
> > index 758e730f78..fa37e95429 100644
> > --- a/libavfilter/vf_scale_qsv.c
> > +++ b/libavfilter/vf_scale_qsv.c
> > @@ -44,9 +44,6 @@
> >   #include "video.h"
> >   
> >   static const char *const var_names[] = {
> > -"PI",
> > -"PHI",
> > -"E",
> >   "in_w",   "iw",
> >   "in_h",   "ih",
> >   "out_w",  "ow",
> > @@ -57,9 +54,6 @@ static const char *const var_names[] = {
> >   };
> >   
> >   enum var_name {
> > -VAR_PI,
> > -VAR_PHI,
> > -VAR_E,
> >   VAR_IN_W,   VAR_IW,
> >   VAR_IN_H,   VAR_IH,
> >   VAR_OUT_W,  VAR_OW,
> > @@ -470,9 +464,6 @@ static int qsvscale_config_props(AVFilterLink *outlink)
> >   char *expr;
> >   int ret;
> >   
> > -var_values[VAR_PI]= M_PI;
> > -var_values[VAR_PHI]   = M_PHI;
> > -var_values[VAR_E] = M_E;
> >   var_values[VAR_IN_W]  = var_values[VAR_IW] = inlink->w;
> >   var_values[VAR_IN_H]  = var_values[VAR_IH] = inlink->h;
> >   var_values[VAR_OUT_W] = var_values[VAR_OW] = NAN;
> 
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] lavfi/vf_scale_qsv: remove PI, PHI and E

2022-12-06 Thread Gyan Doshi 




On 2022-12-07 08:13 am, Xiang, Haihao wrote:

From: Haihao Xiang 

PI, PHI and E are defined in libavutil/eval.c, and user may use these
constants for scale_qsv filter, so we needn't re-define these variables
in vf_scale_qsv.c


LGTM.




Signed-off-by: Haihao Xiang 
---
  libavfilter/vf_scale_qsv.c | 9 -
  1 file changed, 9 deletions(-)

diff --git a/libavfilter/vf_scale_qsv.c b/libavfilter/vf_scale_qsv.c
index 758e730f78..fa37e95429 100644
--- a/libavfilter/vf_scale_qsv.c
+++ b/libavfilter/vf_scale_qsv.c
@@ -44,9 +44,6 @@
  #include "video.h"
  
  static const char *const var_names[] = {

-"PI",
-"PHI",
-"E",
  "in_w",   "iw",
  "in_h",   "ih",
  "out_w",  "ow",
@@ -57,9 +54,6 @@ static const char *const var_names[] = {
  };
  
  enum var_name {

-VAR_PI,
-VAR_PHI,
-VAR_E,
  VAR_IN_W,   VAR_IW,
  VAR_IN_H,   VAR_IH,
  VAR_OUT_W,  VAR_OW,
@@ -470,9 +464,6 @@ static int qsvscale_config_props(AVFilterLink *outlink)
  char *expr;
  int ret;
  
-var_values[VAR_PI]= M_PI;

-var_values[VAR_PHI]   = M_PHI;
-var_values[VAR_E] = M_E;
  var_values[VAR_IN_W]  = var_values[VAR_IW] = inlink->w;
  var_values[VAR_IN_H]  = var_values[VAR_IH] = inlink->h;
  var_values[VAR_OUT_W] = var_values[VAR_OW] = NAN;


___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] lavfi/vf_scale_qsv: remove PI, PHI and E

2022-12-06 Thread Xiang, Haihao 
From: Haihao Xiang 

PI, PHI and E are defined in libavutil/eval.c, and user may use these
constants for scale_qsv filter, so we needn't re-define these variables
in vf_scale_qsv.c

Signed-off-by: Haihao Xiang 
---
 libavfilter/vf_scale_qsv.c | 9 -
 1 file changed, 9 deletions(-)

diff --git a/libavfilter/vf_scale_qsv.c b/libavfilter/vf_scale_qsv.c
index 758e730f78..fa37e95429 100644
--- a/libavfilter/vf_scale_qsv.c
+++ b/libavfilter/vf_scale_qsv.c
@@ -44,9 +44,6 @@
 #include "video.h"
 
 static const char *const var_names[] = {
-"PI",
-"PHI",
-"E",
 "in_w",   "iw",
 "in_h",   "ih",
 "out_w",  "ow",
@@ -57,9 +54,6 @@ static const char *const var_names[] = {
 };
 
 enum var_name {
-VAR_PI,
-VAR_PHI,
-VAR_E,
 VAR_IN_W,   VAR_IW,
 VAR_IN_H,   VAR_IH,
 VAR_OUT_W,  VAR_OW,
@@ -470,9 +464,6 @@ static int qsvscale_config_props(AVFilterLink *outlink)
 char *expr;
 int ret;
 
-var_values[VAR_PI]= M_PI;
-var_values[VAR_PHI]   = M_PHI;
-var_values[VAR_E] = M_E;
 var_values[VAR_IN_W]  = var_values[VAR_IW] = inlink->w;
 var_values[VAR_IN_H]  = var_values[VAR_IH] = inlink->h;
 var_values[VAR_OUT_W] = var_values[VAR_OW] = NAN;
-- 
2.25.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".