Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Issue fixed: QSV engine does not release display handler under linux platform.
Hello Gwenole, As I can see the current implementation of qsv-accelerated components already allows to use external MXF session created by main application. Please look the AVQSVContext structure into \libavcodec\qsv.h, example of its allocation into the \doc\examples\qsvdec.c and how AVCodecContext::hwaccel_context uses into the libavcodec\qsvenc.c::ff_qsv_enc_init() Only when external session not specified the qsv engine forced to search appropriate device by itself and open an internal session. Tuesday, July 14, 2015, 12:26:41 AM, you wrote: GB> Note it would also be interesting to provide a means to import a GB> VADisplay from the user through an additional function. e.g. in view GB> to interop VA decode to MSDK encode and/or video processing. GB> Regards, -- Best regards, Ivanmailto:ivan.us...@nablet.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Issue fixed: QSV engine does not release display handler under linux platform.
On Mon, Jul 13, 2015 at 11:26:41PM +0200, Gwenole Beauchesne wrote: > Hi, > > 2015-07-13 16:22 GMT+02:00 Ivan Uskov : > > Hello All, > > > > Current QSV engine implementation does allocate but never does release > > a display handler under linux platforms. > > The attached patch solved this issue, please review. > > LGTM. However, missing newline IMHO before > ff_qsv_close_internal_session() and after QSVSession definition. newlines added applied thanks > > Note it would also be interesting to provide a means to import a > VADisplay from the user through an additional function. e.g. in view > to interop VA decode to MSDK encode and/or video processing. > > Regards, > -- > Gwenole Beauchesne > Intel Corporation SAS / 2 rue de Paris, 92196 Meudon Cedex, France > Registration Number (RCS): Nanterre B 302 456 199 > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Asymptotically faster algorithms should always be preferred if you have asymptotical amounts of data signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] libavcodec/qsv.c: Issue fixed: QSV engine does not release display handler under linux platform.
Hi, 2015-07-13 16:22 GMT+02:00 Ivan Uskov : > Hello All, > > Current QSV engine implementation does allocate but never does release > a display handler under linux platforms. > The attached patch solved this issue, please review. LGTM. However, missing newline IMHO before ff_qsv_close_internal_session() and after QSVSession definition. Note it would also be interesting to provide a means to import a VADisplay from the user through an additional function. e.g. in view to interop VA decode to MSDK encode and/or video processing. Regards, -- Gwenole Beauchesne Intel Corporation SAS / 2 rue de Paris, 92196 Meudon Cedex, France Registration Number (RCS): Nanterre B 302 456 199 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH] libavcodec/qsv.c: Issue fixed: QSV engine does not release display handler under linux platform.
Hello All, Current QSV engine implementation does allocate but never does release a display handler under linux platforms. The attached patch solved this issue, please review. -- Best regards, Ivan mailto:ivan.us...@nablet.com 0001-libavcodec-qsv.c-Issue-fixed-QSV-engine-does-not-rel.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
