Re: [FFmpeg-devel] [PATCH] mips: disable all features in configure if no cpu is matched
On Thu, Oct 15, 2015 at 01:22:39PM +, Nedeljko Babic wrote: > >> > >> On the other hand, if cpu option is used with some cpu that is not > >> supported in > >> the list, configuration will break since “-march” is set to that cpu > >> value. > > > >Are you sure? What happen if you pass --cpu=mips32r2? Then -march will > >be set to mips32r2 which is valid :-) > > Yes, you are correct. > > I didn't consider setting arch in cpu :) > > Taking this in to consideration, this patch looks good to me. applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us carefully observe those good qualities wherein our enemies excel us and endeavor to excel them, by avoiding what is faulty, and imitating what is excellent in them. -- Plutarch signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] mips: disable all features in configure if no cpu is matched
>> >> On the other hand, if cpu option is used with some cpu that is not supported >> in >> the list, configuration will break since “-march” is set to that cpu value. > >Are you sure? What happen if you pass --cpu=mips32r2? Then -march will >be set to mips32r2 which is valid :-) Yes, you are correct. I didn't consider setting arch in cpu :) Taking this in to consideration, this patch looks good to me. Thanks, Nedeljko ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] mips: disable all features in configure if no cpu is matched
Dear Nedeljko Babic, On 10/15/2015 01:05 PM, Nedeljko Babic wrote: > Hello, > >> Signed-off-by: Vicente Olivert Riera >> --- >> configure |9 + >> 1 files changed, 9 insertions(+), 0 deletions(-) >> >> diff --git a/configure b/configure >> index 7e55e92..cd27ad7 100755 >> --- a/configure >> +++ b/configure >> @@ -4130,6 +4130,15 @@ elif enabled mips; then >> disable mips64r6 >> disable msa >> ;; >> +*) >> +disable mipsfpu >> +disable mips32r2 >> +disable mips32r5 >> +disable mips64r6 >> +disable mipsdspr1 >> +disable mipsdspr2 >> +disable msa >> +;; >> esac > > This case will never be reached. > > If configure “--cpu” option is not used, default is cpu=generic. > > On the other hand, if cpu option is used with some cpu that is not supported > in > the list, configuration will break since “-march” is set to that cpu value. Are you sure? What happen if you pass --cpu=mips32r2? Then -march will be set to mips32r2 which is valid :-) Regards, Vincent. >> >> elif enabled ppc; then > > -Nedeljko > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] mips: disable all features in configure if no cpu is matched
Hello, >Signed-off-by: Vicente Olivert Riera >--- > configure |9 + > 1 files changed, 9 insertions(+), 0 deletions(-) > >diff --git a/configure b/configure >index 7e55e92..cd27ad7 100755 >--- a/configure >+++ b/configure >@@ -4130,6 +4130,15 @@ elif enabled mips; then > disable mips64r6 > disable msa > ;; >+*) >+disable mipsfpu >+disable mips32r2 >+disable mips32r5 >+disable mips64r6 >+disable mipsdspr1 >+disable mipsdspr2 >+disable msa >+;; > esac This case will never be reached. If configure “--cpu” option is not used, default is cpu=generic. On the other hand, if cpu option is used with some cpu that is not supported in the list, configuration will break since “-march” is set to that cpu value. > > elif enabled ppc; then -Nedeljko ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH] mips: disable all features in configure if no cpu is matched
Signed-off-by: Vicente Olivert Riera --- configure |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 7e55e92..cd27ad7 100755 --- a/configure +++ b/configure @@ -4130,6 +4130,15 @@ elif enabled mips; then disable mips64r6 disable msa ;; +*) +disable mipsfpu +disable mips32r2 +disable mips32r5 +disable mips64r6 +disable mipsdspr1 +disable mipsdspr2 +disable msa +;; esac elif enabled ppc; then -- 1.7.1 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
