Re: [FFmpeg-devel] [PATCH]Autoselect ffv1 coder also for RGB colourpaces

2015-03-09 Thread Carl Eugen Hoyos 
Michael Niedermayer  gmx.at> writes:

> > Attached patch makes the behaviour of ffv1 using gprp 
> > more similar to yuv for >8 bit.
> > Reported by Christoph Gerstbauer .
> > 
> > Please comment, Carl Eugen
> 
> LGTM

Patch applied.

Thank you, Carl Eugen

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]Autoselect ffv1 coder also for RGB colourpaces

2015-03-06 Thread Michael Niedermayer 
On Fri, Mar 06, 2015 at 04:48:36PM +0100, Carl Eugen Hoyos wrote:
> Hi!
> 
> Attached patch makes the behaviour of ffv1 using gprp more similar 
> to yuv for >8 bit.
> Reported by Christoph Gerstbauer .
> 
> Please comment, Carl Eugen

LGTM

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

What does censorship reveal? It reveals fear. -- Julian Assange


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH]Autoselect ffv1 coder also for RGB colourpaces

2015-03-06 Thread Carl Eugen Hoyos 
Hi!

Attached patch makes the behaviour of ffv1 using gprp more similar 
to yuv for >8 bit.
Reported by Christoph Gerstbauer .

Please comment, Carl Eugen
diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c
index c3bf759..942bc37 100644
--- a/libavcodec/ffv1enc.c
+++ b/libavcodec/ffv1enc.c
@@ -780,6 +780,10 @@ static av_cold int encode_init(AVCodecContext *avctx)
 s->colorspace = 1;
 s->chroma_planes = 1;
 s->version = FFMAX(s->version, 1);
+if (!s->ac && avctx->coder_type == -1) {
+av_log(avctx, AV_LOG_INFO, "bits_per_raw_sample > 8, forcing coder 
1\n");
+s->ac = 2;
+}
 if (!s->ac) {
 av_log(avctx, AV_LOG_ERROR, "bits_per_raw_sample of more than 8 
needs -coder 1 currently\n");
 return AVERROR(ENOSYS);
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel