Re: [FFmpeg-devel] [PATCH]asfdec: Reduce minimum header size (was: New asf demuxer)
On 6/29/2015 11:01 AM, Hendrik Leppkes wrote: Just on code quality alone, I think it would be much more productive if you look for the opposite and fix those. Trying to juke the stats after-the-fact by fixing the old one now is not going to change anything. :p But then how can he hate on Libav? Anyway, I thought it was worth noting that the idea of lowering the minimum header size was thrown around before (back when MSS1/2 was added IIRC), and it was deemed problematic. I can't quite recall the specific reason, though; I'd have to look it up in the archives. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH]asfdec: Reduce minimum header size (was: New asf demuxer)
On Mon, Jun 29, 2015 at 10:11:11AM +0200, Carl Eugen Hoyos wrote: Hi! I finally found an issue that is fixed with the new asf demuxer: Video in http://samples.ffmpeg.org/V-codecs/MSS1/GipsyGuitar.wmv freezes for ten seconds after 110 seconds, this does not happen with -f asf_o. Attached patch fixes this issue, fate passes, no other sample tested with the patch applied. Please comment, Carl Eugen asfdec.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) 3fa95afebd3a0589d7bdb9c6695ac3610824d19c patchasfheadersize.diff LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Asymptotically faster algorithms should always be preferred if you have asymptotical amounts of data signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH]asfdec: Reduce minimum header size (was: New asf demuxer)
On Mon, Jun 29, 2015 at 10:11 AM, Carl Eugen Hoyos ceho...@ag.or.at wrote: Hi! I finally found an issue that is fixed with the new asf demuxer: Video in http://samples.ffmpeg.org/V-codecs/MSS1/GipsyGuitar.wmv freezes for ten seconds after 110 seconds, this does not happen with -f asf_o. Attached patch fixes this issue, fate passes, no other sample tested with the patch applied. Just on code quality alone, I think it would be much more productive if you look for the opposite and fix those. Trying to juke the stats after-the-fact by fixing the old one now is not going to change anything. :p - Hendrik ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
[FFmpeg-devel] [PATCH]asfdec: Reduce minimum header size (was: New asf demuxer)
Hi!
I finally found an issue that is fixed with the new asf demuxer:
Video in http://samples.ffmpeg.org/V-codecs/MSS1/GipsyGuitar.wmv
freezes for ten seconds after 110 seconds, this does not happen
with -f asf_o.
Attached patch fixes this issue, fate passes, no other sample
tested with the patch applied.
Please comment, Carl Eugen
diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c
index a8cae56..ed33828 100644
--- a/libavformat/asfdec.c
+++ b/libavformat/asfdec.c
@@ -132,7 +132,7 @@ static const AVClass asf_class = {
#include assert.h
#define ASF_MAX_STREAMS 127
-#define FRAME_HEADER_SIZE 11
+#define FRAME_HEADER_SIZE 6
// Fix Me! FRAME_HEADER_SIZE may be different. (17 is known to be too large)
#ifdef DEBUG
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH]asfdec: Reduce minimum header size (was: New asf demuxer)
Hendrik Leppkes h.leppkes at gmail.com writes: On Mon, Jun 29, 2015 at 10:11 AM, Carl Eugen Hoyos wrote: Hi! I finally found an issue that is fixed with the new asf demuxer: Video in http://samples.ffmpeg.org/V-codecs/MSS1/GipsyGuitar.wmv freezes for ten seconds after 110 seconds, this does not happen with -f asf_o. Attached patch fixes this issue, fate passes, no other sample tested with the patch applied. The patch was merged by Michael- Just on code quality alone, I think it would be much more productive if you look for the opposite and fix those. Trying to juke the stats after-the-fact by fixing the old one now is not going to change anything. :p I don't understand: Do you mean that in your tests, the new demuxer is usable and has advantages over the existing one? If yes, please share (some of) your samples, they must be much better than the ones I found;-( Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
