Re: [FFmpeg-devel] [PATCH]lavf/mxfdec: Allow MXF parser to identify the Canon XF-HEVC codec/format for video essence

2019-03-08 Thread Tomas Härdin
ons 2019-03-06 klockan 15:05 +0100 skrev Carl Eugen Hoyos:
> 2019-03-06 14:38 GMT+01:00, Tomas Härdin :
> 
> > I have generated new samples, sourced with test pattern,
> > some as short as 1 second, about 1.2 megabytes per file.
> > If real-life clips are required, or if the expectation is for me
> > to perform the FATE tests, let me know.
> 
> Could this get committed without fate test first, and we can
> discuss later if they are really required?
> 
> (Assuming there is no "parsing" involved, just a new UL which
> reminds me you could remove the word parser from the
> commit message.)

Pushed the first patch. Creating a new thread for FATE discussions.

/Tomas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH]lavf/mxfdec: Allow MXF parser to identify the Canon XF-HEVC codec/format for video essence

2019-03-06 Thread Tomas Härdin
ons 2019-03-06 klockan 15:05 +0100 skrev Carl Eugen Hoyos:
> > 2019-03-06 14:38 GMT+01:00, Tomas Härdin :
> 
> > I have generated new samples, sourced with test pattern,
> > some as short as 1 second, about 1.2 megabytes per file.
> > If real-life clips are required, or if the expectation is for me
> > to perform the FATE tests, let me know.
> 
> Could this get committed without fate test first, and we can
> discuss later if they are really required?

Sure. We can wait a day or two for more feedback then push the first
patch. Maybe Baptiste wants to chime in

/Tomas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH]lavf/mxfdec: Allow MXF parser to identify the Canon XF-HEVC codec/format for video essence

2019-03-06 Thread Carl Eugen Hoyos
2019-03-06 14:38 GMT+01:00, Tomas Härdin :

> I have generated new samples, sourced with test pattern,
> some as short as 1 second, about 1.2 megabytes per file.
> If real-life clips are required, or if the expectation is for me
> to perform the FATE tests, let me know.

Could this get committed without fate test first, and we can
discuss later if they are really required?

(Assuming there is no "parsing" involved, just a new UL which
reminds me you could remove the word parser from the
commit message.)

Thank you, Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH]lavf/mxfdec: Allow MXF parser to identify the Canon XF-HEVC codec/format for video essence

2019-03-04 Thread Tomas Härdin
sön 2019-03-03 klockan 21:59 -0500 skrev Matthew McKenna:
> Hello ffmpeg-devel:
> 
> Attached is a patch to allow the MXF parser to identify the Canon 
> XF-HEVC codec for video essence.
> 
> This codec/containerization is found in the Canon XF-705 camera that 
> Canon released in 2018.  The camera can encode video using HEVC at 
> either a 110 or 160 Mbps bitrate, and the video is 3840x2160, YCC 4:2:2 
> at 10-bit depth (at a variety of choosable framerates).
> 
> At the moment there is little information published about the 
> containerization of the video, and I am not aware of it being a SMPTE 
> standard or otherwise.  However, by identifying the video as 
> AV_CODEC_ID_HEVC by way of its universal label (UL), ffmpeg can make use 
> of the video.  Bitrate, resolution, color space, framerate, and bit 
> depth all seem to be correctly identified.
> 
> Sample MXF files, as well as their successful conversion thru a patched 
> ffmpeg, are available at 
> http://www.matthewmckenna.com/contrib/ffmpeg/xf-hevc
> 

> +{ {
> 0x06,0x0e,0x2b,0x34,0x04,0x01,0x01,0x0a,0x0e,0x15,0x00,0x04,0x02,0x10
> ,0x00,0x01 }, 14,   AV_CODEC_ID_HEVC, NULL, 15 }, /* Canon XF-
> HEVC */

Got any idea what other ULs there are for this? If not then you should
probably be more strict and pick a matching length of 16 instead of 14.
Especially since you say there is no speficiation for it yet.

/Tomas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel


[FFmpeg-devel] [PATCH]lavf/mxfdec: Allow MXF parser to identify the Canon XF-HEVC codec/format for video essence

2019-03-03 Thread Matthew McKenna

Hello ffmpeg-devel:

Attached is a patch to allow the MXF parser to identify the Canon 
XF-HEVC codec for video essence.


This codec/containerization is found in the Canon XF-705 camera that 
Canon released in 2018.  The camera can encode video using HEVC at 
either a 110 or 160 Mbps bitrate, and the video is 3840x2160, YCC 4:2:2 
at 10-bit depth (at a variety of choosable framerates).


At the moment there is little information published about the 
containerization of the video, and I am not aware of it being a SMPTE 
standard or otherwise.  However, by identifying the video as 
AV_CODEC_ID_HEVC by way of its universal label (UL), ffmpeg can make use 
of the video.  Bitrate, resolution, color space, framerate, and bit 
depth all seem to be correctly identified.


Sample MXF files, as well as their successful conversion thru a patched 
ffmpeg, are available at 
http://www.matthewmckenna.com/contrib/ffmpeg/xf-hevc


Thanks.
-Matthew McKenna

From 9f594113473f80c997e8d00855bf62015136cfa6 Mon Sep 17 00:00:00 2001
From: Matthew McKenna 
Date: Sat, 2 Mar 2019 12:09:25 -0500
Subject: [PATCH]lavf/mxfdec: Add the Canon XF-HEVC UL to the picture essence 
container UL list
 list

---
 libavformat/mxfdec.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
index 0553adcb06..0367e4e41e 100644
--- a/libavformat/mxfdec.c
+++ b/libavformat/mxfdec.c
@@ -1328,6 +1328,7 @@ static const MXFCodecUL 
mxf_picture_essence_container_uls[] = {
 { { 
0x06,0x0e,0x2b,0x34,0x04,0x01,0x01,0x01,0x0d,0x01,0x03,0x01,0x02,0x05,0x00,0x00 
}, 14,   AV_CODEC_ID_RAWVIDEO, NULL, 15, RawVWrap }, /* uncompressed picture */
 { { 
0x06,0x0e,0x2b,0x34,0x04,0x01,0x01,0x0a,0x0e,0x0f,0x03,0x01,0x02,0x20,0x01,0x01 
}, 15, AV_CODEC_ID_HQ_HQA },
 { { 
0x06,0x0e,0x2b,0x34,0x04,0x01,0x01,0x0a,0x0e,0x0f,0x03,0x01,0x02,0x20,0x02,0x01 
}, 15,AV_CODEC_ID_HQX },
+{ { 
0x06,0x0e,0x2b,0x34,0x04,0x01,0x01,0x0a,0x0e,0x15,0x00,0x04,0x02,0x10,0x00,0x01 
}, 14,   AV_CODEC_ID_HEVC, NULL, 15 }, /* Canon XF-HEVC */
 { { 
0x06,0x0e,0x2b,0x34,0x01,0x01,0x01,0xff,0x4b,0x46,0x41,0x41,0x00,0x0d,0x4d,0x4f 
}, 14,   AV_CODEC_ID_RAWVIDEO }, /* Legacy ?? Uncompressed Picture */
 { { 
0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00,0x00 
},  0,  AV_CODEC_ID_NONE },
 };
-- 
2.17.0

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel