Re: [FFmpeg-devel] [PATCH 02/11] avdevice/pulse_audio_common: add av_warn_unused_result

2015-10-22 Thread Ganesh Ajjanagadde 
On Sat, Oct 17, 2015 at 12:45 PM, Ganesh Ajjanagadde  wrote:
> On Sat, Oct 17, 2015 at 12:36 PM, Michael Niedermayer
>  wrote:
>> On Thu, Oct 15, 2015 at 10:22:16PM -0400, Ganesh Ajjanagadde wrote:
>>> This does not trigger any warnings, but adds robustness.
>>>
>>> Signed-off-by: Ganesh Ajjanagadde 
>>> ---
>>>  libavdevice/pulse_audio_common.h | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/libavdevice/pulse_audio_common.h 
>>> b/libavdevice/pulse_audio_common.h
>>> index 02534f7..902795e 100644
>>> --- a/libavdevice/pulse_audio_common.h
>>> +++ b/libavdevice/pulse_audio_common.h
>>> @@ -28,8 +28,10 @@
>>>
>>>  pa_sample_format_t ff_codec_id_to_pulse_format(enum AVCodecID codec_id);
>>>
>>> +av_warn_unused_result
>>>  int ff_pulse_audio_get_devices(AVDeviceInfoList *devices, const char 
>>> *server, int output);
>>>
>>> +av_warn_unused_result
>>>  int ff_pulse_audio_connect_context(pa_mainloop **pa_ml, pa_context 
>>> **pa_ctx,
>>> const char *server, const char 
>>> *description);
>>
>> iam not the maintainer of this but the changes look reasonable
>
> will wait for 48 hours, then push if no one responds.

pushed, thanks.

>
>>
>>
>> [...]
>> --
>> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>>
>> Democracy is the form of government in which you can choose your dictator
>>
>> ___
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 02/11] avdevice/pulse_audio_common: add av_warn_unused_result

2015-10-17 Thread Ganesh Ajjanagadde 
On Sat, Oct 17, 2015 at 12:36 PM, Michael Niedermayer
 wrote:
> On Thu, Oct 15, 2015 at 10:22:16PM -0400, Ganesh Ajjanagadde wrote:
>> This does not trigger any warnings, but adds robustness.
>>
>> Signed-off-by: Ganesh Ajjanagadde 
>> ---
>>  libavdevice/pulse_audio_common.h | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/libavdevice/pulse_audio_common.h 
>> b/libavdevice/pulse_audio_common.h
>> index 02534f7..902795e 100644
>> --- a/libavdevice/pulse_audio_common.h
>> +++ b/libavdevice/pulse_audio_common.h
>> @@ -28,8 +28,10 @@
>>
>>  pa_sample_format_t ff_codec_id_to_pulse_format(enum AVCodecID codec_id);
>>
>> +av_warn_unused_result
>>  int ff_pulse_audio_get_devices(AVDeviceInfoList *devices, const char 
>> *server, int output);
>>
>> +av_warn_unused_result
>>  int ff_pulse_audio_connect_context(pa_mainloop **pa_ml, pa_context **pa_ctx,
>> const char *server, const char 
>> *description);
>
> iam not the maintainer of this but the changes look reasonable

will wait for 48 hours, then push if no one responds.

>
>
> [...]
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Democracy is the form of government in which you can choose your dictator
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 02/11] avdevice/pulse_audio_common: add av_warn_unused_result

2015-10-17 Thread Michael Niedermayer 
On Thu, Oct 15, 2015 at 10:22:16PM -0400, Ganesh Ajjanagadde wrote:
> This does not trigger any warnings, but adds robustness.
> 
> Signed-off-by: Ganesh Ajjanagadde 
> ---
>  libavdevice/pulse_audio_common.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libavdevice/pulse_audio_common.h 
> b/libavdevice/pulse_audio_common.h
> index 02534f7..902795e 100644
> --- a/libavdevice/pulse_audio_common.h
> +++ b/libavdevice/pulse_audio_common.h
> @@ -28,8 +28,10 @@
>  
>  pa_sample_format_t ff_codec_id_to_pulse_format(enum AVCodecID codec_id);
>  
> +av_warn_unused_result
>  int ff_pulse_audio_get_devices(AVDeviceInfoList *devices, const char 
> *server, int output);
>  
> +av_warn_unused_result
>  int ff_pulse_audio_connect_context(pa_mainloop **pa_ml, pa_context **pa_ctx,
> const char *server, const char 
> *description);

iam not the maintainer of this but the changes look reasonable


[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 02/11] avdevice/pulse_audio_common: add av_warn_unused_result

2015-10-15 Thread Ganesh Ajjanagadde 
This does not trigger any warnings, but adds robustness.

Signed-off-by: Ganesh Ajjanagadde 
---
 libavdevice/pulse_audio_common.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavdevice/pulse_audio_common.h b/libavdevice/pulse_audio_common.h
index 02534f7..902795e 100644
--- a/libavdevice/pulse_audio_common.h
+++ b/libavdevice/pulse_audio_common.h
@@ -28,8 +28,10 @@
 
 pa_sample_format_t ff_codec_id_to_pulse_format(enum AVCodecID codec_id);
 
+av_warn_unused_result
 int ff_pulse_audio_get_devices(AVDeviceInfoList *devices, const char *server, 
int output);
 
+av_warn_unused_result
 int ff_pulse_audio_connect_context(pa_mainloop **pa_ml, pa_context **pa_ctx,
const char *server, const char 
*description);
 
-- 
2.6.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel