Re: [FFmpeg-devel] [PATCH 04/11] avdevice/alsa: add av_warn_unused_result

[Nicolas George]

Le quartidi 24 vendémiaire, an CCXXIV, Ganesh Ajjanagadde a écrit :
> This does not trigger any warnings, but adds robustness.
> 
> Signed-off-by: Ganesh Ajjanagadde 
> ---
>  libavdevice/alsa.h | 4 
>  1 file changed, 4 insertions(+)

Ok for me.

(I suppose I de-facto maintain ALSA for our side, unless I forgot someone.)

Regards,

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 04/11] avdevice/alsa: add av_warn_unused_result

[Ganesh Ajjanagadde]

On Fri, Oct 16, 2015 at 7:30 AM, Nicolas George  wrote:
> Le quartidi 24 vendémiaire, an CCXXIV, Ganesh Ajjanagadde a écrit :
>> This does not trigger any warnings, but adds robustness.
>>
>> Signed-off-by: Ganesh Ajjanagadde 
>> ---
>>  libavdevice/alsa.h | 4 
>>  1 file changed, 4 insertions(+)
>
> Ok for me.
>
> (I suppose I de-facto maintain ALSA for our side, unless I forgot someone.)

pushed, thanks.

>
> Regards,
>
> --
>   Nicolas George
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 04/11] avdevice/alsa: add av_warn_unused_result

[Ganesh Ajjanagadde]

This does not trigger any warnings, but adds robustness.

Signed-off-by: Ganesh Ajjanagadde 
---
 libavdevice/alsa.h | 4 
 1 file changed, 4 insertions(+)

diff --git a/libavdevice/alsa.h b/libavdevice/alsa.h
index f8b7449..cd41d96 100644
--- a/libavdevice/alsa.h
+++ b/libavdevice/alsa.h
@@ -74,6 +74,7 @@ typedef struct AlsaData {
  *
  * @return 0 if OK, AVERROR_xxx on error
  */
+av_warn_unused_result
 int ff_alsa_open(AVFormatContext *s, snd_pcm_stream_t mode,
  unsigned int *sample_rate,
  int channels, enum AVCodecID *codec_id);
@@ -95,10 +96,13 @@ int ff_alsa_close(AVFormatContext *s1);
  *
  * @return 0 if OK, AVERROR_xxx on error
  */
+av_warn_unused_result
 int ff_alsa_xrun_recover(AVFormatContext *s1, int err);
 
+av_warn_unused_result
 int ff_alsa_extend_reorder_buf(AlsaData *s, int size);
 
+av_warn_unused_result
 int ff_alsa_get_device_list(AVDeviceInfoList *device_list, snd_pcm_stream_t 
stream_type);
 
 #endif /* AVDEVICE_ALSA_H */
-- 
2.6.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel