Re: [FFmpeg-devel] [PATCH 1/2] avcodec: fix whitespace on AVPanScan struct definition

2017-11-14 Thread Aman Gupta 
On Tue, Nov 14, 2017 at 10:23 AM, James Almer  wrote:

> On 11/14/2017 3:04 PM, Aman Gupta wrote:
> > From: Aman Gupta 
> >
> > ---
> >  libavcodec/avcodec.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> > index 74b097cdd8..0875ae3ba0 100644
> > --- a/libavcodec/avcodec.h
> > +++ b/libavcodec/avcodec.h
> > @@ -1049,7 +1049,7 @@ typedef struct RcOverride{
> >   * This specifies the area which should be displayed.
> >   * Note there may be multiple such areas for one frame.
> >   */
> > -typedef struct AVPanScan{
> > +typedef struct AVPanScan {
> >  /**
> >   * id
> >   * - encoding: Set by user.
> > @@ -1071,7 +1071,7 @@ typedef struct AVPanScan{
> >   * - decoding: Set by libavcodec.
> >   */
> >  int16_t position[3][2];
> > -}AVPanScan;
> > +} AVPanScan;
>
> LGTM, but minimal cosmetic changes like this don't need a patch if you
> have push rights.
>

Ah, I did not know that. Will push, thanks!

Aman


>
> >
> >  /**
> >   * This structure describes the bitrate properties of an encoded
> bitstream. It
> >
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: fix whitespace on AVPanScan struct definition

2017-11-14 Thread James Almer 
On 11/14/2017 3:04 PM, Aman Gupta wrote:
> From: Aman Gupta 
> 
> ---
>  libavcodec/avcodec.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index 74b097cdd8..0875ae3ba0 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -1049,7 +1049,7 @@ typedef struct RcOverride{
>   * This specifies the area which should be displayed.
>   * Note there may be multiple such areas for one frame.
>   */
> -typedef struct AVPanScan{
> +typedef struct AVPanScan {
>  /**
>   * id
>   * - encoding: Set by user.
> @@ -1071,7 +1071,7 @@ typedef struct AVPanScan{
>   * - decoding: Set by libavcodec.
>   */
>  int16_t position[3][2];
> -}AVPanScan;
> +} AVPanScan;

LGTM, but minimal cosmetic changes like this don't need a patch if you
have push rights.

>  
>  /**
>   * This structure describes the bitrate properties of an encoded bitstream. 
> It
> 

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 1/2] avcodec: fix whitespace on AVPanScan struct definition

2017-11-14 Thread Aman Gupta 
From: Aman Gupta 

---
 libavcodec/avcodec.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index 74b097cdd8..0875ae3ba0 100644
--- a/libavcodec/avcodec.h
+++ b/libavcodec/avcodec.h
@@ -1049,7 +1049,7 @@ typedef struct RcOverride{
  * This specifies the area which should be displayed.
  * Note there may be multiple such areas for one frame.
  */
-typedef struct AVPanScan{
+typedef struct AVPanScan {
 /**
  * id
  * - encoding: Set by user.
@@ -1071,7 +1071,7 @@ typedef struct AVPanScan{
  * - decoding: Set by libavcodec.
  */
 int16_t position[3][2];
-}AVPanScan;
+} AVPanScan;
 
 /**
  * This structure describes the bitrate properties of an encoded bitstream. It
-- 
2.14.2

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel