Re: [FFmpeg-devel] [PATCH 1/2] avformat/movenc: Check av_malloc()

[Michael Niedermayer]

On Thu, May 02, 2024 at 11:34:15PM +0200, Andreas Rheinhardt wrote:
> Fixes Coverity issue #1596735.
> 
> Signed-off-by: Andreas Rheinhardt 
> ---
>  libavformat/movenc.c | 2 ++
>  1 file changed, 2 insertions(+)

LGTM

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 1/2] avformat/movenc: Check av_malloc()

[Andreas Rheinhardt]

Fixes Coverity issue #1596735.

Signed-off-by: Andreas Rheinhardt 
---
 libavformat/movenc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index e9bbfd67cf..b4c1db2774 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -1221,6 +1221,8 @@ static int mov_write_chnl_tag(AVFormatContext *s, 
AVIOContext *pb, MOVTrack *tra
 if (ret || !config) {
 config = 0;
 speaker_pos = av_malloc(layout->nb_channels);
+if (!speaker_pos)
+return AVERROR(ENOMEM);
 ret = ff_mov_get_channel_positions_from_layout(layout,
 speaker_pos, layout->nb_channels);
 if (ret) {
-- 
2.40.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".