Re: [FFmpeg-devel] [PATCH 1/2] ffplay: create the window and the renderer before starting playback

2017-11-04 Thread Marton Balint 



On Sun, 29 Oct 2017, Marton Balint wrote:




On Sat, 28 Oct 2017, Clément Bœsch wrote:


On Sat, Oct 28, 2017 at 11:05:15PM +0200, Marton Balint wrote:

Signed-off-by: Marton Balint 
---
 fftools/ffplay.c | 67 

+---

 1 file changed, 35 insertions(+), 32 deletions(-)



Won't this prevent using ffplay without a display? Think of playing audio
with ffplay on a headless machine (no display server).


No, for that, the user have to use -nodisp, and it should work the 
same way as before, because the window/renderer creating code is in an if 
(!display_disable) {...} block.


Applied the series.

Regards,
Marton
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] ffplay: create the window and the renderer before starting playback

2017-10-28 Thread Marton Balint 



On Sat, 28 Oct 2017, Clément Bœsch wrote:


On Sat, Oct 28, 2017 at 11:05:15PM +0200, Marton Balint wrote:

Signed-off-by: Marton Balint 
---
 fftools/ffplay.c | 67 +---
 1 file changed, 35 insertions(+), 32 deletions(-)



Won't this prevent using ffplay without a display? Think of playing audio
with ffplay on a headless machine (no display server).


No, for that, the user have to use -nodisp, and it should work the 
same way as before, because the window/renderer creating code is in an if 
(!display_disable) {...} block.


Regards,
Marton
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] ffplay: create the window and the renderer before starting playback

2017-10-28 Thread Clément Bœsch 
On Sat, Oct 28, 2017 at 11:05:15PM +0200, Marton Balint wrote:
> Signed-off-by: Marton Balint 
> ---
>  fftools/ffplay.c | 67 
> +---
>  1 file changed, 35 insertions(+), 32 deletions(-)
> 

Won't this prevent using ffplay without a display? Think of playing audio
with ffplay on a headless machine (no display server).

[...]

-- 
Clément B.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel