Re: [FFmpeg-devel] [PATCH 1/3] avformat/ilbc: Don't reimplement ff_raw_write_packet

2020-04-03 Thread Michael Niedermayer
On Thu, Apr 02, 2020 at 07:17:38PM +0200, Andreas Rheinhardt wrote:
> Signed-off-by: Andreas Rheinhardt 
> ---
>  libavformat/ilbc.c | 9 ++---
>  1 file changed, 2 insertions(+), 7 deletions(-)

LGTM

thx

[...]

-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 1/3] avformat/ilbc: Don't reimplement ff_raw_write_packet

2020-04-02 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt 
---
 libavformat/ilbc.c | 9 ++---
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/libavformat/ilbc.c b/libavformat/ilbc.c
index d41027174d..c778f5a5af 100644
--- a/libavformat/ilbc.c
+++ b/libavformat/ilbc.c
@@ -21,6 +21,7 @@
 
 #include "avformat.h"
 #include "internal.h"
+#include "rawenc.h"
 
 static const char mode20_header[] = "#!iLBC20\n";
 static const char mode30_header[] = "#!iLBC30\n";
@@ -52,12 +53,6 @@ static int ilbc_write_header(AVFormatContext *s)
 return 0;
 }
 
-static int ilbc_write_packet(AVFormatContext *s, AVPacket *pkt)
-{
-avio_write(s->pb, pkt->data, pkt->size);
-return 0;
-}
-
 static int ilbc_probe(const AVProbeData *p)
 {
 // Only check for "#!iLBC" which matches both formats
@@ -133,6 +128,6 @@ AVOutputFormat ff_ilbc_muxer = {
 .extensions   = "lbc",
 .audio_codec  = AV_CODEC_ID_ILBC,
 .write_header = ilbc_write_header,
-.write_packet = ilbc_write_packet,
+.write_packet = ff_raw_write_packet,
 .flags= AVFMT_NOTIMESTAMPS,
 };
-- 
2.20.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".