Re: [FFmpeg-devel] [PATCH 1/3] common.mak: Use CCFLAGS for assembly generation as well

2016-01-24 Thread Timothy Gu
On Tue, Dec 01, 2015 at 09:46:04PM -0800, Timothy Gu wrote:
> CCFLAGS is equivalent to CPPFLAGS + CFLAGS.
> ---
>  common.mak | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Set pushed (some with improved commit messages).

[...]

Timothy
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH 1/3] common.mak: Use CCFLAGS for assembly generation as well

2015-12-02 Thread Michael Niedermayer
On Tue, Dec 01, 2015 at 09:46:04PM -0800, Timothy Gu wrote:
> CCFLAGS is equivalent to CPPFLAGS + CFLAGS.
> ---
>  common.mak | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

does this fix any case or just simplifies common.mak ?

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


Re: [FFmpeg-devel] [PATCH 1/3] common.mak: Use CCFLAGS for assembly generation as well

2015-12-02 Thread Timothy Gu
On Wed, Dec 02, 2015 at 08:03:33PM +0100, Michael Niedermayer wrote:
> On Tue, Dec 01, 2015 at 09:46:04PM -0800, Timothy Gu wrote:
> > CCFLAGS is equivalent to CPPFLAGS + CFLAGS.
> > ---
> >  common.mak | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> does this fix any case or just simplifies common.mak ?
> 

It just simplifies it. I'll amend the commit message.

Timothy
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


[FFmpeg-devel] [PATCH 1/3] common.mak: Use CCFLAGS for assembly generation as well

2015-12-01 Thread Timothy Gu
CCFLAGS is equivalent to CPPFLAGS + CFLAGS.
---
 common.mak | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common.mak b/common.mak
index d611ef8..05836ba 100644
--- a/common.mak
+++ b/common.mak
@@ -63,7 +63,7 @@ COMPILE_HOSTC = $(call COMPILE,HOSTCC)
$(COMPILE_C)
 
 %.s: %.c
-   $(CC) $(CPPFLAGS) $(CFLAGS) -S -o $@ $<
+   $(CC) $(CCFLAGS) -S -o $@ $<
 
 %.o: %.S
$(COMPILE_S)
-- 
2.1.4

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel