Re: [FFmpeg-devel] [PATCH 1/3] libvpxenc: only set noise reduction w/vp8

2015-04-24 Thread James Zern 
On Thu, Apr 23, 2015 at 8:14 AM, Michael Niedermayer  wrote:
> On Wed, Apr 22, 2015 at 08:58:35PM -0700, James Zern wrote:
>> this quiets a warning:
>> Failed to set VP8E_SET_NOISE_SENSITIVITY codec control: Unspecified
>> internal error
>> ---
>>  libavcodec/libvpxenc.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> LGTM
>

applied

> thx
>
> [...]
> --
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> There will always be a question for which you do not know the correct answer.
>
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] libvpxenc: only set noise reduction w/vp8

2015-04-23 Thread Michael Niedermayer 
On Wed, Apr 22, 2015 at 08:58:35PM -0700, James Zern wrote:
> this quiets a warning:
> Failed to set VP8E_SET_NOISE_SENSITIVITY codec control: Unspecified
> internal error
> ---
>  libavcodec/libvpxenc.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

LGTM

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct answer.


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 1/3] libvpxenc: only set noise reduction w/vp8

2015-04-22 Thread James Zern 
this quiets a warning:
Failed to set VP8E_SET_NOISE_SENSITIVITY codec control: Unspecified
internal error
---
 libavcodec/libvpxenc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c
index 2104876..159fbdd 100644
--- a/libavcodec/libvpxenc.c
+++ b/libavcodec/libvpxenc.c
@@ -525,9 +525,10 @@ static av_cold int vpx_init(AVCodecContext *avctx,
 codecctl_int(avctx, VP8E_SET_ARNR_STRENGTH,ctx->arnr_strength);
 if (ctx->arnr_type >= 0)
 codecctl_int(avctx, VP8E_SET_ARNR_TYPE,ctx->arnr_type);
-codecctl_int(avctx, VP8E_SET_NOISE_SENSITIVITY, avctx->noise_reduction);
-if (avctx->codec_id == AV_CODEC_ID_VP8)
+if (avctx->codec_id == AV_CODEC_ID_VP8) {
+codecctl_int(avctx, VP8E_SET_NOISE_SENSITIVITY, 
avctx->noise_reduction);
 codecctl_int(avctx, VP8E_SET_TOKEN_PARTITIONS,  
av_log2(avctx->slices));
+}
 #if FF_API_MPV_OPT
 FF_DISABLE_DEPRECATION_WARNINGS
 if (avctx->mb_threshold) {
-- 
2.2.0.rc0.207.ga3a616c

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel