[FFmpeg-devel] [PATCH 1/3] x86/constants: extend pw_128 to 256 bits

2016-02-08 Thread Timothy Gu 
---
 libavcodec/x86/constants.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libavcodec/x86/constants.c b/libavcodec/x86/constants.c
index 11002ee..c2d3bb8 100644
--- a/libavcodec/x86/constants.c
+++ b/libavcodec/x86/constants.c
@@ -42,7 +42,8 @@ DECLARE_ALIGNED(8,  const uint64_t, ff_pw_42)   =   
0x002A002A002A002AULL;
 DECLARE_ALIGNED(8,  const uint64_t, ff_pw_53)   =   0x0035003500350035ULL;
 DECLARE_ALIGNED(16, const xmm_reg,  ff_pw_64)   = { 0x0040004000400040ULL, 
0x0040004000400040ULL };
 DECLARE_ALIGNED(8,  const uint64_t, ff_pw_96)   =   0x0060006000600060ULL;
-DECLARE_ALIGNED(8,  const uint64_t, ff_pw_128)  =   0x0080008000800080ULL;
+DECLARE_ALIGNED(32, const ymm_reg,  ff_pw_128)  = { 0x0080008000800080ULL, 
0x0080008000800080ULL,
+0x0080008000800080ULL, 
0x0080008000800080ULL };
 DECLARE_ALIGNED(32, const ymm_reg,  ff_pw_255)  = { 0x00ff00ff00ff00ffULL, 
0x00ff00ff00ff00ffULL,
 0x00ff00ff00ff00ffULL, 
0x00ff00ff00ff00ffULL };
 DECLARE_ALIGNED(32, const ymm_reg,  ff_pw_256)  = { 0x0100010001000100ULL, 
0x0100010001000100ULL,
-- 
1.9.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 1/3] x86/constants: extend pw_128 to 256 bits

2016-02-08 Thread Timothy Gu 
---
 libavcodec/x86/constants.c | 3 ++-
 libavcodec/x86/constants.h | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/libavcodec/x86/constants.c b/libavcodec/x86/constants.c
index 11002ee..c2d3bb8 100644
--- a/libavcodec/x86/constants.c
+++ b/libavcodec/x86/constants.c
@@ -42,7 +42,8 @@ DECLARE_ALIGNED(8,  const uint64_t, ff_pw_42)   =   
0x002A002A002A002AULL;
 DECLARE_ALIGNED(8,  const uint64_t, ff_pw_53)   =   0x0035003500350035ULL;
 DECLARE_ALIGNED(16, const xmm_reg,  ff_pw_64)   = { 0x0040004000400040ULL, 
0x0040004000400040ULL };
 DECLARE_ALIGNED(8,  const uint64_t, ff_pw_96)   =   0x0060006000600060ULL;
-DECLARE_ALIGNED(8,  const uint64_t, ff_pw_128)  =   0x0080008000800080ULL;
+DECLARE_ALIGNED(32, const ymm_reg,  ff_pw_128)  = { 0x0080008000800080ULL, 
0x0080008000800080ULL,
+0x0080008000800080ULL, 
0x0080008000800080ULL };
 DECLARE_ALIGNED(32, const ymm_reg,  ff_pw_255)  = { 0x00ff00ff00ff00ffULL, 
0x00ff00ff00ff00ffULL,
 0x00ff00ff00ff00ffULL, 
0x00ff00ff00ff00ffULL };
 DECLARE_ALIGNED(32, const ymm_reg,  ff_pw_256)  = { 0x0100010001000100ULL, 
0x0100010001000100ULL,
diff --git a/libavcodec/x86/constants.h b/libavcodec/x86/constants.h
index b82aef9..90d53ba 100644
--- a/libavcodec/x86/constants.h
+++ b/libavcodec/x86/constants.h
@@ -41,7 +41,7 @@ extern const uint64_t ff_pw_42;
 extern const uint64_t ff_pw_53;
 extern const xmm_reg  ff_pw_64;
 extern const uint64_t ff_pw_96;
-extern const uint64_t ff_pw_128;
+extern const ymm_reg  ff_pw_128;
 extern const ymm_reg  ff_pw_255;
 extern const ymm_reg  ff_pw_512;
 extern const ymm_reg  ff_pw_1023;
-- 
1.9.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] x86/constants: extend pw_128 to 256 bits

2016-02-27 Thread Michael Niedermayer 
On Mon, Feb 08, 2016 at 11:27:51AM -0800, Timothy Gu wrote:
> ---
>  libavcodec/x86/constants.c | 3 ++-
>  libavcodec/x86/constants.h | 2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)

LGTM if these are or will be used

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] x86/constants: extend pw_128 to 256 bits

2016-02-27 Thread James Almer 
On 2/28/2016 12:43 AM, Michael Niedermayer wrote:
> On Mon, Feb 08, 2016 at 11:27:51AM -0800, Timothy Gu wrote:
>> ---
>>  libavcodec/x86/constants.c | 3 ++-
>>  libavcodec/x86/constants.h | 2 +-
>>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> LGTM if these are or will be used
> 
> thx

Not by this patchset. Nothing in avcodec needs it this wide for now.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel