Re: [FFmpeg-devel] [PATCH 1/4] lavu: Remove libva 1.x support

2024-04-03 Thread Michael Niedermayer 
On Wed, Apr 03, 2024 at 08:44:29PM +0100, Mark Thompson wrote:
> libva 2.0 was released in 2017 and the 2.x versions are included in all
> supported distributions nowadays.

on ubuntu mingw

make
CC  libavdevice/version.o
AR  libavdevice/libavdevice.a
CC  libavfilter/vaapi_vpp.o
In file included from src/libavfilter/vaapi_vpp.c:26:0:
src/libavfilter/vaapi_vpp.h:22:10: fatal error: va/va.h: No such file or 
directory
 #include 
  ^
compilation terminated.
src/ffbuild/common.mak:81: recipe for target 'libavfilter/vaapi_vpp.o' failed
make: *** [libavfilter/vaapi_vpp.o] Error 1

thx

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/4] lavu: Remove libva 1.x support

2024-04-03 Thread Mark Thompson 

On 03/04/2024 21:09, Rémi Denis-Courmont wrote:

Le keskiviikkona 3. huhtikuuta 2024, 22.44.29 EEST Mark Thompson a écrit :

libva 2.0 was released in 2017 and the 2.x versions are included in all
supported distributions nowadays.
---
   libavutil/hwcontext_vaapi.c | 4 
   1 file changed, 4 deletions(-)

diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c
index 56d03aa4cd..bc82ab31e6 100644
--- a/libavutil/hwcontext_vaapi.c
+++ b/libavutil/hwcontext_vaapi.c
@@ -1637,7 +1637,6 @@ static void vaapi_device_free(AVHWDeviceContext *ctx)
   av_freep();
   }

-#if CONFIG_VAAPI_1


IMO, it wouldn't hurt to clarify in the change description that CONFIG_VAAPI_1
actually corresponded to libva 2.x. No objections to the code changes though.


Fair, the library major version being the API major version plus one is a 
slightly bizarre feature.  I've added some words to that effect locally.

Thanks,

- Mark
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/4] lavu: Remove libva 1.x support

2024-04-03 Thread Rémi Denis-Courmont 
Le keskiviikkona 3. huhtikuuta 2024, 22.44.29 EEST Mark Thompson a écrit :
> libva 2.0 was released in 2017 and the 2.x versions are included in all
> supported distributions nowadays.
> ---
>   libavutil/hwcontext_vaapi.c | 4 
>   1 file changed, 4 deletions(-)
> 
> diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c
> index 56d03aa4cd..bc82ab31e6 100644
> --- a/libavutil/hwcontext_vaapi.c
> +++ b/libavutil/hwcontext_vaapi.c
> @@ -1637,7 +1637,6 @@ static void vaapi_device_free(AVHWDeviceContext *ctx)
>   av_freep();
>   }
> 
> -#if CONFIG_VAAPI_1

IMO, it wouldn't hurt to clarify in the change description that CONFIG_VAAPI_1 
actually corresponded to libva 2.x. No objections to the code changes though.


-- 
レミ・デニ-クールモン
http://www.remlab.net/



___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 1/4] lavu: Remove libva 1.x support

2024-04-03 Thread Mark Thompson 

libva 2.0 was released in 2017 and the 2.x versions are included in all
supported distributions nowadays.
---
 libavutil/hwcontext_vaapi.c | 4 
 1 file changed, 4 deletions(-)

diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c
index 56d03aa4cd..bc82ab31e6 100644
--- a/libavutil/hwcontext_vaapi.c
+++ b/libavutil/hwcontext_vaapi.c
@@ -1637,7 +1637,6 @@ static void vaapi_device_free(AVHWDeviceContext *ctx)
 av_freep();
 }

-#if CONFIG_VAAPI_1
 static void vaapi_device_log_error(void *context, const char *message)
 {
 AVHWDeviceContext *ctx = context;
@@ -1651,7 +1650,6 @@ static void vaapi_device_log_info(void *context, const 
char *message)

 av_log(ctx, AV_LOG_VERBOSE, "libva: %s", message);
 }
-#endif

 static int vaapi_device_connect(AVHWDeviceContext *ctx,
 VADisplay display)
@@ -1660,10 +1658,8 @@ static int vaapi_device_connect(AVHWDeviceContext *ctx,
 int major, minor;
 VAStatus vas;

-#if CONFIG_VAAPI_1
 vaSetErrorCallback(display, _device_log_error, ctx);
 vaSetInfoCallback (display, _device_log_info,  ctx);
-#endif

 hwctx->display = display;

--
2.43.0
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".