Re: [FFmpeg-devel] [PATCH 17/40] avcodec/alacenc: Remove redundant code to free extradata

2020-09-14 Thread Paul B Mahol
On Mon, Sep 14, 2020 at 07:27:24AM +0200, Andreas Rheinhardt wrote:
> It is already freed generically for encoders.
> 
> Signed-off-by: Andreas Rheinhardt 
> ---
>  libavcodec/alacenc.c | 2 --
>  1 file changed, 2 deletions(-)

lgtm

> 
> diff --git a/libavcodec/alacenc.c b/libavcodec/alacenc.c
> index 804cc7b17b..fc5fa270e6 100644
> --- a/libavcodec/alacenc.c
> +++ b/libavcodec/alacenc.c
> @@ -498,8 +498,6 @@ static av_cold int alac_encode_close(AVCodecContext 
> *avctx)
>  {
>  AlacEncodeContext *s = avctx->priv_data;
>  ff_lpc_end(>lpc_ctx);
> -av_freep(>extradata);
> -avctx->extradata_size = 0;
>  return 0;
>  }
>  
> -- 
> 2.25.1
> 
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 17/40] avcodec/alacenc: Remove redundant code to free extradata

2020-09-13 Thread Andreas Rheinhardt
It is already freed generically for encoders.

Signed-off-by: Andreas Rheinhardt 
---
 libavcodec/alacenc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libavcodec/alacenc.c b/libavcodec/alacenc.c
index 804cc7b17b..fc5fa270e6 100644
--- a/libavcodec/alacenc.c
+++ b/libavcodec/alacenc.c
@@ -498,8 +498,6 @@ static av_cold int alac_encode_close(AVCodecContext *avctx)
 {
 AlacEncodeContext *s = avctx->priv_data;
 ff_lpc_end(>lpc_ctx);
-av_freep(>extradata);
-avctx->extradata_size = 0;
 return 0;
 }
 
-- 
2.25.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".