Re: [FFmpeg-devel] [PATCH 2/2] avformat/dxa: Use av_rescale() for duration computation

2020-09-30 Thread Michael Niedermayer
On Wed, Sep 02, 2020 at 11:39:49PM +0200, Michael Niedermayer wrote:
> Fixes: signed integer overflow: 822400 * 1629552639 cannot be represented 
> in type 'long'
> Fixes: 
> 24908/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-4658478506049536
> 
> Found-by: continuous fuzzing process 
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer 
> ---
>  libavformat/dxa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

will apply

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras


signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/2] avformat/dxa: Use av_rescale() for duration computation

2020-09-02 Thread Michael Niedermayer
Fixes: signed integer overflow: 822400 * 1629552639 cannot be represented 
in type 'long'
Fixes: 
24908/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-4658478506049536

Found-by: continuous fuzzing process 
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer 
---
 libavformat/dxa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/dxa.c b/libavformat/dxa.c
index 27fa6afb6a..909c5ba2ba 100644
--- a/libavformat/dxa.c
+++ b/libavformat/dxa.c
@@ -143,7 +143,7 @@ static int dxa_read_header(AVFormatContext *s)
 c->readvid = !c->has_sound;
 c->vidpos  = avio_tell(pb);
 s->start_time = 0;
-s->duration = (int64_t)c->frames * AV_TIME_BASE * num / den;
+s->duration = av_rescale(c->frames, AV_TIME_BASE * (int64_t)num, den);
 av_log(s, AV_LOG_DEBUG, "%d frame(s)\n",c->frames);
 
 return 0;
-- 
2.17.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".