[FFmpeg-devel] [PATCH 2/2] lavfi/vf_drawtext.c: fix CID 1485003

[Ting Fu]

CID 1485003: Memory - illegal accesses (UNINIT)
Using uninitialized value "sd".

Signed-off-by: Ting Fu 
---
 libavfilter/vf_drawtext.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c
index 382d589e26..c4c09894e4 100644
--- a/libavfilter/vf_drawtext.c
+++ b/libavfilter/vf_drawtext.c
@@ -1554,7 +1554,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame 
*frame)
 AVFrameSideData *sd;
 int loop = 1;
 
-if (s->text_source == AV_FRAME_DATA_DETECTION_BBOXES && sd) {
+if (s->text_source == AV_FRAME_DATA_DETECTION_BBOXES) {
 sd = av_frame_get_side_data(frame, AV_FRAME_DATA_DETECTION_BBOXES);
 if (sd) {
 header = (AVDetectionBBoxHeader *)sd->data;
-- 
2.17.1

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] lavfi/vf_drawtext.c: fix CID 1485003

[Guo, Yejun]

> -Original Message-
> From: ffmpeg-devel  On Behalf Of Ting
> Fu
> Sent: 2021年6月4日 10:23
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH 2/2] lavfi/vf_drawtext.c: fix CID 1485003
> 
> CID 1485003: Memory - illegal accesses (UNINIT)
> Using uninitialized value "sd".
> 
> Signed-off-by: Ting Fu 
> ---
>  libavfilter/vf_drawtext.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c
> index 382d589e26..c4c09894e4 100644
> --- a/libavfilter/vf_drawtext.c
> +++ b/libavfilter/vf_drawtext.c
> @@ -1554,7 +1554,7 @@ static int filter_frame(AVFilterLink *inlink,
> AVFrame *frame)
>  AVFrameSideData *sd;
>  int loop = 1;
> 
> -if (s->text_source == AV_FRAME_DATA_DETECTION_BBOXES && sd) {
> +if (s->text_source == AV_FRAME_DATA_DETECTION_BBOXES) {
>  sd = av_frame_get_side_data(frame,
> AV_FRAME_DATA_DETECTION_BBOXES);
>  if (sd) {
>  header = (AVDetectionBBoxHeader *)sd->data;
> --
thanks, will push soon.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".