Re: [FFmpeg-devel] [PATCH 2/3] lavc: deprecate AV_CODEC_CAP_SUBFRAMES
On 5/9/2023 9:02 AM, Anton Khirnov wrote: Quoting James Almer (2023-05-09 13:56:22) On 5/9/2023 7:30 AM, Anton Khirnov wrote: There is nothing meaningful the caller can do with it. --- libavcodec/alsdec.c | 6 +- libavcodec/apac.c | 6 -- libavcodec/apedec.c | 6 +- libavcodec/atrac3.c | 12 ++-- libavcodec/atrac9dec.c | 6 +- libavcodec/bonk.c | 6 -- libavcodec/codec.h | 3 +++ libavcodec/ftr.c| 6 +- libavcodec/g723_1dec.c | 6 +- libavcodec/g729dec.c| 12 ++-- libavcodec/libspeexdec.c| 6 +- libavcodec/misc4.c | 5 - libavcodec/shorten.c| 6 -- libavcodec/tests/avcodec.c | 3 +-- libavcodec/version_major.h | 1 + libavcodec/wavarc.c | 2 ++ libavcodec/wmalosslessdec.c | 6 +- libavcodec/wmaprodec.c | 18 +++--- libavcodec/wmavoice.c | 6 +- 19 files changed, 98 insertions(+), 24 deletions(-) Missing APIChanges entry. For that matter, when there's no replacement for a deprecated API, and thus there's no point in bumping minor, what should the APIChanges entry point to? Is there a point in having an APIchanges entry when no API actually changed? You have added entries saying "Deprecated X without replacement" before. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH 2/3] lavc: deprecate AV_CODEC_CAP_SUBFRAMES
Quoting James Almer (2023-05-09 13:56:22) > On 5/9/2023 7:30 AM, Anton Khirnov wrote: > > There is nothing meaningful the caller can do with it. > > --- > > libavcodec/alsdec.c | 6 +- > > libavcodec/apac.c | 6 -- > > libavcodec/apedec.c | 6 +- > > libavcodec/atrac3.c | 12 ++-- > > libavcodec/atrac9dec.c | 6 +- > > libavcodec/bonk.c | 6 -- > > libavcodec/codec.h | 3 +++ > > libavcodec/ftr.c| 6 +- > > libavcodec/g723_1dec.c | 6 +- > > libavcodec/g729dec.c| 12 ++-- > > libavcodec/libspeexdec.c| 6 +- > > libavcodec/misc4.c | 5 - > > libavcodec/shorten.c| 6 -- > > libavcodec/tests/avcodec.c | 3 +-- > > libavcodec/version_major.h | 1 + > > libavcodec/wavarc.c | 2 ++ > > libavcodec/wmalosslessdec.c | 6 +- > > libavcodec/wmaprodec.c | 18 +++--- > > libavcodec/wmavoice.c | 6 +- > > 19 files changed, 98 insertions(+), 24 deletions(-) > > Missing APIChanges entry. > > For that matter, when there's no replacement for a deprecated API, and > thus there's no point in bumping minor, what should the APIChanges entry > point to? Is there a point in having an APIchanges entry when no API actually changed? -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Re: [FFmpeg-devel] [PATCH 2/3] lavc: deprecate AV_CODEC_CAP_SUBFRAMES
On 5/9/2023 7:30 AM, Anton Khirnov wrote: There is nothing meaningful the caller can do with it. --- libavcodec/alsdec.c | 6 +- libavcodec/apac.c | 6 -- libavcodec/apedec.c | 6 +- libavcodec/atrac3.c | 12 ++-- libavcodec/atrac9dec.c | 6 +- libavcodec/bonk.c | 6 -- libavcodec/codec.h | 3 +++ libavcodec/ftr.c| 6 +- libavcodec/g723_1dec.c | 6 +- libavcodec/g729dec.c| 12 ++-- libavcodec/libspeexdec.c| 6 +- libavcodec/misc4.c | 5 - libavcodec/shorten.c| 6 -- libavcodec/tests/avcodec.c | 3 +-- libavcodec/version_major.h | 1 + libavcodec/wavarc.c | 2 ++ libavcodec/wmalosslessdec.c | 6 +- libavcodec/wmaprodec.c | 18 +++--- libavcodec/wmavoice.c | 6 +- 19 files changed, 98 insertions(+), 24 deletions(-) Missing APIChanges entry. For that matter, when there's no replacement for a deprecated API, and thus there's no point in bumping minor, what should the APIChanges entry point to? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
[FFmpeg-devel] [PATCH 2/3] lavc: deprecate AV_CODEC_CAP_SUBFRAMES
There is nothing meaningful the caller can do with it.
---
libavcodec/alsdec.c | 6 +-
libavcodec/apac.c | 6 --
libavcodec/apedec.c | 6 +-
libavcodec/atrac3.c | 12 ++--
libavcodec/atrac9dec.c | 6 +-
libavcodec/bonk.c | 6 --
libavcodec/codec.h | 3 +++
libavcodec/ftr.c| 6 +-
libavcodec/g723_1dec.c | 6 +-
libavcodec/g729dec.c| 12 ++--
libavcodec/libspeexdec.c| 6 +-
libavcodec/misc4.c | 5 -
libavcodec/shorten.c| 6 --
libavcodec/tests/avcodec.c | 3 +--
libavcodec/version_major.h | 1 +
libavcodec/wavarc.c | 2 ++
libavcodec/wmalosslessdec.c | 6 +-
libavcodec/wmaprodec.c | 18 +++---
libavcodec/wmavoice.c | 6 +-
19 files changed, 98 insertions(+), 24 deletions(-)
diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c
index 4605b2248f..c64d1032a4 100644
--- a/libavcodec/alsdec.c
+++ b/libavcodec/alsdec.c
@@ -2190,6 +2190,10 @@ const FFCodec ff_als_decoder = {
.close = decode_end,
FF_CODEC_DECODE_CB(decode_frame),
.flush = flush,
-.p.capabilities = AV_CODEC_CAP_SUBFRAMES | AV_CODEC_CAP_DR1 |
AV_CODEC_CAP_CHANNEL_CONF,
+.p.capabilities =
+#if FF_API_SUBFRAMES
+ AV_CODEC_CAP_SUBFRAMES |
+#endif
+ AV_CODEC_CAP_DR1 | AV_CODEC_CAP_CHANNEL_CONF,
.caps_internal = FF_CODEC_CAP_INIT_CLEANUP,
};
diff --git a/libavcodec/apac.c b/libavcodec/apac.c
index 3408f75292..b6cb6c669e 100644
--- a/libavcodec/apac.c
+++ b/libavcodec/apac.c
@@ -269,8 +269,10 @@ const FFCodec ff_apac_decoder = {
FF_CODEC_DECODE_CB(apac_decode),
.close= apac_close,
.p.capabilities = AV_CODEC_CAP_DELAY |
-AV_CODEC_CAP_DR1 |
-AV_CODEC_CAP_SUBFRAMES,
+#if FF_API_SUBFRAMES
+AV_CODEC_CAP_SUBFRAMES |
+#endif
+AV_CODEC_CAP_DR1,
.caps_internal= FF_CODEC_CAP_INIT_CLEANUP,
.p.sample_fmts= (const enum AVSampleFormat[]) { AV_SAMPLE_FMT_U8P,
AV_SAMPLE_FMT_S16P,
diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c
index 772636afde..613c76df0b 100644
--- a/libavcodec/apedec.c
+++ b/libavcodec/apedec.c
@@ -1680,7 +1680,11 @@ const FFCodec ff_ape_decoder = {
.init = ape_decode_init,
.close = ape_decode_close,
FF_CODEC_DECODE_CB(ape_decode_frame),
-.p.capabilities = AV_CODEC_CAP_SUBFRAMES | AV_CODEC_CAP_DELAY |
+.p.capabilities =
+#if FF_API_SUBFRAMES
+ AV_CODEC_CAP_SUBFRAMES |
+#endif
+ AV_CODEC_CAP_DELAY |
AV_CODEC_CAP_DR1,
.caps_internal = FF_CODEC_CAP_INIT_CLEANUP,
.flush = ape_flush,
diff --git a/libavcodec/atrac3.c b/libavcodec/atrac3.c
index 7415da590b..5851ee027c 100644
--- a/libavcodec/atrac3.c
+++ b/libavcodec/atrac3.c
@@ -1026,7 +1026,11 @@ const FFCodec ff_atrac3_decoder = {
.init = atrac3_decode_init,
.close= atrac3_decode_close,
FF_CODEC_DECODE_CB(atrac3_decode_frame),
-.p.capabilities = AV_CODEC_CAP_SUBFRAMES | AV_CODEC_CAP_DR1,
+.p.capabilities =
+#if FF_API_SUBFRAMES
+AV_CODEC_CAP_SUBFRAMES |
+#endif
+AV_CODEC_CAP_DR1,
.p.sample_fmts= (const enum AVSampleFormat[]) { AV_SAMPLE_FMT_FLTP,
AV_SAMPLE_FMT_NONE },
.caps_internal= FF_CODEC_CAP_INIT_CLEANUP,
@@ -1041,7 +1045,11 @@ const FFCodec ff_atrac3al_decoder = {
.init = atrac3_decode_init,
.close= atrac3_decode_close,
FF_CODEC_DECODE_CB(atrac3al_decode_frame),
-.p.capabilities = AV_CODEC_CAP_SUBFRAMES | AV_CODEC_CAP_DR1,
+.p.capabilities =
+#if FF_API_SUBFRAMES
+AV_CODEC_CAP_SUBFRAMES |
+#endif
+AV_CODEC_CAP_DR1,
.p.sample_fmts= (const enum AVSampleFormat[]) { AV_SAMPLE_FMT_FLTP,
AV_SAMPLE_FMT_NONE },
.caps_internal= FF_CODEC_CAP_INIT_CLEANUP,
diff --git a/libavcodec/atrac9dec.c b/libavcodec/atrac9dec.c
index 60962b1676..8a6940455d 100644
--- a/libavcodec/atrac9dec.c
+++ b/libavcodec/atrac9dec.c
@@ -1003,5 +1003,9 @@ const FFCodec ff_atrac9_decoder = {
FF_CODEC_DECODE_CB(atrac9_decode_frame),
.flush = atrac9_decode_flush,
.caps_internal = FF_CODEC_CAP_INIT_CLEANUP,
-.p.capabilities = AV_CODEC_CAP_SUBFRAMES | AV_CODEC_CAP_DR1 |
AV_CODEC_CAP_CHANNEL_CONF,
+.p.capabilities =
+#if FF_API_SUBFRAMES
+ AV_CODEC_CAP_SUBFRAMES |
+#endif
+ AV_CODEC_CAP_DR1 | AV_CODEC_CAP_CHANNEL_CONF,
};
diff --git a/libavcodec/bonk.c b/libavcodec/bonk.c
index 4a00270392..9a91b
