Re: [FFmpeg-devel] [PATCH 2/6] libavformat/sdp: remove whitespaces in fmtp

[Rémi Denis-Courmont]

Le maanantaina 6. marraskuuta 2023, 17.36.18 EET Kieran Kunhya a écrit :
> On Mon, 6 Nov 2023 at 15:19, Michael Riedl 
> 
> wrote:
> > Whitespaces after semicolon breaks some servers
> 
> Are you sure this patch doesn't break other servers? SDP is a painfully
> fragile format.

AFAIK, you're not supposed to have white spaces there. They are tolerated by 
most parsers as they are unambiguously not part of the value, is all.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/



___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/6] libavformat/sdp: remove whitespaces in fmtp

[Kieran Kunhya]

On Mon, 6 Nov 2023 at 15:19, Michael Riedl 
wrote:

> Whitespaces after semicolon breaks some servers
>

Are you sure this patch doesn't break other servers? SDP is a painfully
fragile format.

Kieran
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 2/6] libavformat/sdp: remove whitespaces in fmtp

[Michael Riedl]

Whitespaces after semicolon breaks some servers

Signed-off-by: Michael Riedl 
---
 libavformat/sdp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavformat/sdp.c b/libavformat/sdp.c
index 68889362906..5ab017b1ba5 100644
--- a/libavformat/sdp.c
+++ b/libavformat/sdp.c
@@ -159,8 +159,8 @@ static int extradata2psets(AVFormatContext *s, const 
AVCodecParameters *par,
 {
 char *psets, *p;
 const uint8_t *r;
-static const char pset_string[] = "; sprop-parameter-sets=";
-static const char profile_string[] = "; profile-level-id=";
+static const char pset_string[] = ";sprop-parameter-sets=";
+static const char profile_string[] = ";profile-level-id=";
 uint8_t *extradata = par->extradata;
 int extradata_size = par->extradata_size;
 uint8_t *tmpbuf = NULL;
-- 
2.39.2

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".