Re: [FFmpeg-devel] [PATCH 2/7] avformat/tee: Use ff_stream_encode_params_copy()

[Marton Balint]

On Wed, 13 Jul 2016, Jan Sebechlebsky wrote:




On 07/13/2016 12:56 PM, Jan Sebechlebsky wrote:



On 07/12/2016 10:23 AM, Nicolas George wrote:

Le quartidi 24 messidor, an CCXXIV, Jan Sebechlebsky a écrit :
I think it is used in decoding only - the documentation of AVStream 
mentions
only decoding and I also tried to search references to that field if 
it is
not used in some of the muxers. If you think it should be copied too 
I will

add it.
If you have checked it was never used in muxers, then ok. But you may 
want
to have a look at the "MKV Header: Writing duration early" mail that 
arrived

a few minutes ago.

Regards,


I think we can safely omit it, it's not used in any current muxers.
Soft Works contributors may use duration field in muxing context, I 
think they (or we) can then add copying of this field to 
ff_stream_encode_params_copy with their patch . The documentation of 
the field should be then modified as well.


Regards,
Jan
Resending this to mailing list - sorry I've accidentally replied 
privately again.


Thanks, applied.

Regards,
Marton
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/7] avformat/tee: Use ff_stream_encode_params_copy()

[Jan Sebechlebsky]

On 07/13/2016 12:56 PM, Jan Sebechlebsky wrote:



On 07/12/2016 10:23 AM, Nicolas George wrote:

Le quartidi 24 messidor, an CCXXIV, Jan Sebechlebsky a écrit :
I think it is used in decoding only - the documentation of AVStream 
mentions
only decoding and I also tried to search references to that field if 
it is
not used in some of the muxers. If you think it should be copied too 
I will

add it.
If you have checked it was never used in muxers, then ok. But you may 
want
to have a look at the "MKV Header: Writing duration early" mail that 
arrived

a few minutes ago.

Regards,


I think we can safely omit it, it's not used in any current muxers.
Soft Works contributors may use duration field in muxing context, I 
think they (or we) can then add copying of this field to 
ff_stream_encode_params_copy with their patch . The documentation of 
the field should be then modified as well.


Regards,
Jan
Resending this to mailing list - sorry I've accidentally replied 
privately again.


Regards,
Jan
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/7] avformat/tee: Use ff_stream_encode_params_copy()

[Nicolas George]

Le quintidi 25 messidor, an CCXXIV, Nicolas George a écrit :
> Le quartidi 24 messidor, an CCXXIV, Jan Sebechlebsky a écrit :
> > I think it is used in decoding only - the documentation of AVStream mentions
> > only decoding and I also tried to search references to that field if it is
> > not used in some of the muxers. If you think it should be copied too I will
> > add it.
> 
> If you have checked it was never used in muxers, then ok. But you may want
> to have a look at the "MKV Header: Writing duration early" mail that arrived
> a few minutes ago.

And remember to reply to the list.

Regards,

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/7] avformat/tee: Use ff_stream_encode_params_copy()

[Nicolas George]

Le septidi 17 messidor, an CCXXIV, sebechlebsky...@gmail.com a écrit :
> From: Jan Sebechlebsky 
> 
> Use ff_stream_encode_params_copy() to copy encoding-related
> fields (parameters) of stream.
> 
> Signed-off-by: Jan Sebechlebsky 
> ---
>  libavformat/tee.c | 14 +++---
>  1 file changed, 3 insertions(+), 11 deletions(-)
> 
> diff --git a/libavformat/tee.c b/libavformat/tee.c
> index 9d0a4cb..c276a37 100644
> --- a/libavformat/tee.c
> +++ b/libavformat/tee.c
> @@ -294,17 +294,9 @@ static int open_slave(AVFormatContext *avf, char *slave, 
> TeeSlave *tee_slave)
>  ret = AVERROR(ENOMEM);
>  goto end;
>  }
> -st2->id = st->id;
> -st2->r_frame_rate= st->r_frame_rate;
> -st2->time_base   = st->time_base;
> -st2->start_time  = st->start_time;

> -st2->duration= st->duration;

This one seems to have disappeared.

> -st2->nb_frames   = st->nb_frames;
> -st2->disposition = st->disposition;
> -st2->sample_aspect_ratio = st->sample_aspect_ratio;
> -st2->avg_frame_rate  = st->avg_frame_rate;
> -av_dict_copy(>metadata, st->metadata, 0);
> -if ((ret = avcodec_parameters_copy(st2->codecpar, st->codecpar)) < 0)
> +
> +ret = ff_stream_encode_params_copy(st2, st);
> +if (ret < 0)
>  goto end;
>  }
>  

Apart from that, looks ok.

Regards,

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel