Re: [FFmpeg-devel] [PATCH 3/3] avcodec/x86/rnd_template: silence -Wunused-function on --disable-mmx

[Ganesh Ajjanagadde]

On Sat, Sep 19, 2015 at 11:39 AM, Ganesh Ajjanagadde
 wrote:
> This silences some of the -Wunused-function warnings when compiled with 
> --disable-mmx, e.g
> http://fate.ffmpeg.org/log.cgi?time=20150919094617=compile=x86_64-archlinux-gcc-disable-mmx.
> Header guards are too brittle and ugly for this case.
>
> Signed-off-by: Ganesh Ajjanagadde 
> ---
>  libavcodec/x86/rnd_template.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/x86/rnd_template.c b/libavcodec/x86/rnd_template.c
> index c9fd71e..ddca4eb 100644
> --- a/libavcodec/x86/rnd_template.c
> +++ b/libavcodec/x86/rnd_template.c
> @@ -30,7 +30,7 @@
>  #include "inline_asm.h"
>
>  // put_pixels
> -STATIC void DEF(put, pixels8_xy2)(uint8_t *block, const uint8_t *pixels,
> +av_unused STATIC void DEF(put, pixels8_xy2)(uint8_t *block, const uint8_t 
> *pixels,
>ptrdiff_t line_size, int h)
>  {
>  MOVQ_ZERO(mm7);
> @@ -99,7 +99,7 @@ STATIC void DEF(put, pixels8_xy2)(uint8_t *block, const 
> uint8_t *pixels,
>
>  // avg_pixels
>  // this routine is 'slightly' suboptimal but mostly unused
> -STATIC void DEF(avg, pixels8_xy2)(uint8_t *block, const uint8_t *pixels,
> +av_unused STATIC void DEF(avg, pixels8_xy2)(uint8_t *block, const uint8_t 
> *pixels,
>ptrdiff_t line_size, int h)
>  {
>  MOVQ_ZERO(mm7);
> --
> 2.5.2
>

ping
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/x86/rnd_template: silence -Wunused-function on --disable-mmx

[Michael Niedermayer]

On Tue, Sep 29, 2015 at 08:09:44AM -0400, Ganesh Ajjanagadde wrote:
> On Sat, Sep 19, 2015 at 11:39 AM, Ganesh Ajjanagadde
>  wrote:
> > This silences some of the -Wunused-function warnings when compiled with 
> > --disable-mmx, e.g
> > http://fate.ffmpeg.org/log.cgi?time=20150919094617=compile=x86_64-archlinux-gcc-disable-mmx.
> > Header guards are too brittle and ugly for this case.
> >
> > Signed-off-by: Ganesh Ajjanagadde 
> > ---
> >  libavcodec/x86/rnd_template.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/libavcodec/x86/rnd_template.c b/libavcodec/x86/rnd_template.c
> > index c9fd71e..ddca4eb 100644
> > --- a/libavcodec/x86/rnd_template.c
> > +++ b/libavcodec/x86/rnd_template.c
> > @@ -30,7 +30,7 @@
> >  #include "inline_asm.h"
> >
> >  // put_pixels
> > -STATIC void DEF(put, pixels8_xy2)(uint8_t *block, const uint8_t *pixels,
> > +av_unused STATIC void DEF(put, pixels8_xy2)(uint8_t *block, const uint8_t 
> > *pixels,
> >ptrdiff_t line_size, int h)
> >  {
> >  MOVQ_ZERO(mm7);
> > @@ -99,7 +99,7 @@ STATIC void DEF(put, pixels8_xy2)(uint8_t *block, const 
> > uint8_t *pixels,
> >
> >  // avg_pixels
> >  // this routine is 'slightly' suboptimal but mostly unused
> > -STATIC void DEF(avg, pixels8_xy2)(uint8_t *block, const uint8_t *pixels,
> > +av_unused STATIC void DEF(avg, pixels8_xy2)(uint8_t *block, const uint8_t 
> > *pixels,
> >ptrdiff_t line_size, int h)
> >  {
> >  MOVQ_ZERO(mm7);
> > --
> > 2.5.2
> >
> 
> ping

applied

thanks

[...]
-- 
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel